tor-browser

commit 7359b193a2dc6a7fd47fb3d7ee9ba3a65675ccf2
parent cfd2a60aa406f79101ad157dce22359d11895daa
Author: Alexandru Marc <amarc@mozilla.com>
Date:   Fri,  5 Dec 2025 11:50:47 +0200

Revert "Bug 2003857 - [bidi] Reuse waitForVisibility helper to wait for document to be visible r=Sasha" for causing puppeteer timeouts @ screenshot.spec.js

This reverts commit c90c138fc659905dc90f030aad5af1ef9fa44da0.

Revert "Bug 2003857 - [bidi] Wait for document to be visible in browsingContext.create with background=false r=Sasha"

This reverts commit 793fc3bce145d88d30efe245d1eee89a1e7ac061.

Diffstat:
M
remote/webdriver-bidi/modules/root/browsingContext.sys.mjs
 | 
21
+++++++--------------

1 file changed, 7 insertions(+), 14 deletions(-)
diff --git a/remote/webdriver-bidi/modules/root/browsingContext.sys.mjs b/remote/webdriver-bidi/modules/root/browsingContext.sys.mjs
@@ -318,7 +318,7 @@ class BrowsingContextModule extends RootBiDiModule {
       // Bug 1884142: It's not supported on Android for the TestRunner package.
       const selectedBrowser = lazy.TabManager.getBrowserForTab(selectedTab);
       activated.push(
-        this.#waitForVisibilityState(selectedBrowser.browsingContext, "hidden")
+        this.#waitForVisibilityChange(selectedBrowser.browsingContext)
       );
     }
 
@@ -686,7 +686,7 @@ class BrowsingContextModule extends RootBiDiModule {
       );
     }
 
-    let waitForVisibilityStatePromise;
+    let waitForVisibilityChangePromise;
     switch (type) {
       case "window": {
         const newWindow = await lazy.windowManager.openBrowserWindow({
@@ -717,9 +717,8 @@ class BrowsingContextModule extends RootBiDiModule {
 
           // Create the promise immediately, but await it later in parallel with
           // waitForInitialNavigationCompleted.
-          waitForVisibilityStatePromise = this.#waitForVisibilityState(
-            lazy.TabManager.getBrowserForTab(selectedTab).browsingContext,
-            "hidden"
+          waitForVisibilityChangePromise = this.#waitForVisibilityChange(
+            lazy.TabManager.getBrowserForTab(selectedTab).browsingContext
           );
         }
 
@@ -751,7 +750,7 @@ class BrowsingContextModule extends RootBiDiModule {
           unloadTimeout: 5000,
         }
       ),
-      waitForVisibilityStatePromise,
+      waitForVisibilityChangePromise,
       blocker.promise,
     ]);
 
@@ -770,12 +769,6 @@ class BrowsingContextModule extends RootBiDiModule {
     // Force a reflow by accessing `clientHeight` (see Bug 1847044).
     browser.parentElement.clientHeight;
 
-    if (!background && !lazy.AppInfo.isAndroid) {
-      // See Bug 2002097, on slow platforms, the newly created tab might not be
-      // visible immediately.
-      await this.#waitForVisibilityState(browser.browsingContext, "visible");
-    }
-
     return {
       context: lazy.NavigableManager.getIdForBrowser(browser),
     };
@@ -2371,11 +2364,11 @@ class BrowsingContextModule extends RootBiDiModule {
     }
   }
 
-  #waitForVisibilityState(browsingContext, expectedState) {
+  #waitForVisibilityChange(browsingContext) {
     return this._forwardToWindowGlobal(
       "_awaitVisibilityState",
       browsingContext.id,
-      { value: expectedState },
+      { value: "hidden" },
       { retryOnAbort: true }
     );
   }