tor-browser

commit 72d0c90bf2398b3a6e45acf1e945669176d7688a
parent 2c59988c7e8ee9f4a2b30834aec69e015ce8919b
Author: scottdowne <sdowne@mozilla.com>
Date:   Tue,  6 Jan 2026 21:09:56 +0000

Bug 2008479 - Newtab moving to index lookup for frecency sorting r=home-newtab-reviewers,nbarrett

Differential Revision: https://phabricator.services.mozilla.com/D277819

Diffstat:
M
browser/extensions/newtab/lib/FrecencyBoostProvider/FrecencyBoostProvider.mjs
 | 
37
++++++++++++++-----------------------

1 file changed, 14 insertions(+), 23 deletions(-)
diff --git a/browser/extensions/newtab/lib/FrecencyBoostProvider/FrecencyBoostProvider.mjs b/browser/extensions/newtab/lib/FrecencyBoostProvider/FrecencyBoostProvider.mjs
@@ -164,15 +164,13 @@ export class FrecencyBoostProvider {
 
   /**
    * Build frecency-boosted spocs from a list of sponsor domains by checking Places history.
-   * Checks if domains exist in history, dedupes against organic topsites,
-   * and returns all matches sorted by frecency.
+   * Checks if domains exist in history, and returns all matches sorted by frecency.
    *
-   * @param {Array} sponsors - List of sponsor domain objects with hostname and title
    * @param {Integer} numItems - Number of frecency items to check against.
    * @returns {Array} Array of sponsored tile objects sorted by frecency, or empty array
    */
-  async buildFrecencyBoostedSpocs(sponsorsToCheck, numItems) {
-    if (!sponsorsToCheck.length) {
+  async buildFrecencyBoostedSpocs(numItems) {
+    if (!this._frecencyBoostedSponsors.size) {
       return [];
     }
 
@@ -187,23 +185,21 @@ export class FrecencyBoostProvider {
     const candidates = [];
     frecent.forEach(site => {
       const normalizedSiteUrl = lazy.NewTabUtils.shortURL(site);
-      for (const domainObj of sponsorsToCheck) {
-        if (
-          normalizedSiteUrl !== domainObj.hostname ||
-          lazy.NewTabUtils.blockedLinks.isBlocked({ url: domainObj.domain })
-        ) {
-          continue;
-        }
+      const candidate = this._frecencyBoostedSponsors.get(normalizedSiteUrl);
 
+      if (
+        candidate &&
+        !lazy.NewTabUtils.blockedLinks.isBlocked({ url: candidate.domain })
+      ) {
         candidates.push({
-          hostname: domainObj.hostname,
-          url: domainObj.redirectURL,
-          label: domainObj.title,
+          hostname: candidate.hostname,
+          url: candidate.redirectURL,
+          label: candidate.title,
           partner: SPONSORED_TILE_PARTNER_FREC_BOOST,
           type: "frecency-boost",
           frecency: site.frecency,
           show_sponsored_label: true,
-          favicon: domainObj.faviconDataURI,
+          favicon: candidate.faviconDataURI,
           faviconSize: 96,
         });
       }
@@ -218,13 +214,8 @@ export class FrecencyBoostProvider {
       await this._importFrecencyBoostedSponsors();
     }
 
-    let candidates = [];
-    if (this._frecencyBoostedSponsors.size) {
-      const domainList = Array.from(this._frecencyBoostedSponsors.values());
-      // Find all matches from the sponsor domains, sorted by frecency
-      candidates = await this.buildFrecencyBoostedSpocs(domainList, numItems);
-    }
-    this._links = candidates;
+    // Find all matches from the sponsor domains, sorted by frecency
+    this._links = await this.buildFrecencyBoostedSpocs(numItems);
     await this.cache.set("links", this._links);
   }