tor-browser

commit 7168384b9a862843132fa8524303ecd18808c086
parent 9e9e4fadc7b4de74afc45e7e03198d0b14823fb6
Author: Harsheet <hsohaney@mozilla.com>
Date:   Thu,  9 Oct 2025 18:53:09 +0000

Bug 1992196 - remove commonly used password as a check in backup settings. r=cdupuis,kpatenio

Differential Revision: https://phabricator.services.mozilla.com/D268051

Diffstat:
M
browser/components/backup/BackupService.sys.mjs
 | 
2
--
M
browser/components/backup/content/password-rules-tooltip.mjs
 | 
13
+++++++++++++
M
browser/locales-preview/backupSettings.ftl
 | 
1
-

3 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/browser/components/backup/BackupService.sys.mjs b/browser/components/backup/BackupService.sys.mjs
@@ -3325,8 +3325,6 @@ export class BackupService extends EventTarget {
       );
     }
 
-    // TODO: Enforce other password rules here, such as ensuring that the
-    // password is not considered common.
     ({ instance: encState } =
       await lazy.ArchiveEncryptionState.initialize(password));
     if (!encState) {
diff --git a/browser/components/backup/content/password-rules-tooltip.mjs b/browser/components/backup/content/password-rules-tooltip.mjs
@@ -51,6 +51,19 @@ export default class PasswordRulesTooltip extends MozLitElement {
               class="rule-description"
             ></span>
           </li>
+          <li>
+            <img
+              class="icon"
+              src="chrome://browser/skin/preferences/category-privacy-security.svg"
+            />
+            <span data-l10n-id="password-rules-disclaimer"
+              ><a
+                data-l10n-name="password-support-link"
+                target="_blank"
+                href=${`${this.supportBaseLink}password-strength`}
+              ></a
+            ></span>
+          </li>
         </ul>
       </div>
     `;
diff --git a/browser/locales-preview/backupSettings.ftl b/browser/locales-preview/backupSettings.ftl
@@ -185,7 +185,6 @@ change-backup-encryption-header = Change backup password
 password-rules-header = Password requirements
 password-rules-length-description = At least 8 characters
 password-rules-email-description = Not your email address
-password-rules-common-description = Not a commonly used password
 password-rules-disclaimer = Stay safe — don’t reuse passwords. See more tips to <a data-l10n-name="password-support-link">create strong passwords</a>.
 password-validity-has-email = Can’t be an email address
 password-validity-do-not-match = Passwords don’t match