tor-browser

The Tor Browser
git clone https://git.dasho.dev/tor-browser.git
Log | Files | Refs | README | LICENSE

commit 6f4f2f3803e89a5695acdc0563ca21813e8705ba
parent c665322ab04888bff92b6e05f798e2d27b7b20ca
Author: Dan Baker <dbaker@mozilla.com>
Date:   Wed, 22 Oct 2025 13:29:08 -0600

Bug 1995393 - Vendor libwebrtc from 16e1c24c07

Upstream commit: https://webrtc.googlesource.com/src/+/16e1c24c07a5ada38999542dacc08c40209d5ec6
    Log error when candidates are created without mid and index

    Bug: none
    Change-Id: Ife764008c67bea6028d50c94e55b248d3ea7eec7
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/403080
    Reviewed-by: Harald Alvestrand <hta@webrtc.org>
    Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
    Auto-Submit: Tomas Gunnarsson <tommi@webrtc.org>
    Cr-Commit-Position: refs/heads/main@{#45276}

Diffstat:
Mthird_party/libwebrtc/README.mozilla.last-vendor | 4++--
Mthird_party/libwebrtc/api/jsep_ice_candidate.cc | 7++++++-
2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/third_party/libwebrtc/README.mozilla.last-vendor b/third_party/libwebrtc/README.mozilla.last-vendor @@ -1,4 +1,4 @@ # ./mach python dom/media/webrtc/third_party_build/vendor-libwebrtc.py --from-local /Users/danielbaker/elm/.moz-fast-forward/moz-libwebrtc --commit mozpatches libwebrtc -libwebrtc updated from /Users/danielbaker/elm/.moz-fast-forward/moz-libwebrtc commit mozpatches on 2025-10-22T19:26:40.022101+00:00. +libwebrtc updated from /Users/danielbaker/elm/.moz-fast-forward/moz-libwebrtc commit mozpatches on 2025-10-22T19:28:58.779552+00:00. # base of lastest vendoring -ddd9a55854 +16e1c24c07 diff --git a/third_party/libwebrtc/api/jsep_ice_candidate.cc b/third_party/libwebrtc/api/jsep_ice_candidate.cc @@ -23,6 +23,7 @@ #include "api/candidate.h" #include "api/jsep.h" #include "rtc_base/checks.h" +#include "rtc_base/logging.h" namespace webrtc { namespace { @@ -43,7 +44,11 @@ IceCandidate::IceCandidate(absl::string_view sdp_mid, const Candidate& candidate) : sdp_mid_(sdp_mid), sdp_mline_index_(EnsureValidMLineIndex(sdp_mline_index)), - candidate_(candidate) {} + candidate_(candidate) { + if (sdp_mid_.empty() && sdp_mline_index_ < 0) { + RTC_LOG(LS_ERROR) << "Neither mid nor index supplied for IceCandidate."; + } +} void IceCandidateCollection::add(std::unique_ptr<IceCandidate> candidate) { candidates_.push_back(std::move(candidate));