commit 6f28060023c9ae16268aac3e16be41c70c391e6f
parent 00e7734bce5fb5592f9d578dc659915aa12951d5
Author: Cristina Horotan <chorotan@mozilla.com>
Date: Sat, 13 Dec 2025 05:06:34 +0200
Revert "Bug 2001725 - Restoring link-paragraph handling so Privacy/Terms links open in chatbot onboarding r=Mardak,ai-frontend-reviewers,Gijs" for causing bc failures on browser_chat_sidebar.js
This reverts commit 5a4a19e0909b3c15f73c09f422234fd293fdaa8e.
Diffstat:
2 files changed, 1 insertion(+), 31 deletions(-)
diff --git a/browser/components/genai/chat.js b/browser/components/genai/chat.js
@@ -505,19 +505,6 @@ function showOnboarding(length) {
link.setAttribute("value", name);
}
document.l10n.setAttributes(links, config.linksId);
-
- const handleLink = ev => {
- const { href } = ev.target;
- if (href) {
- ev.preventDefault();
- openLink(href);
- }
- };
-
- if (!links._listenerAdded) {
- links?.addEventListener("click", handleLink);
- links._listenerAdded = true;
- }
}
break;
diff --git a/browser/components/genai/tests/browser/browser_chat_sidebar.js b/browser/components/genai/tests/browser/browser_chat_sidebar.js
@@ -1,10 +1,6 @@
/* Any copyright is dedicated to the Public Domain.
* http://creativecommons.org/publicdomain/zero/1.0/ */
-const { sinon } = ChromeUtils.importESModule(
- "resource://testing-common/Sinon.sys.mjs"
-);
-
ChromeUtils.defineESModuleGetters(this, {
PlacesTestUtils: "resource://testing-common/PlacesTestUtils.sys.mjs",
});
@@ -100,8 +96,7 @@ add_task(async function test_sidebar_onboarding() {
Services.fog.testResetFOG();
await SidebarController.show("viewGenaiChatSidebar");
- const win = SidebarController.browser.contentWindow;
- const { document, browserPromise } = win;
+ const { document, browserPromise } = SidebarController.browser.contentWindow;
const label = await TestUtils.waitForCondition(() =>
document.querySelector("label:has(.localhost)")
);
@@ -122,18 +117,6 @@ add_task(async function test_sidebar_onboarding() {
"Should have previewed provider"
);
- const link = await TestUtils.waitForCondition(() =>
- document.querySelector(".link-paragraph a")
- );
- const expectedURL = link.href;
-
- const stub = sinon.stub(win, "openLink");
-
- link.click();
-
- Assert.ok(stub.calledOnce, "openLink should call once");
- Assert.equal(stub.firstCall.args[0], expectedURL);
-
const pickButton = await TestUtils.waitForCondition(() =>
document.querySelector(".chat_pick .primary:not([disabled])")
);