commit 6da63a9770d5fa24d4facfb281e29126a8dec1c3
parent db0d2a4c6f6056ad15c55c23a9a2eb58360aeb96
Author: Michael Froman <mfroman@mozilla.com>
Date: Wed, 8 Oct 2025 15:29:37 -0500
Bug 1993083 - Vendor libwebrtc from 2b03a25dde
Upstream commit: https://webrtc.googlesource.com/src/+/2b03a25dde6e4b6c2e2dad3c406b585f8ddf333b
Add munge-allowed histogram
This allows us to track how many ufrag munges that do not
hit the restriction filters.
Bug: b/409713509
Change-Id: Ic6f0bd714d26a3c5b97496df5afa99c51df89611
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/391180
Reviewed-by: Johannes Kron <kron@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#44977}
Diffstat:
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/third_party/libwebrtc/README.mozilla.last-vendor b/third_party/libwebrtc/README.mozilla.last-vendor
@@ -1,4 +1,4 @@
# ./mach python dom/media/webrtc/third_party_build/vendor-libwebrtc.py --from-local /home/mfroman/mozilla/elm/.moz-fast-forward/moz-libwebrtc --commit mozpatches libwebrtc
-libwebrtc updated from /home/mfroman/mozilla/elm/.moz-fast-forward/moz-libwebrtc commit mozpatches on 2025-10-08T20:28:21.515074+00:00.
+libwebrtc updated from /home/mfroman/mozilla/elm/.moz-fast-forward/moz-libwebrtc commit mozpatches on 2025-10-08T20:29:28.419424+00:00.
# base of lastest vendoring
-b65c6012cf
+2b03a25dde
diff --git a/third_party/libwebrtc/pc/sdp_offer_answer.cc b/third_party/libwebrtc/pc/sdp_offer_answer.cc
@@ -5338,6 +5338,7 @@ bool SdpOfferAnswerHandler::ReadyToUseRemoteCandidate(
const std::string host = candidate->candidate().address().HostAsURIString();
const std::vector<absl::string_view> restricted_address_list =
absl::StrSplit(restricted_addresses, '|');
+ bool allowed = true;
for (const absl::string_view restricted_address : restricted_address_list) {
const std::pair<absl::string_view, absl::string_view> address =
absl::StrSplit(restricted_address, ':');
@@ -5358,11 +5359,14 @@ bool SdpOfferAnswerHandler::ReadyToUseRemoteCandidate(
RTC_HISTOGRAM_ENUMERATION_SPARSE(
"WebRTC.PeerConnection.RestrictedCandidates.Port",
candidate->candidate().address().port(), 65536);
- return false;
+ allowed = false;
+ break;
}
}
+ RTC_HISTOGRAM_BOOLEAN(
+ "WebRTC.PeerConnection.RestrictedCandidates.MungeAllowed", allowed);
+ return allowed;
}
-
return true;
}