tor-browser

The Tor Browser
git clone https://git.dasho.dev/tor-browser.git
Log | Files | Refs | README | LICENSE

commit 6d6687e82f8028aeb04daccf549196a4e3510a66
parent 658e8ba3a437aaec4be1e9092f8a35ac25a31f2e
Author: Gregory Pappas <gp3033@protonmail.com>
Date:   Mon,  1 Dec 2025 21:15:38 +0000

Bug 2003280 - Clean up dead prefs in user.js files r=perftest-reviewers,spidermonkey-reviewers,sparky,whimboo,jgraham,jmaher,toolkit-telemetry-reviewers,mgaudet

- browser.EULA.override became unused in bug 1409054
- browser.addon-watch.interval became unused in bug 1186491
- browser.console.showInPanel became unused in bug 1039866
- browser.contentHandlers.* prefs became unused in bug 1477670 / bug 1589182
- browser.reader.detectedFirstArticle became unused in bug 1352501
- browser.ui.layout.tablet became unused in bug 831236
- browser.uitour.pinnedTabUrl became unused in bug 1122830
- browser.webapps.checkForUpdates became unused in bug 1235869
- browser.webapps.testing became unused in bug 1235869
- devtools.timeline.enabled became unused in bug 1148463
- extensions.defaultProviders.enabled became unused in bug 1459998
- general.useragent.updates.url became unused in bug 1513574
- geo.provider.network.compare.url became unused in bug 1714259
- hangmonitor.timeout became unused in bug 1448040
- identity.fxaccounts.migrateToDevEdition became unused in bug 1395460
- javascript.allow.mailnews became unused in bug 374577
- marionette.defaultPrefs.port became unused in bug 1344748
- marionette.log.truncate became unused in bug 1700392
- media.autoplay.ask-permission became unused in bug 1513039
- media.capturestream_hints.enabled became unused in bug 1129263
- media.test.dumpDebugInfo became unused in bug 1542674
- network.sntp.maxRetryCount became unused in bug 1357323
- network.sntp.pools became unused in bug 1357323
- nglayout.initialpaint.unsuppress_with_no_background became unused in bug 1701807
- privacy.trackingprotection.introURL became unused in bug 1564367
- security.enable_java became unused in bug 506985
- shell.checkDefaultClient is a SeaMonkey pref that was never used in Firefox (bug 453713)
- toolkit.telemetry.coverage.endpoint.base seems to be a typo? It was introduced
  in bug 1492656 alongside toolkit.coverage.endpoint.base, which is an actual pref.
- ui.windowBackground became unused in bug 1738614
- ui.windowForeground became unused in bug 1738614

Differential Revision: https://phabricator.services.mozilla.com/D274596

Diffstat:
Mjs/src/tests/user.js | 3---
Mtesting/condprofile/condprof/tests/profile/user.js | 3+--
Mtesting/profiles/common/user.js | 6------
Mtesting/profiles/mochitest/user.js | 5-----
Mtesting/profiles/perf/user.js | 14--------------
Mtesting/profiles/raptor/user.js | 1-
Mtesting/profiles/reftest/user.js | 2--
Mtesting/profiles/unittest-required/user.js | 27---------------------------
Mtesting/profiles/web-platform/user.js | 4----
Mtesting/profiles/xpcshell/user.js | 1-
10 files changed, 1 insertion(+), 65 deletions(-)

diff --git a/js/src/tests/user.js b/js/src/tests/user.js @@ -10,13 +10,11 @@ user_pref("dom.allow_scripts_to_close_windows", true); user_pref("dom.disable_open_during_load", false); user_pref("dom.max_script_run_time", 0); user_pref("dom.max_chrome_script_run_time", 0); -user_pref("javascript.allow.mailnews", true); user_pref("layout.css.report_errors", true); user_pref("browser.warnOnQuit", false); user_pref("browser.cache.check_doc_frequency", 1); user_pref("extensions.checkCompatibility", false); user_pref("extensions.checkUpdateSecurity", false); -user_pref("browser.EULA.override", true); user_pref("toolkit.startup.max_resumed_crashes", -1); user_pref("security.turn_off_all_security_so_that_viruses_can_take_over_this_computer", true); user_pref("datareporting.healthreport.uploadEnabled", false); @@ -27,6 +25,5 @@ user_pref("privacy.trackingprotection.annotate_channels", false); user_pref("privacy.trackingprotection.enabled", false); user_pref("privacy.trackingprotection.pbmode.enabled", false); user_pref("general.useragent.updates.enabled", false); -user_pref("browser.webapps.checkForUpdates", 0); user_pref("javascript.options.experimental.weakrefs.expose_cleanupSome", true); user_pref("javascript.options.experimental.iterator_helpers", true); diff --git a/testing/condprofile/condprof/tests/profile/user.js b/testing/condprofile/condprof/tests/profile/user.js @@ -1,9 +1,8 @@ #Prefs used for the unit test user_pref("focusmanager.testmode", true); -user_pref("marionette.defaultPrefs.port", 2828); user_pref("marionette.port", 2828); user_pref("remote.log.level", "Trace"); -user_pref("marionette.log.truncate", false); +user_pref("remote.log.truncate", false); user_pref("extensions.autoDisableScopes", 0); user_pref("devtools.debugger.remote-enabled", true); diff --git a/testing/profiles/common/user.js b/testing/profiles/common/user.js @@ -28,8 +28,6 @@ user_pref("browser.pagethumbnails.capturing_disabled", true); user_pref("browser.search.region", "US"); // disable infobar for tests user_pref("browser.search.removeEngineInfobar.enabled", false); -// Disable webapp updates. Yes, it is supposed to be an integer. -user_pref("browser.webapps.checkForUpdates", 0); // We do not wish to display datareporting policy notifications as it might // cause other tests to fail. Tests that wish to test the notification functionality // should explicitly disable this pref. @@ -49,7 +47,6 @@ user_pref("extensions.getAddons.discovery.api_url", "data:;base64,eyJyZXN1bHRzIj user_pref("extensions.webextensions.warnings-as-errors", true); // Disable useragent updates. user_pref("general.useragent.updates.enabled", false); -user_pref("hangmonitor.timeout", 0); // no hang monitor user_pref("media.gmp-manager.updateEnabled", false); // Don't do network connections for mitm priming user_pref("security.certerrors.mitm.priming.enabled", false); @@ -61,11 +58,9 @@ user_pref("services.settings.server", "data:,#remote-settings-dummy/v1"); // Ensure autoplay is enabled for all platforms. user_pref("media.autoplay.default", 0); // 0=Allowed, 1=Blocked, 2=Prompt user_pref("media.autoplay.blocking_policy", 0); -user_pref("media.autoplay.ask-permission", false); user_pref("media.allowed-to-play.enabled", true); // Ensure media can always play without delay user_pref("media.block-autoplay-until-in-foreground", false); -user_pref("toolkit.telemetry.coverage.endpoint.base", "http://localhost"); // Don't ask for a request in testing unless explicitly set this as true. user_pref("media.geckoview.autoplay.request", false); // No need to delay wakelock releasing for testing @@ -73,7 +68,6 @@ user_pref("media.wakelock.audio.delay-releasing.ms", 0); // Don't use SCContentSharingPicker in tests as it will block on user // interaction. user_pref("media.getdisplaymedia.screencapturekit.picker.enabled", false); -user_pref("geo.provider.network.compare.url", ""); user_pref("browser.region.network.url", ""); // Do not unload tabs on low memory when testing user_pref("browser.tabs.unloadOnLowMemory", false); diff --git a/testing/profiles/mochitest/user.js b/testing/profiles/mochitest/user.js @@ -9,11 +9,6 @@ user_pref("browser.sessionstore.resume_from_crash", false); // Better stacks for errors. user_pref("javascript.options.asyncstack_capture_debuggee_only", false); -// Don't enable paint suppression when the background is unknown. While paint -// is suppressed, synthetic click events and co. go to the old page, which can -// be confusing for tests that send click events before the first paint. -user_pref("nglayout.initialpaint.unsuppress_with_no_background", true); - // Disable prefers-reduced-motion to ensure that smooth scrolls can be tested. user_pref("general.smoothScroll", true); diff --git a/testing/profiles/perf/user.js b/testing/profiles/perf/user.js @@ -5,24 +5,15 @@ // Base preferences file used by performance harnesses /* globals user_pref */ user_pref("app.normandy.api_url", "https://127.0.0.1/selfsupport-dummy/"); -user_pref("browser.EULA.override", true); -user_pref("browser.addon-watch.interval", -1); // Deactivate add-on watching // Disable Bookmark backups by default. user_pref("browser.bookmarks.max_backups", 0); user_pref("browser.cache.disk.smart_size.enabled", false); -user_pref("browser.contentHandlers.types.0.uri", "http://127.0.0.1/rss?url=%s"); -user_pref("browser.contentHandlers.types.1.uri", "http://127.0.0.1/rss?url=%s"); -user_pref("browser.contentHandlers.types.2.uri", "http://127.0.0.1/rss?url=%s"); -user_pref("browser.contentHandlers.types.3.uri", "http://127.0.0.1/rss?url=%s"); -user_pref("browser.contentHandlers.types.4.uri", "http://127.0.0.1/rss?url=%s"); -user_pref("browser.contentHandlers.types.5.uri", "http://127.0.0.1/rss?url=%s"); user_pref("browser.link.open_newwindow", 2); user_pref("browser.newtabpage.activity-stream.default.sites", ""); user_pref("browser.newtabpage.activity-stream.telemetry", false); // Don't load or render cfrs by default user_pref("browser.newtabpage.activity-stream.asrouter.userprefs.cfr.features", false); user_pref("browser.newtabpage.activity-stream.asrouter.userprefs.cfr.addons", false); -user_pref("browser.reader.detectedFirstArticle", true); user_pref("browser.safebrowsing.blockedURIs.enabled", false); user_pref("browser.safebrowsing.downloads.enabled", false); user_pref("browser.safebrowsing.downloads.remote.url", "http://127.0.0.1/safebrowsing-dummy/downloads"); @@ -43,7 +34,6 @@ user_pref("datareporting.healthreport.documentServerURI", "http://127.0.0.1/heal user_pref("devtools.chrome.enabled", false); user_pref("devtools.debugger.remote-enabled", false); user_pref("devtools.theme", "light"); -user_pref("devtools.timeline.enabled", false); user_pref("dom.allow_scripts_to_close_windows", true); user_pref("dom.disable_open_during_load", false); user_pref("dom.disable_window_flip", true); @@ -63,8 +53,6 @@ user_pref("extensions.update.background.url", "http://127.0.0.1/extensions-dummy user_pref("extensions.update.notifyUser", false); user_pref("extensions.update.url", "http://127.0.0.1/extensions-dummy/updateURL"); user_pref("identity.fxaccounts.auth.uri", "https://127.0.0.1/fxa-dummy/"); -user_pref("identity.fxaccounts.migrateToDevEdition", false); -user_pref("media.capturestream_hints.enabled", true); user_pref("media.gmp-manager.url", "http://127.0.0.1/gmpmanager-dummy/update.xml"); // Don't block old libavcodec libraries when testing, because our test systems // cannot easily be upgraded. @@ -80,9 +68,7 @@ user_pref("places.database.lastMaintenance", 2147483647); user_pref("privacy.reduceTimerPrecision", false); // Bug 1445243 - reduces precision of tests user_pref("privacy.trackingprotection.annotate_channels", false); user_pref("privacy.trackingprotection.enabled", false); -user_pref("privacy.trackingprotection.introURL", "http://127.0.0.1/trackingprotection/tour"); user_pref("privacy.trackingprotection.pbmode.enabled", false); -user_pref("security.enable_java", false); user_pref("network.protocol-handler.external.ext+damp", true); user_pref("network.protocol-handler.external.ext+twinopen", true); user_pref("security.fileuri.strict_origin_policy", false); diff --git a/testing/profiles/raptor/user.js b/testing/profiles/raptor/user.js @@ -46,7 +46,6 @@ user_pref('toolkit.telemetry.initDelay', 99999999); // disable autoplay for raptor tests user_pref('media.autoplay.default', 5); -user_pref('media.autoplay.ask-permission', true); user_pref('media.autoplay.blocking_policy', 1); user_pref('media.allowed-to-play.enabled', false); user_pref('media.block-autoplay-until-in-foreground', true); diff --git a/testing/profiles/reftest/user.js b/testing/profiles/reftest/user.js @@ -110,8 +110,6 @@ user_pref("ui.caretWidth", 1); user_pref("ui.prefersReducedMotion", 0); user_pref("ui.systemUsesDarkTheme", 0); user_pref("ui.useAccessibilityTheme", 0); -user_pref("ui.windowForeground", ""); -user_pref("ui.windowBackground", ""); // Turn off the Push service. user_pref("dom.push.serverURL", ""); // Disable intermittent telemetry collection diff --git a/testing/profiles/unittest-required/user.js b/testing/profiles/unittest-required/user.js @@ -18,18 +18,8 @@ user_pref("app.update.staging.enabled", false); // and causing false-positive test failures. See bug 1176798, bug 1177018, // bug 1210465. user_pref("apz.content_response_timeout", 60000); -user_pref("browser.EULA.override", true); // Disable Bookmark backups by default. user_pref("browser.bookmarks.max_backups", 0); -user_pref("browser.console.showInPanel", true); -// Don't connect to Yahoo! for RSS feed tests. -// en-US only uses .types.0.uri, but set all of them just to be sure. -user_pref("browser.contentHandlers.types.0.uri", "http://test1.example.org/rss?url=%s"); -user_pref("browser.contentHandlers.types.1.uri", "http://test1.example.org/rss?url=%s"); -user_pref("browser.contentHandlers.types.2.uri", "http://test1.example.org/rss?url=%s"); -user_pref("browser.contentHandlers.types.3.uri", "http://test1.example.org/rss?url=%s"); -user_pref("browser.contentHandlers.types.4.uri", "http://test1.example.org/rss?url=%s"); -user_pref("browser.contentHandlers.types.5.uri", "http://test1.example.org/rss?url=%s"); // Indicate that the download panel has been shown once so that whichever // download test runs first doesn't show the popup inconsistently. user_pref("browser.download.panel.shown", true); @@ -51,10 +41,7 @@ user_pref("browser.shell.checkDefaultBrowser", false); user_pref("browser.startup.page", 0); // use about:blank, not browser.startup.homepage // Don't show a delay when hiding the audio indicator during tests user_pref("browser.tabs.delayHidingAudioPlayingIconMS", 0); -// force tablet UI off -user_pref("browser.ui.layout.tablet", 0); // Ensure UITour won't hit the network -user_pref("browser.uitour.pinnedTabUrl", "http://{server}/uitour-dummy/pinnedTab"); user_pref("browser.uitour.url", "http://{server}/uitour-dummy/tour"); // Turn off Merino suggestions in the location bar so as not to trigger network // connections. @@ -66,8 +53,6 @@ user_pref("browser.urlbar.suggest.searches", false); // URIFixup whitelist user_pref("browser.fixup.domainsuffixwhitelist.test", true); user_pref("browser.warnOnQuit", false); -// Enable webapps testing mode, which bypasses native installation. -user_pref("browser.webapps.testing", true); user_pref("captivedetect.canonicalURL", "http://{server}/captive-detect/success.txt"); // Enable android logcat for better diagnostics on beta/release user_pref("consoleservice.logcat", true); @@ -98,8 +83,6 @@ user_pref("dom.use_xbl_scopes_for_remote_xul", true); user_pref("extensions.autoDisableScopes", 0); user_pref("extensions.blocklist.detailsURL", "http://{server}/extensions-dummy/blocklistDetailsURL"); user_pref("extensions.blocklist.itemURL", "http://{server}/extensions-dummy/blocklistItemURL"); -// XPI extensions are required for test harnesses to load -user_pref("extensions.defaultProviders.enabled", true); // Disable metadata caching for installed add-ons by default user_pref("extensions.getAddons.cache.enabled", false); // Make sure AddonRepository won't hit the network @@ -118,7 +101,6 @@ user_pref("findbar.modalHighlight", false); // Existing tests assume there is no font size inflation. user_pref("font.size.inflation.emPerLine", 0); user_pref("font.size.inflation.minTwips", 0); -user_pref("general.useragent.updates.url", "https://example.com/0/%APP_ID%"); // Always use network provider for geolocation tests // so we bypass the OSX dialog raised by the corelocation provider user_pref("geo.provider.testing", true); @@ -154,7 +136,6 @@ user_pref("media.preload.auto", 3); // auto = enough user_pref("media.preload.default", 2); // default = metadata user_pref("media.preload.default.cellular", 2); // default = metadata user_pref("media.suspend-background-video.enabled", false); -user_pref("media.test.dumpDebugInfo", true); user_pref("media.volume_scale", "0.01"); // Enable speech synth test service, and disable built in platform services. user_pref("media.webspeech.synth.test", true); @@ -162,12 +143,6 @@ user_pref("network.http.prompt-temp-redirect", false); // Disable speculative connections so they aren't reported as leaking when they're hanging around. user_pref("network.http.speculative-parallel-limit", 0); user_pref("network.manage-offline-status", false); -// We know the SNTP request will fail, since localhost isn't listening on -// port 135. The default number of retries (10) is excessive, but retrying -// at least once will mean that codepath is still tested in automation. -user_pref("network.sntp.maxRetryCount", 1); -// Make sure SNTP requests don't hit the network -user_pref("network.sntp.pools", "{server}"); // Set places maintenance far in the future (the maximum time possible in an // int32_t) to avoid it kicking in during tests. The maintenance can take a // relatively long time which may cause unnecessary intermittents and slow down @@ -176,7 +151,6 @@ user_pref("places.database.lastMaintenance", 2147483647); // Turn off semantic history search as it triggers network connections to // download ML models. user_pref("places.semanticHistory.featureGate", false); -user_pref("privacy.trackingprotection.introURL", "http://{server}/trackingprotection/tour"); // Disable all recommended Remote Protocol preferences for Gecko tests. // The prefs recommended by Remote Protocol are typically geared towards // consumer automation; not vendor testing. @@ -186,7 +160,6 @@ user_pref("security.default_personal_cert", "Select Automatically"); // Need to user_pref("security.notification_enable_delay", 0); // Ensure blocklist updates don't hit the network user_pref("services.settings.server", "data:,#remote-settings-dummy/v1"); -user_pref("shell.checkDefaultClient", false); // Disable password capture, so that mochitests that include forms aren't // influenced by the presence of the persistent doorhanger notification. user_pref("signon.rememberSignons", false); diff --git a/testing/profiles/web-platform/user.js b/testing/profiles/web-platform/user.js @@ -64,10 +64,6 @@ user_pref("widget.gtk.theme-scrollbar-colors.enabled", false); // (only Android right now), might get a snapshot at different times during the // animation. user_pref("ui.scrollbarFadeDuration", 0); -// Don't enable paint suppression when the background is unknown. While paint -// is suppressed, synthetic click events and co. go to the old page, which can -// be confusing for tests that send click events before the first paint. -user_pref("nglayout.initialpaint.unsuppress_with_no_background", true); user_pref("media.block-autoplay-until-in-foreground", false); // Force a light color scheme unless explicitly overridden by pref. user_pref("layout.css.prefers-color-scheme.content-override", 1); diff --git a/testing/profiles/xpcshell/user.js b/testing/profiles/xpcshell/user.js @@ -14,7 +14,6 @@ user_pref("extensions.webextensions.warnings-as-errors", true); // so we bypass the OSX dialog raised by the corelocation provider user_pref("geo.provider.testing", true); user_pref("browser.region.network.url", ""); -user_pref("geo.provider.network.compare.url", ""); user_pref("media.gmp-manager.updateEnabled", false); user_pref("media.gmp-manager.url.override", "http://%(server)s/dummy-gmp-manager.xml"); user_pref("toolkit.telemetry.server", "https://%(server)s/telemetry-dummy");