commit 6d0ed8ea2d1c20cd1948a734542aa82a364d3036
parent 3aacd81882f261d8b888546455efc811da576b7a
Author: Dan Baker <dbaker@mozilla.com>
Date: Fri, 24 Oct 2025 14:02:59 -0600
Bug 1995393 - Vendor libwebrtc from c57720cdc6
Upstream commit: https://webrtc.googlesource.com/src/+/c57720cdc624ff78824a16f6efa2aff60f50d60e
sdp munging: test that we do not misdetect rtp attributes on datachannel
rtcp-mux and rtcp-rsize are unconditionally set for datachannel
but since they are not serialized in the SDP they are not parsed.
This leads the munging detector to misclassify this.
This adds a unit test showing datachannels are not considered munging.
Bug: webrtc:414284082
Change-Id: Iaa034d0acb1eb4853e1cf2230139b06bc3cc0866
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/404741
Commit-Queue: Philipp Hancke <phancke@meta.com>
Reviewed-by: Evan Shrubsole <eshr@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#45402}
Diffstat:
2 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/third_party/libwebrtc/README.mozilla.last-vendor b/third_party/libwebrtc/README.mozilla.last-vendor
@@ -1,4 +1,4 @@
# ./mach python dom/media/webrtc/third_party_build/vendor-libwebrtc.py --from-local /Users/danielbaker/elm/.moz-fast-forward/moz-libwebrtc --commit mozpatches libwebrtc
-libwebrtc updated from /Users/danielbaker/elm/.moz-fast-forward/moz-libwebrtc commit mozpatches on 2025-10-24T20:00:15.478822+00:00.
+libwebrtc updated from /Users/danielbaker/elm/.moz-fast-forward/moz-libwebrtc commit mozpatches on 2025-10-24T20:02:46.407172+00:00.
# base of lastest vendoring
-962a3d52c2
+c57720cdc6
diff --git a/third_party/libwebrtc/pc/sdp_munging_detector_unittest.cc b/third_party/libwebrtc/pc/sdp_munging_detector_unittest.cc
@@ -1443,4 +1443,15 @@ TEST_F(SdpMungingTest, NumberOfCandidates) {
ElementsAre(Pair(SdpMungingType::kIceCandidateCount, 1)));
}
+#ifdef WEBRTC_HAVE_SCTP
+TEST_F(SdpMungingTest, NoMungingForDataChannels) {
+ auto pc = CreatePeerConnection();
+ pc->CreateDataChannel("somelabel");
+ EXPECT_TRUE(pc->CreateOfferAndSetAsLocal());
+ EXPECT_THAT(
+ metrics::Samples("WebRTC.PeerConnection.SdpMunging.Offer.Initial"),
+ ElementsAre(Pair(SdpMungingType::kNoModification, 1)));
+}
+#endif // WEBRTC_HAVE_SCTP
+
} // namespace webrtc
