commit 6a98e783e1394d59748e1bb3108de0e69f865352
parent 01c5113076bd28cb500ab8c2fd1ccf31065073be
Author: Emilio Cobos Álvarez <emilio@crisal.io>
Date: Fri, 7 Nov 2025 14:46:43 +0000
Bug 1998799 - Remove pesimizing move in Trampoline::ReadPointer. r=win-reviewers,gstoll
This already warns with clangd but somehow turns into a -Werror when
switching to C++20.
Differential Revision: https://phabricator.services.mozilla.com/D271676
Diffstat:
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/toolkit/xre/dllservices/mozglue/interceptor/Trampoline.h b/toolkit/xre/dllservices/mozglue/interceptor/Trampoline.h
@@ -310,7 +310,7 @@ class MOZ_STACK_CLASS Trampoline final {
auto result = Some(*reinterpret_cast<uintptr_t*>(mLocalBase + mOffset));
mOffset += sizeof(uintptr_t);
- return std::move(result);
+ return result;
}
Maybe<uintptr_t> ReadEncodedPointer() {