tor-browser

commit 695f00f3b71c195e08c8b7e0f240db280efbb1f4
parent 56e6646cb72b960ce30c7b2f6ae77ee884d44ce0
Author: Chris DuPuis <cdupuis@mozilla.com>
Date:   Wed, 26 Nov 2025 16:43:06 +0000

Bug 2001395 - Set Fx Backup prefs to enabled for Windows by default r=hsohaney,nrishel,hjones

Instead of defaulting the availability of Fx Backup to false, we
default it to true on Windows. There is still a Nimbus setting
in place that controls whether or not Fx Backup is actually
shown to the user.

Differential Revision: https://phabricator.services.mozilla.com/D273927

Diffstat:
M
browser/app/profile/firefox.js
 | 
4
++--
M
browser/components/backup/BackupService.sys.mjs
 | 
11
++++-------
M
browser/components/preferences/tests/browser.toml
 | 
2
++

3 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/browser/app/profile/firefox.js b/browser/app/profile/firefox.js
@@ -3442,8 +3442,8 @@ pref("browser.backup.scheduled.enabled", false);
 
 // Prefs to control visibility and usability of the create backup and restore from backup features.
 #ifdef XP_WIN
-  pref("browser.backup.archive.enabled", false);
-  pref("browser.backup.restore.enabled", false);
+  pref("browser.backup.archive.enabled", true);
+  pref("browser.backup.restore.enabled", true);
 #else
   pref("browser.backup.archive.enabled", false);
   pref("browser.backup.restore.enabled", false);
diff --git a/browser/components/backup/BackupService.sys.mjs b/browser/components/backup/BackupService.sys.mjs
@@ -719,13 +719,10 @@ export class BackupService extends EventTarget {
       BACKUP_RESTORE_ENABLED_OVERRIDE_PREF_NAME,
       false
     );
-    // This is explicitly checking for restoreKillswitchTriggered !== false because
-    // we now also (potentially) want to use this nimbus setting for doing staged rollout
-    // of the feature. What this means is that if the value is:
-    //     - true: feature is turned off ("killed")
-    //     - undefined: feature is turned off (not launched yet)
-    //     - false: feature is turned on
-    if (restoreKillswitchTriggered !== false && !restoreOverrideEnabled) {
+
+    // restoreKillswitch is a "normal" killswitch, in contrast
+    // to archiveKillswitch
+    if (restoreKillswitchTriggered && !restoreOverrideEnabled) {
       return {
         enabled: false,
         reason: "Restore from backup disabled remotely.",
diff --git a/browser/components/preferences/tests/browser.toml b/browser/components/preferences/tests/browser.toml
@@ -2,6 +2,8 @@
 prefs = [
   "extensions.formautofill.addresses.available='on'",
   "signon.management.page.os-auth.enabled=true",
+  "browser.backup.archive.enabled=false",
+  "browser.backup.restore.enabled=false",
   "browser.backup.archive.overridePlatformCheck=true",
   "browser.backup.restore.overridePlatformCheck=true",
 ]