tor-browser

commit 673deb90455c4227f6f08eb51f4dcc42850b1a6b
parent 3ab702580d7cbfe739740a1bd95c9f0f1bf9ac1a
Author: smayya <smayya@mozilla.com>
Date:   Mon,  6 Oct 2025 11:50:48 +0000

Bug 1989182 - remove fetch keepalive metrics. r=necko-reviewers,valentin

Differential Revision: https://phabricator.services.mozilla.com/D267319

Diffstat:
M
dom/fetch/Fetch.cpp
 | 
9
---------
M
dom/fetch/FetchService.cpp
 | 
11
-----------
M
netwerk/metrics.yaml
 | 
31
-------------------------------

3 files changed, 0 insertions(+), 51 deletions(-)
diff --git a/dom/fetch/Fetch.cpp b/dom/fetch/Fetch.cpp
@@ -39,7 +39,6 @@
 #include "mozilla/dom/WorkerRef.h"
 #include "mozilla/dom/WorkerRunnable.h"
 #include "mozilla/dom/WorkerScope.h"
-#include "mozilla/glean/NetwerkMetrics.h"
 #include "mozilla/ipc/BackgroundChild.h"
 #include "mozilla/ipc/IPCStreamUtils.h"
 #include "mozilla/ipc/PBackgroundChild.h"
@@ -702,8 +701,6 @@ already_AddRefed<Promise> FetchRequest(nsIGlobalObject* aGlobal,
 
     actor->DoFetchOp(ipcArgs);
 
-    mozilla::glean::networking::fetch_keepalive_request_count.Get("main"_ns)
-        .Add(1);
     return p.forget();
   } else {
     WorkerPrivate* worker = GetCurrentThreadWorkerPrivate();
@@ -792,12 +789,6 @@ already_AddRefed<Promise> FetchRequest(nsIGlobalObject* aGlobal,
 
       actor->DoFetchOp(ipcArgs);
 
-      if (internalRequest->GetKeepalive()) {
-        mozilla::glean::networking::fetch_keepalive_request_count
-            .Get("worker"_ns)
-            .Add(1);
-      }
-
       return p.forget();
     }
     // Dispatch worker fetch to the main thread
diff --git a/dom/fetch/FetchService.cpp b/dom/fetch/FetchService.cpp
@@ -17,7 +17,6 @@
 #include "mozilla/dom/PerformanceStorage.h"
 #include "mozilla/dom/PerformanceTiming.h"
 #include "mozilla/dom/ServiceWorkerDescriptor.h"
-#include "mozilla/glean/NetwerkMetrics.h"
 #include "mozilla/ipc/BackgroundUtils.h"
 #include "mozilla/net/CookieJarSettings.h"
 #include "nsContentUtils.h"
@@ -790,21 +789,11 @@ bool FetchService::DoesExceedsKeepaliveResourceLimits(
     const nsACString& origin) {
   if (mTotalKeepAliveRequests >=
       StaticPrefs::dom_fetchKeepalive_total_request_limit()) {
-    // Count keep-alive request discards due to
-    // exceeding the total keep-alive request limit.
-    mozilla::glean::networking::fetch_keepalive_discard_count
-        .Get("total_keepalive_limit"_ns)
-        .Add(1);
     return true;
   }
 
   if (mPendingKeepAliveRequestsPerOrigin.Get(origin) >=
       StaticPrefs::dom_fetchKeepalive_request_limit_per_origin()) {
-    // Count keep-alive request discards due to
-    // exceeding the per-origin request limit.
-    mozilla::glean::networking::fetch_keepalive_discard_count
-        .Get("per_origin_limit"_ns)
-        .Add(1);
     return true;
   }
 
diff --git a/netwerk/metrics.yaml b/netwerk/metrics.yaml
@@ -681,37 +681,6 @@ networking:
       - https_regular
       - https_private
 
-  fetch_keepalive_discard_count:
-    type: labeled_counter
-    description: >
-      Counts how many fetch keepalive requests are dropped due to configured
-      resource limits.
-    bugs:
-      - https://bugzilla.mozilla.org/show_bug.cgi?id=1873551
-    data_reviews:
-      - https://bugzilla.mozilla.org/show_bug.cgi?id=1873551
-    notification_emails:
-      - smayya@mozilla.com
-    expires: 146
-    labels:
-      - total_keepalive_limit
-      - per_origin_limit
-
-  fetch_keepalive_request_count:
-    type: labeled_counter
-    description: >
-      Counts how many fetch keepalive requests are made. This counter helps us to
-      understand the adoption of fetch keepalive for firefox.
-    bugs:
-      - https://bugzilla.mozilla.org/show_bug.cgi?id=1873551
-    data_reviews:
-      - https://bugzilla.mozilla.org/show_bug.cgi?id=1873551
-    notification_emails:
-      - smayya@mozilla.com
-    expires: 146
-    labels:
-      - worker
-      - main
 
   http_content_onstart_delay:
     type: timing_distribution