tor-browser

commit 66002eb2b53d9c87570d31a82bbd8ffbafa1801e
parent fe9ac5ad8103063fa0c2cb7cd64c3cd64ce2130a
Author: Gabriel Luong <gabriel.luong@gmail.com>
Date:   Wed,  1 Oct 2025 06:30:14 +0000

Bug 1990250 - Part 3: Update the homepage tab title to use "{app name} homepage" r=android-reviewers,android-l10n-reviewers,jonalmeida,flod

Context: https://bugzilla.mozilla.org/show_bug.cgi?id=1990250#c3

Differential Revision: https://phabricator.services.mozilla.com/D266248

Diffstat:
M
mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/Core.kt
 | 
5
++++-
M
mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/UseCases.kt
 | 
5
++++-
M
mobile/android/fenix/app/src/main/res/values/strings.xml
 | 
4
+++-
M
mobile/android/fenix/app/src/test/java/org/mozilla/fenix/components/usecases/FenixBrowserUseCasesTest.kt
 | 
11
++++++++---

4 files changed, 19 insertions(+), 6 deletions(-)
diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/Core.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/Core.kt
@@ -356,7 +356,10 @@ class Core(
                     repository = DefaultHomepageAsANewTabPreferenceRepository(context.settings()),
                 ),
                 AboutHomeMiddleware(
-                    homepageTitle = context.getString(R.string.tab_tray_homepage_tab),
+                    homepageTitle = context.getString(
+                        R.string.tab_tray_homepage_tab_2,
+                        context.getString(R.string.app_name),
+                    ),
                 ),
                 BrowserVisualCompletenessMiddleware(visualCompletenessQueue),
             )
diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/UseCases.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/UseCases.kt
@@ -135,7 +135,10 @@ class UseCases(
             addNewTabUseCase = tabsUseCases.addTab,
             loadUrlUseCase = sessionUseCases.loadUrl,
             searchUseCases = searchUseCases,
-            homepageTitle = context.getString(R.string.tab_tray_homepage_tab),
+            homepageTitle = context.getString(
+                R.string.tab_tray_homepage_tab_2,
+                context.getString(R.string.app_name),
+            ),
             profiler = engine.value.profiler,
         )
     }
diff --git a/mobile/android/fenix/app/src/main/res/values/strings.xml b/mobile/android/fenix/app/src/main/res/values/strings.xml
@@ -1341,7 +1341,9 @@
     <!-- Content description for tabs tray multiselect menu -->
     <string name="tab_tray_multiselect_menu_content_description">Selected tabs menu</string>
     <!-- Title text displayed for a homepage tab in the tabs tray. -->
-    <string name="tab_tray_homepage_tab">Homepage</string>
+    <string name="tab_tray_homepage_tab" tools:ignore="UnusedResources" moz:removedIn="145">Homepage</string>
+    <!-- Title text displayed for a homepage tab in the tabs tray. %s is a placeholder that will be replaced by app name. -->
+    <string name="tab_tray_homepage_tab_2">%s homepage</string>
     <!-- Content description (not visible, for screen readers etc.): Removes tab from collection button. Removes the selected tab from collection when pressed -->
     <string name="remove_tab_from_collection">Remove tab from collection</string>
     <!-- Text for button to enter multiselect mode in tabs tray -->
diff --git a/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/components/usecases/FenixBrowserUseCasesTest.kt b/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/components/usecases/FenixBrowserUseCasesTest.kt
@@ -40,6 +40,7 @@ class FenixBrowserUseCasesTest {
     private lateinit var searchUseCases: SearchUseCases
     private lateinit var defaultSearchUseCase: SearchUseCases.DefaultSearchUseCase
     private lateinit var useCases: FenixBrowserUseCases
+    private lateinit var homepageTitle: String
 
     @Before
     fun setup() {
@@ -78,11 +79,15 @@ class FenixBrowserUseCasesTest {
 
         every { searchUseCases.defaultSearch } returns defaultSearchUseCase
 
+        homepageTitle = testContext.getString(
+            R.string.tab_tray_homepage_tab_2,
+            testContext.getString(R.string.app_name),
+        )
         useCases = FenixBrowserUseCases(
             addNewTabUseCase = addNewTabUseCase,
             loadUrlUseCase = loadUrlUseCase,
             searchUseCases = searchUseCases,
-            homepageTitle = testContext.getString(R.string.tab_tray_homepage_tab),
+            homepageTitle = homepageTitle,
             profiler = profiler,
         )
     }
@@ -315,7 +320,7 @@ class FenixBrowserUseCasesTest {
         verify {
             addNewTabUseCase.invoke(
                 url = ABOUT_HOME_URL,
-                title = testContext.getString(R.string.tab_tray_homepage_tab),
+                title = homepageTitle,
                 private = true,
             )
         }
@@ -325,7 +330,7 @@ class FenixBrowserUseCasesTest {
         verify {
             addNewTabUseCase.invoke(
                 url = ABOUT_HOME_URL,
-                title = testContext.getString(R.string.tab_tray_homepage_tab),
+                title = homepageTitle,
                 private = false,
             )
         }