tor-browser

commit 64b002161e1dc7e36e55d9f101970d07083aea3c
parent ac633508f290baac3ffb2371eebb1ef40c02ab2f
Author: mcarare <48995920+mcarare@users.noreply.github.com>
Date:   Mon, 27 Oct 2025 14:55:38 +0000

Bug 1996546 - Remove mockkStatic usage from AboutPageAdapterTest. r=android-reviewers,anpopa

This simplifies the test by removing complex mocking setup and making the test more realistic.

Differential Revision: https://phabricator.services.mozilla.com/D270171

Diffstat:
M
mobile/android/fenix/app/src/test/java/org/mozilla/fenix/settings/about/AboutPageAdapterTest.kt
 | 
28
+++++++---------------------

1 file changed, 7 insertions(+), 21 deletions(-)
diff --git a/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/settings/about/AboutPageAdapterTest.kt b/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/settings/about/AboutPageAdapterTest.kt
@@ -4,19 +4,17 @@
 
 package org.mozilla.fenix.settings.about
 
+import android.view.LayoutInflater
 import android.view.ViewGroup
-import io.mockk.Runs
+import android.widget.FrameLayout
 import io.mockk.every
-import io.mockk.just
 import io.mockk.mockk
-import io.mockk.mockkStatic
 import io.mockk.spyk
 import io.mockk.verify
 import mozilla.components.support.test.robolectric.testContext
 import org.junit.Assert.assertEquals
 import org.junit.Test
 import org.junit.runner.RunWith
-import org.mozilla.fenix.databinding.AboutListItemBinding
 import org.mozilla.fenix.settings.about.viewholders.AboutItemViewHolder
 import org.robolectric.RobolectricTestRunner
 
@@ -66,28 +64,16 @@ class AboutPageAdapterTest {
     @Test
     fun `the adapter binds the right item to a ViewHolder`() {
         val adapter = AboutPageAdapter(listener)
-        val parentView: ViewGroup = mockk(relaxed = true)
-
-        mockkStatic(AboutListItemBinding::class)
-        val binding: AboutListItemBinding = mockk()
-
-        every { AboutListItemBinding.bind(parentView) } returns binding
-        every { binding.root } returns mockk()
-
-        val viewHolder = spyk(AboutItemViewHolder(parentView, mockk()))
+        val parentView = FrameLayout(testContext)
 
-        every {
-            adapter.onCreateViewHolder(
-                parentView,
-                AboutItemViewHolder.LAYOUT_ID,
-            )
-        } returns viewHolder
+        val view = LayoutInflater.from(parentView.context)
+            .inflate(AboutItemViewHolder.LAYOUT_ID, parentView, false)
 
-        every { viewHolder.bind(any()) } just Runs
+        val viewHolder = spyk(AboutItemViewHolder(view, listener))
 
         adapter.submitList(aboutList)
         adapter.bindViewHolder(viewHolder, 1)
 
-        verify { viewHolder.bind(aboutList[1]) }
+        verify(exactly = 1) { viewHolder.bind(aboutList[1]) }
     }
 }