commit 6337bf11f162254834f09801f5b8bb4dec35162f
parent c94cbb5443af57f47e3500f31368ae9be0c9517a
Author: Sam Sneddon <gsnedders@apple.com>
Date: Mon, 10 Nov 2025 22:20:21 +0000
Bug 1998599 [wpt PR 55898] - wpt.browser.Browser is meant to be abstract, a=testonly
Automatic update from web-platform-tests
wpt.browser.Browser is meant to be abstract
The Python 2 syntax has stopped doing anything a long time ago, so
update it, and fix the test to also exempt ChromeChromiumBase from its
list of abstract subclasses.
--
wpt-commits: 60ee5f48618f5bd106f388c12c111ecb235ed5f6
wpt-pr: 55898
Diffstat:
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/testing/web-platform/tests/tools/wpt/browser.py b/testing/web-platform/tests/tools/wpt/browser.py
@@ -89,9 +89,7 @@ def get_file_github(repo: str, ref: str, path: str) -> bytes:
return data
-class Browser:
- __metaclass__ = ABCMeta
-
+class Browser(metaclass=ABCMeta):
def __init__(self, logger):
self.logger = logger
@@ -1584,7 +1582,7 @@ class HeadlessShell(ChromeChromiumBase):
return "N/A"
-class ChromeAndroidBase(Browser):
+class ChromeAndroidBase(Browser, metaclass=ABCMeta):
"""A base class for ChromeAndroid and AndroidWebView.
On Android, WebView is based on Chromium open source project, and on some
@@ -1592,7 +1590,6 @@ class ChromeAndroidBase(Browser):
a very similar WPT runner implementation.
Includes webdriver installation.
"""
- __metaclass__ = ABCMeta # This is an abstract class.
def __init__(self, logger):
super().__init__(logger)
diff --git a/testing/web-platform/tests/tools/wpt/tests/test_browser.py b/testing/web-platform/tests/tools/wpt/tests/test_browser.py
@@ -24,7 +24,7 @@ def test_all_browser_abc():
# products in unit tests.
classes = inspect.getmembers(browser)
for name, cls in classes:
- if cls in (browser.Browser, browser.ChromeAndroidBase):
+ if cls in (browser.Browser, browser.ChromeChromiumBase, browser.ChromeAndroidBase):
continue
if inspect.isclass(cls) and issubclass(cls, browser.Browser):
assert not inspect.isabstract(cls), "%s is abstract" % name
