commit 62079a6218d5d797f66f9cef3ffc685a4af4ea83
parent e71ec995b1bbdc576c553067a2fd937b2d85815b
Author: Timothy Nikkel <tnikkel@gmail.com>
Date: Sat, 15 Nov 2025 10:31:58 +0000
Bug 2000344. Modify helper_hittest_hidden_inactive_scrollframe.html to not care about results that are irrelevant to what it wants to test. r=hiro
This test was added in bug 1673505, which makes sense since that is the code that we modified in bug 1999504 to regress this test.
From the commit message from bug 1999504: The reason that we have the IsVisible check is from bug 1673505 where a visibility: hidden scroll frame that was not active (but could be active) in the root content process was getting all events, and so the events were being sent to the root content process, but the events needed to be sent to an OOP iframe (fission). So it only cares about the second place, so we can move the IsVisible check to the second use of couldBuildLayer without regressing that bug. Furthermore, since that time we've decided that we need to activate all scroll frames for fission to make sure that events are routed to the correct process, so that situation would not even arise anymore.
So the issue that bug 1673505 was aiming to fix was to hit test to the correct element, not the hidden scroll frame. Whether or not the hidden scroll frame has a view id is not important to that. And in fact you can see that we ignore that check when activateAllScrollFrames is true. So having the hidden scroll frame be active is okay, and in fact we also want to get the correct hit test in that situation too. So it is good to run this test and not care about the active state of the hidden scroll frame.
Differential Revision: https://phabricator.services.mozilla.com/D272769
Diffstat:
1 file changed, 0 insertions(+), 11 deletions(-)
diff --git a/gfx/layers/apz/test/mochitest/helper_hittest_hidden_inactive_scrollframe.html b/gfx/layers/apz/test/mochitest/helper_hittest_hidden_inactive_scrollframe.html
@@ -30,17 +30,6 @@ function test() {
var config = getHitTestConfig();
var utils = config.utils;
- let hasViewId;
- try {
- utils.getViewId(document.getElementById("nested"));
- hasViewId = true;
- } catch (e) {
- hasViewId = false;
- }
- if (!config.activateAllScrollFrames) {
- ok(!hasViewId, "The nested scroller should be inactive and not have a view id");
- }
-
checkHitResult(
hitTest(centerOf(document.body)),
APZHitResultFlags.VISIBLE,
