commit 5f26a17f96a7adec6c43a7f734ca7e9afefdefab
parent 451aeb7f02dcd93fdfc526b639a41e63db46c641
Author: agoloman <agoloman@mozilla.com>
Date: Tue, 2 Dec 2025 03:50:51 +0200
Revert "Bug 2002479 - Update chatbot shortcut test due to a11y regression bug. r=yjamora,ai-frontend-reviewers,fluent-reviewers,flod" for causing bc failures @browser_clipboard_paste_chat_shortcuts.js.
This reverts commit 58e15138f3752cb476fe257533ccf99d191cb6e3.
Diffstat:
3 files changed, 3 insertions(+), 11 deletions(-)
diff --git a/browser/components/genai/GenAI.sys.mjs b/browser/components/genai/GenAI.sys.mjs
@@ -614,11 +614,7 @@ export const GenAI = {
const window = browser.ownerGlobal;
const { document, devicePixelRatio } = window;
const aiActionButton = document.getElementById("ai-action-button");
- const chatProvider = this.chatProviders.get(lazy.chatProvider);
this.initializeAIShortcut(aiActionButton);
- document.l10n.setAttributes(aiActionButton, "genai-shortcut-button", {
- provider: chatProvider.name,
- });
switch (name) {
case "GenAI:HideShortcuts":
diff --git a/browser/components/genai/tests/browser/browser_chat_shortcuts.js b/browser/components/genai/tests/browser/browser_chat_shortcuts.js
@@ -137,10 +137,9 @@ add_task(async function test_show_shortcuts() {
);
let beforeClick = Glean.genaiChatbot.shortcutsExpanded.testGetValue();
- shortcuts.click();
+ EventUtils.sendMouseEvent({ type: "click" }, shortcuts);
await BrowserTestUtils.waitForEvent(popup, "popupshown");
Assert.equal(popup.state, "open", "Popup open with click");
-
let afterClick = Glean.genaiChatbot.shortcutsExpanded.testGetValue();
Assert.equal(
afterClick.length,
@@ -214,7 +213,7 @@ add_task(async function test_show_shortcuts_second_tab() {
const stub = sandbox.stub(GenAI, "addAskChatItems");
const shortcuts = document.querySelector("#ai-action-button");
- shortcuts.click();
+ EventUtils.sendMouseEvent({ type: "click" }, shortcuts);
Assert.equal(stub.callCount, 1, "Shortcuts added on select");
Assert.equal(stub.firstCall.args[0], browser, "Got correct browser");
@@ -272,7 +271,7 @@ add_task(async function test_show_warning_label() {
);
// Click button
- aiActionButton.click();
+ EventUtils.sendMouseEvent({ type: "click" }, aiActionButton);
const chatShortcutsOptionsPanel = document.getElementById(
"chat-shortcuts-options-panel"
diff --git a/browser/locales/en-US/browser/genai.ftl b/browser/locales/en-US/browser/genai.ftl
@@ -70,9 +70,6 @@ genai-menu-remove-provider =
.label = Remove { $provider }
genai-menu-remove-sidebar =
.label = Remove from Sidebar
-# $provider (string) - name of the AI chat provider
-genai-shortcut-button =
- .aria-label = Ask { $provider }
genai-menu-new-badge = New
genai-menu-summarize-page = Summarize Page