tor-browser

commit 5e73078aa58e83630ee8f6632b16832344d2f07e
parent 7b606f1a66e240f580f580c99e8fccfaa37cb019
Author: clairehurst <clairehurst@torproject.org>
Date:   Wed, 27 Aug 2025 14:29:06 -0600

TB 44098: [android] Disable sync

tor-browser#44098 Bookmarks offer a way to go to sync in 15.0a1

Diffstat:
M
mobile/android/fenix/app/src/main/java/org/mozilla/fenix/bookmarks/BookmarksAction.kt
 | 
1
-
M
mobile/android/fenix/app/src/main/java/org/mozilla/fenix/bookmarks/BookmarksMiddleware.kt
 | 
1
-
M
mobile/android/fenix/app/src/main/java/org/mozilla/fenix/bookmarks/BookmarksReducer.kt
 | 
1
-
M
mobile/android/fenix/app/src/main/java/org/mozilla/fenix/bookmarks/BookmarksScreen.kt
 | 
28
----------------------------
M
mobile/android/fenix/app/src/main/java/org/mozilla/fenix/bookmarks/BookmarksTelemetryMiddleware.kt
 | 
1
-

5 files changed, 0 insertions(+), 32 deletions(-)
diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/bookmarks/BookmarksAction.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/bookmarks/BookmarksAction.kt
@@ -83,7 +83,6 @@ internal data object SearchDismissed : BookmarksAction
 internal data object AddFolderClicked : BookmarksAction
 internal data object CloseClicked : BookmarksAction
 internal data object BackClicked : BookmarksAction
-internal data object SignIntoSyncClicked : BookmarksAction
 internal data class EditBookmarkClicked(val bookmark: BookmarkItem.Bookmark) : BookmarksAction
 internal data class ReceivedSyncSignInUpdate(val isSignedIn: Boolean) : BookmarksAction
 internal data object FirstSyncCompleted : BookmarksAction
diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/bookmarks/BookmarksMiddleware.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/bookmarks/BookmarksMiddleware.kt
@@ -152,7 +152,6 @@ internal class BookmarksMiddleware(
             }
             AddFolderClicked -> getNavController().navigate(BookmarksDestinations.ADD_FOLDER)
             CloseClicked -> exitBookmarks()
-            SignIntoSyncClicked -> navigateToSignIntoSync()
             is EditBookmarkClicked -> getNavController().navigate(BookmarksDestinations.EDIT_BOOKMARK)
             BackClicked -> {
                 when {
diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/bookmarks/BookmarksReducer.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/bookmarks/BookmarksReducer.kt
@@ -69,7 +69,6 @@ internal fun bookmarksReducer(state: BookmarksState, action: BookmarksAction) = 
     FirstSyncCompleted,
     ViewDisposed,
     SelectFolderAction.ViewAppeared,
-    SignIntoSyncClicked,
     is InitEdit,
     Init,
     PrivateBrowsingAuthorized,
diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/bookmarks/BookmarksScreen.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/bookmarks/BookmarksScreen.kt
@@ -1324,39 +1324,11 @@ private fun EmptyList(
             modifier = Modifier.width(FirefoxTheme.layout.size.containerMaxWidth),
             horizontalAlignment = Alignment.CenterHorizontally,
         ) {
-            Image(
-                painter = painterResource(state.drawableId()),
-                contentDescription = null,
-            )
-
-            Spacer(modifier = Modifier.height(FirefoxTheme.layout.space.static200))
-
             Text(
                 text = stringResource(R.string.bookmark_empty_list_title),
                 color = MaterialTheme.colorScheme.onSurface,
                 style = FirefoxTheme.typography.headline6,
             )
-
-            Spacer(modifier = Modifier.height(FirefoxTheme.layout.space.static100))
-
-            Text(
-                text = stringResource(state.descriptionId()),
-                color = MaterialTheme.colorScheme.onSurfaceVariant,
-                style = FirefoxTheme.typography.body2,
-                textAlign = TextAlign.Center,
-            )
-
-            if (state is EmptyListState.NotAuthenticated) {
-                Spacer(modifier = Modifier.height(FirefoxTheme.layout.space.static300))
-
-                FilledButton(
-                    text = stringResource(R.string.bookmark_empty_list_guest_cta),
-                    onClick = { dispatcher(SignIntoSyncClicked) },
-                    modifier = Modifier
-                        .heightIn(36.dp)
-                        .fillMaxWidth(),
-                )
-            }
         }
     }
 }
diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/bookmarks/BookmarksTelemetryMiddleware.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/bookmarks/BookmarksTelemetryMiddleware.kt
@@ -68,7 +68,6 @@ internal class BookmarksTelemetryMiddleware : Middleware<BookmarksState, Bookmar
             is SelectFolderAction.ItemClicked,
             is SelectFolderAction.ChevronClicked,
             AddFolderAction.ParentFolderClicked,
-            SignIntoSyncClicked,
             is AddFolderAction.FolderCreated,
             is AddFolderAction.TitleChanged,
             is EditBookmarkAction.TitleChanged,