tor-browser

commit 5a66918a8b5ea20008d5935c94d379982c437973
parent b4a40386c0836d531a40c3259dd0e0cea4d13ce9
Author: Euclid Ye <yezhizhenjiakang@gmail.com>
Date:   Tue,  6 Jan 2026 21:45:31 +0000

Bug 2008343 [wpt PR 56959] - webdriver: Fix outdated timeouts test and remove redundant check, a=testonly

Automatic update from web-platform-tests
Update outdated WPT

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>

--
Use cartesian product to test combinations

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>

--
Update invalid timeout tests

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>

--
Use the closest invalid value

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>

--
Rename + Add `test_invalid_timeouts_type`

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>

--
Update neglected tests

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>

--

wpt-commits: cf6a285022541ffa94b7fecfb2a779db98636302, d7790c16bc222ef401b385a7775077262affc6dc, 591f12cfb6c94e7c7649ac3c46eaa9b454bc1811, da0573d4b88fa14727abbf29d1145cfad5a6c2a4, 54f8087f45a4e40d097fbd1b4c5ef2b782bc6f46, 120ea8c07eba2ff606c4f2594cfc99ec9685ef35
wpt-pr: 56959

Diffstat:
M
testing/web-platform/tests/webdriver/tests/classic/new_session/support/create.py
 | 
1
-
M
testing/web-platform/tests/webdriver/tests/classic/new_session/timeouts.py
 | 
43
+++++++++++++++++++++++++++++--------------

2 files changed, 29 insertions(+), 15 deletions(-)
diff --git a/testing/web-platform/tests/webdriver/tests/classic/new_session/support/create.py b/testing/web-platform/tests/webdriver/tests/classic/new_session/support/create.py
@@ -83,7 +83,6 @@ invalid_data = [
         {"page load": 10},
         {" pageLoad": 10},
         {"pageLoad ": 10},
-        {"pageLoad": None},
         {"pageLoad": False},
         {"pageLoad": []},
         {"pageLoad": "10"},
diff --git a/testing/web-platform/tests/webdriver/tests/classic/new_session/timeouts.py b/testing/web-platform/tests/webdriver/tests/classic/new_session/timeouts.py
@@ -2,6 +2,7 @@ import pytest
 
 from tests.support.asserts import assert_success, assert_error
 
+MAX_SAFE_INTEGER = 2**53 - 1
 
 def test_default_values(session):
     timeouts = session.capabilities["timeouts"]
@@ -11,22 +12,36 @@ def test_default_values(session):
     assert timeouts["script"] == 30000
 
 
-@pytest.mark.parametrize("timeouts", [
-    {"implicit": 444, "pageLoad": 300000,"script": 30000},
-    {"implicit": 0, "pageLoad": 444,"script": 30000},
-    {"implicit": 0, "pageLoad": 300000,"script": 444},
-    {"implicit": 0, "pageLoad": 300000,"script": None},
-])
-def test_timeouts(new_session, add_browser_capabilities, timeouts):
+@pytest.mark.parametrize("value", [None, 0, 3000])
+@pytest.mark.parametrize("key", ["implicit", "pageLoad", "script"])
+def test_timeouts(new_session, add_browser_capabilities, key, value):
+    timeouts = {key: value}
     response, _ = new_session({"capabilities": {"alwaysMatch": add_browser_capabilities({"timeouts": timeouts})}})
     value = assert_success(response)
     assert value["capabilities"]["timeouts"] == timeouts
 
-@pytest.mark.parametrize("timeouts", [
-    {"implicit": None, "pageLoad": 300000,"script": 30000},
-    {"implicit": 0, "pageLoad": None,"script": 30000},
-    {"implicit": None, "pageLoad": None,"script": None}
-])
-def test_invalid_timeouts(new_session, add_browser_capabilities, timeouts):
-    response, _ = new_session({"capabilities": {"alwaysMatch": add_browser_capabilities({"timeouts": timeouts})}})
+@pytest.mark.parametrize("value", [MAX_SAFE_INTEGER + 1, -1])
+@pytest.mark.parametrize("key", ["implicit", "pageLoad", "script"])
+def test_invalid_timeouts_value(new_session, add_browser_capabilities, key, value):
+    timeouts = {key: value}
+
+    response, _ = new_session({
+        "capabilities": {
+            "alwaysMatch": add_browser_capabilities({"timeouts": timeouts})
+        }
+    })
+
+    assert_error(response, "invalid argument")
+
+@pytest.mark.parametrize("value", ["foo", False, [], {}])
+@pytest.mark.parametrize("key", ["implicit", "pageLoad", "script"])
+def test_invalid_timeouts_type(new_session, add_browser_capabilities, key, value):
+    timeouts = {key: value}
+
+    response, _ = new_session({
+        "capabilities": {
+            "alwaysMatch": add_browser_capabilities({"timeouts": timeouts})
+        }
+    })
+
     assert_error(response, "invalid argument")