commit 59202fb317fdbb463d68416fc7a822c0e42995e3
parent bd3adf283792b42b85cd5fe1b0283d8c44f3b455
Author: Tom Schuster <tschuster@mozilla.com>
Date: Fri, 12 Dec 2025 07:56:02 +0000
Bug 2004328 - Don't explicitly use the Firefox icon for notifications. r=saschanaz,home-newtab-reviewers,maxx
Differential Revision: https://phabricator.services.mozilla.com/D275194
Diffstat:
2 files changed, 2 insertions(+), 27 deletions(-)
diff --git a/browser/components/AccountsGlue.sys.mjs b/browser/components/AccountsGlue.sys.mjs
@@ -250,13 +250,7 @@ export const AccountsGlue = {
}
};
- // Specify an icon because on Windows no icon is shown at the moment
- let imageURL;
- if (AppConstants.platform == "win") {
- imageURL = "chrome://branding/content/icon64.png";
- }
let alert = new AlertNotification({
- imageURL,
title,
text: body,
textClickable: true,
@@ -327,11 +321,6 @@ export const AccountsGlue = {
}
};
- let imageURL;
- if (AppConstants.platform == "win") {
- imageURL = "chrome://branding/content/icon64.png";
- }
-
// Reset the count only if there are no pending notifications
if (!lazy.CloseRemoteTab.hasPendingCloseTabNotification) {
lazy.CloseRemoteTab.closeTabNotificationCount = 0;
@@ -347,7 +336,6 @@ export const AccountsGlue = {
try {
let alert = new AlertNotification({
- imageURL,
title,
text: body,
textClickable: true,
@@ -361,10 +349,6 @@ export const AccountsGlue = {
async _onVerifyLoginNotification({ body, title, url }) {
let tab;
- let imageURL;
- if (AppConstants.platform == "win") {
- imageURL = "chrome://branding/content/icon64.png";
- }
let win = lazy.BrowserWindowTracker.getTopWindow({ private: false });
if (!win) {
win = await this._openURLInNewWindow(url);
@@ -383,7 +367,6 @@ export const AccountsGlue = {
try {
let alert = new AlertNotification({
- imageURL,
title,
body,
textClickable: true,
diff --git a/browser/extensions/newtab/lib/Widgets/TimerFeed.sys.mjs b/browser/extensions/newtab/lib/Widgets/TimerFeed.sys.mjs
@@ -63,27 +63,19 @@ export class TimerFeed {
/**
* @backward-compat { version 147 }
- * Remove`alertsService.showAlertNotification` call once Firefox 147
+ * Remove `alertsService.showAlertNotification` call once Firefox 147
* makes it to the release channel.
*/
if (Services.vc.compare(AppConstants.MOZ_APP_VERSION, "147.0a1") >= 0) {
alertsService.showAlert(
new AlertNotification({
- imageURL: "chrome://branding/content/icon64.png",
title,
text: body,
})
);
} else {
- alertsService.showAlertNotification(
- "chrome://branding/content/icon64.png",
- title,
- body,
- false,
- "",
- null
- );
+ alertsService.showAlertNotification(null, title, body, false, "", null);
}
} catch (err) {
console.error("Failed to show system notification", err);