commit 58e15138f3752cb476fe257533ccf99d191cb6e3
parent 6f09aa2f216bae6a7cd5c6600e9636b4cc55e330
Author: Giulia Cardieri <gcardieri@mozilla.com>
Date: Mon, 1 Dec 2025 22:50:54 +0000
Bug 2002479 - Update chatbot shortcut test due to a11y regression bug. r=yjamora,ai-frontend-reviewers,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D274165
Diffstat:
3 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/browser/components/genai/GenAI.sys.mjs b/browser/components/genai/GenAI.sys.mjs
@@ -614,7 +614,11 @@ export const GenAI = {
const window = browser.ownerGlobal;
const { document, devicePixelRatio } = window;
const aiActionButton = document.getElementById("ai-action-button");
+ const chatProvider = this.chatProviders.get(lazy.chatProvider);
this.initializeAIShortcut(aiActionButton);
+ document.l10n.setAttributes(aiActionButton, "genai-shortcut-button", {
+ provider: chatProvider.name,
+ });
switch (name) {
case "GenAI:HideShortcuts":
diff --git a/browser/components/genai/tests/browser/browser_chat_shortcuts.js b/browser/components/genai/tests/browser/browser_chat_shortcuts.js
@@ -137,9 +137,10 @@ add_task(async function test_show_shortcuts() {
);
let beforeClick = Glean.genaiChatbot.shortcutsExpanded.testGetValue();
- EventUtils.sendMouseEvent({ type: "click" }, shortcuts);
+ shortcuts.click();
await BrowserTestUtils.waitForEvent(popup, "popupshown");
Assert.equal(popup.state, "open", "Popup open with click");
+
let afterClick = Glean.genaiChatbot.shortcutsExpanded.testGetValue();
Assert.equal(
afterClick.length,
@@ -213,7 +214,7 @@ add_task(async function test_show_shortcuts_second_tab() {
const stub = sandbox.stub(GenAI, "addAskChatItems");
const shortcuts = document.querySelector("#ai-action-button");
- EventUtils.sendMouseEvent({ type: "click" }, shortcuts);
+ shortcuts.click();
Assert.equal(stub.callCount, 1, "Shortcuts added on select");
Assert.equal(stub.firstCall.args[0], browser, "Got correct browser");
@@ -271,7 +272,7 @@ add_task(async function test_show_warning_label() {
);
// Click button
- EventUtils.sendMouseEvent({ type: "click" }, aiActionButton);
+ aiActionButton.click();
const chatShortcutsOptionsPanel = document.getElementById(
"chat-shortcuts-options-panel"
diff --git a/browser/locales/en-US/browser/genai.ftl b/browser/locales/en-US/browser/genai.ftl
@@ -70,6 +70,9 @@ genai-menu-remove-provider =
.label = Remove { $provider }
genai-menu-remove-sidebar =
.label = Remove from Sidebar
+# $provider (string) - name of the AI chat provider
+genai-shortcut-button =
+ .aria-label = Ask { $provider }
genai-menu-new-badge = New
genai-menu-summarize-page = Summarize Page