tor-browser

commit 5759a1c8dad49b6be7326a1d67308b34cdc7c77c
parent 4af084d81a8cab1d7166419fdab66501b918a71a
Author: Vincent Hilla <vhilla@mozilla.com>
Date:   Thu, 27 Nov 2025 08:06:46 +0000

Bug 1974090 - Decrease flakyness and re-enable browser_tabContextMenu_keyboard.js r=smaug,tabbrowser-reviewers,nsharpley

After bug 543435 (sync-about-blank), the test started failing around 70% of the
time on Linux ASan. With this patch, it passed 11 consecutive runs. The content
load of tab2 is a plausible source of flakiness whose timing was changed by
bug 543435. Let's try re-enabling the test.

Differential Revision: https://phabricator.services.mozilla.com/D273863

Diffstat:
M
browser/components/tabbrowser/test/browser/tabs/browser.toml
 | 
3
---
M
browser/components/tabbrowser/test/browser/tabs/browser_tabContextMenu_keyboard.js
 | 
4
++++

2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/browser/components/tabbrowser/test/browser/tabs/browser.toml b/browser/components/tabbrowser/test/browser/tabs/browser.toml
@@ -500,9 +500,6 @@ skip-if = [
 
 ["browser_tabContextMenu_keyboard.js"]
 tags = "vertical-tabs"
-skip-if = [
-  "os == 'linux' && os_version == '24.04' && arch == 'x86_64'", # Bug 1974090
-]
 
 ["browser_tabDrop.js"]
 https_first_disabled = true
diff --git a/browser/components/tabbrowser/test/browser/tabs/browser_tabContextMenu_keyboard.js b/browser/components/tabbrowser/test/browser/tabs/browser_tabContextMenu_keyboard.js
@@ -33,6 +33,9 @@ add_task(async function test() {
   // There should be one tab when we start the test.
   let tab1 = gBrowser.selectedTab;
   let tab2 = BrowserTestUtils.addTab(gBrowser);
+  await BrowserTestUtils.browserLoaded(tab2.linkedBrowser, {
+    wantLoad: "about:blank",
+  });
   tab1.focus();
   is(document.activeElement, tab1, "tab1 should be focused");
 
@@ -58,6 +61,7 @@ add_task(async function test() {
   await openContextMenu();
   EventUtils.synthesizeKey("KEY_ArrowUp");
   await closeContextMenu();
+  Assert.notEqual(gBrowser.selectedTab, tab1, "tab1 should not be selected");
   is(gBrowser.selectedTab, tab2, "tab2 should still be active");
 
   gBrowser.removeTab(tab2);