tor-browser

commit 57230c5db1dbc06e063df7d5a11b564f039715e1
parent b5188b087a99e59aa8328b367c54419e18f257af
Author: mcarare <48995920+mcarare@users.noreply.github.com>
Date:   Fri, 19 Dec 2025 11:59:29 +0000

Bug 2006903 - Update AppVisualCompletenessMiddlewareTest to use modern coroutine testing APIs. r=android-reviewers,avirvara

Differential Revision: https://phabricator.services.mozilla.com/D277015

Diffstat:
M
mobile/android/fenix/app/src/test/java/org/mozilla/fenix/components/AppVisualCompletenessMiddlewareTest.kt
 | 
15
++++-----------

1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/components/AppVisualCompletenessMiddlewareTest.kt b/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/components/AppVisualCompletenessMiddlewareTest.kt
@@ -1,23 +1,17 @@
 package org.mozilla.fenix.components
 
-import kotlinx.coroutines.ExperimentalCoroutinesApi
-import kotlinx.coroutines.test.advanceUntilIdle
 import kotlinx.coroutines.test.runTest
 import mozilla.components.support.test.mock
-import mozilla.components.support.test.rule.MainCoroutineRule
 import mozilla.components.support.utils.RunWhenReadyQueue
 import org.junit.Assert.assertTrue
-import org.junit.Rule
 import org.junit.Test
 import org.mozilla.fenix.components.appstate.AppAction
 
 class AppVisualCompletenessMiddlewareTest {
-    @get:Rule
-    val coroutineTestRule = MainCoroutineRule()
 
     @Test
-    fun `WHEN first frame of home screen is drawn THEN queue is marked as ready`() {
-        val queue = RunWhenReadyQueue()
+    fun `WHEN first frame of home screen is drawn THEN queue is marked as ready`() = runTest {
+        val queue = RunWhenReadyQueue(this)
         val middleware = AppVisualCompletenessMiddleware(queue)
 
         middleware.invoke(mock(), mock(), AppAction.UpdateFirstFrameDrawn(true))
@@ -25,14 +19,13 @@ class AppVisualCompletenessMiddlewareTest {
         assertTrue(queue.isReady())
     }
 
-    @OptIn(ExperimentalCoroutinesApi::class) // advanceUntilIdle
     @Test
     fun `WHEN home screen is never drawn THEN queue is marked as ready after five seconds`() = runTest {
-        val queue = RunWhenReadyQueue()
+        val queue = RunWhenReadyQueue(this)
         val middleware = AppVisualCompletenessMiddleware(queue, this)
         middleware.invoke(mock(), mock(), AppAction.AppLifecycleAction.ResumeAction)
 
-        this.advanceUntilIdle()
+        testScheduler.advanceUntilIdle()
 
         assertTrue(queue.isReady())
     }