tor-browser

commit 53700a63ae0fd67c1b3676905160a966588e1db2
parent fe1d8d747881630cf53a62a30a013ccdfc854fc2
Author: Erik Nordin <enordin@mozilla.com>
Date:   Thu, 18 Dec 2025 01:17:29 +0000

Bug 2002127 - Part 18: Move moz-selects to header slot r=translations-reviewers,hjones

This commit moves the `moz-select` elements to the
header slot withing the Translations subpage, instead
of the actions slot. The arrow key navigation and tab
index focus was not working in the actions slot.

Differential Revision: https://phabricator.services.mozilla.com/D274830

Diffstat:
M
browser/components/preferences/main.js
 | 
12
+++---------

1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/browser/components/preferences/main.js b/browser/components/preferences/main.js
@@ -3866,6 +3866,7 @@ SettingGroupManager.registerGroups({
                 id: "translationsAlwaysTranslateLanguagesRow",
                 l10nId: "settings-translations-subpage-always-translate-header",
                 control: "moz-box-item",
+                slot: "header",
                 controlAttrs: {
                   style:
                     "--box-label-font-weight: var(--font-weight-semibold);",
@@ -3874,9 +3875,6 @@ SettingGroupManager.registerGroups({
                   {
                     id: "translationsAlwaysTranslateLanguagesSelect",
                     control: "moz-select",
-                    controlAttrs: {
-                      slot: "actions",
-                    },
                     options: [
                       {
                         value: "",
@@ -3918,6 +3916,7 @@ SettingGroupManager.registerGroups({
                 id: "translationsNeverTranslateLanguagesRow",
                 l10nId: "settings-translations-subpage-never-translate-header",
                 control: "moz-box-item",
+                slot: "header",
                 controlAttrs: {
                   style:
                     "--box-label-font-weight: var(--font-weight-semibold);",
@@ -3926,9 +3925,6 @@ SettingGroupManager.registerGroups({
                   {
                     id: "translationsNeverTranslateLanguagesSelect",
                     control: "moz-select",
-                    controlAttrs: {
-                      slot: "actions",
-                    },
                     options: [
                       {
                         value: "",
@@ -4009,6 +4005,7 @@ SettingGroupManager.registerGroups({
                 l10nId:
                   "settings-translations-subpage-download-languages-header",
                 control: "moz-box-item",
+                slot: "header",
                 controlAttrs: {
                   style:
                     "--box-label-font-weight: var(--font-weight-semibold);",
@@ -4017,9 +4014,6 @@ SettingGroupManager.registerGroups({
                   {
                     id: "translationsDownloadLanguagesSelect",
                     control: "moz-select",
-                    controlAttrs: {
-                      slot: "actions",
-                    },
                     options: [
                       {
                         value: "",