tor-browser

commit 4b4b6deb7a1c812b04154f7a765febdb785df18f
parent c378c3bf28a42ce5d5abb7ad20e16acd6394c7cd
Author: Alex Hochheiden <ahochheiden@mozilla.com>
Date:   Tue, 16 Dec 2025 00:36:47 +0000

Bug 2000692 - Drop `WEBIDL_PP_DEPS` variable in favor of inline dependencies in `recursivemake.py` r=firefox-build-system-reviewers,sergesanspaille

It now follows the same pattern as `IPDL` introduced in D276084

Differential Revision: https://phabricator.services.mozilla.com/D276140

Diffstat:
M
dom/bindings/Makefile.in
 | 
9
---------
M
python/mozbuild/mozbuild/backend/recursivemake.py
 | 
13
+++++++++----

2 files changed, 9 insertions(+), 13 deletions(-)
diff --git a/dom/bindings/Makefile.in b/dom/bindings/Makefile.in
@@ -6,15 +6,6 @@ webidl_base := $(topsrcdir)/dom/webidl
 
 ifdef COMPILE_ENVIRONMENT
 
-# Akin to GLOBAL_DEPS, but set early enough that webidlsrcs.mk
-# can make use of them as dependencies.
-WEBIDL_PP_DEPS := \
-    backend.mk \
-    Makefile \
-    $(DEPTH)/config/autoconf.mk \
-    $(topsrcdir)/config/config.mk \
-    $(NULL)
-
 # Generated by moz.build
 include webidlsrcs.mk
 
diff --git a/python/mozbuild/mozbuild/backend/recursivemake.py b/python/mozbuild/mozbuild/backend/recursivemake.py
@@ -1943,10 +1943,15 @@ class RecursiveMakeBackend(MakeBackend):
         for source in sorted(webidls.all_preprocessed_sources()):
             basename = os.path.basename(source)
             rule = mk.create_rule([basename])
-            # GLOBAL_DEPS would be used here, but due to the include order of
-            # our makefiles it's not set early enough to be useful, so we use
-            # WEBIDL_PP_DEPS, which has analagous content.
-            rule.add_dependencies([source, "$(WEBIDL_PP_DEPS)"])
+            rule.add_dependencies(
+                [
+                    source,
+                    "backend.mk",
+                    "Makefile",
+                    "$(DEPTH)/config/autoconf.mk",
+                    "$(topsrcdir)/config/config.mk",
+                ]
+            )
             rule.add_commands(
                 [
                     # Remove the file before writing so bindings that go from