tor-browser

commit 4a59ae976d69bbfc6defda7cd97e7218688f76ad
parent 53cbc2be27f4f5158fb37e687d0f4fdbb453292d
Author: Emilio Cobos Álvarez <emilio@crisal.io>
Date:   Fri, 21 Nov 2025 20:23:57 +0000

Bug 2001589 - Remove is_pod usage from gfxVR.h. r=gfx-reviewers,lsalzman

It warns because std::is_pod is deprecated. We care about trivialness
because we initialize this type with memset().

Differential Revision: https://phabricator.services.mozilla.com/D273555

Diffstat:
M
gfx/vr/external_api/moz_external_vr.h
 | 
32
+++++++++++++++-----------------
M
gfx/vr/gfxVR.h
 | 
4
++--

2 files changed, 17 insertions(+), 19 deletions(-)
diff --git a/gfx/vr/external_api/moz_external_vr.h b/gfx/vr/external_api/moz_external_vr.h
@@ -476,18 +476,18 @@ struct VRDisplayState {
   VRDisplayBlendMode blendMode;
   std::array<uint8_t, 5> _padding2;
   std::array<VRFieldOfView, VRDisplayState::NumEyes> eyeFOV;
-  static_assert(std::is_pod<VRFieldOfView>::value);
+  static_assert(std::is_trivial_v<VRFieldOfView>);
   std::array<Point3D_POD, VRDisplayState::NumEyes> eyeTranslation;
-  static_assert(std::is_pod<Point3D_POD>::value);
+  static_assert(std::is_trivial_v<Point3D_POD>);
   IntSize_POD eyeResolution;
-  static_assert(std::is_pod<IntSize_POD>::value);
+  static_assert(std::is_trivial_v<IntSize_POD>);
   float nativeFramebufferScaleFactor;
   bool suppressFrames;
   bool isConnected;
   bool isMounted;
   uint8_t _padding3;
   FloatSize_POD stageSize;
-  static_assert(std::is_pod<FloatSize_POD>::value);
+  static_assert(std::is_trivial_v<FloatSize_POD>);
   // We can't use a Matrix4x4 here unless we ensure it's a POD type
   std::array<float, 16> sittingToStandingTransform;
   uint64_t lastSubmittedFrameId;
@@ -518,7 +518,7 @@ struct VRDisplayState {
   void Clear() { memset(this, 0, sizeof(VRDisplayState)); }
 #endif
 };
-static_assert(std::is_pod<VRDisplayState>::value);
+static_assert(std::is_trivial_v<VRDisplayState>);
 
 struct VRControllerState {
   std::array<char, kVRControllerNameMaxLen> controllerName;
@@ -709,11 +709,10 @@ struct VRSystemState {
   VRHMDSensorState sensorState;
   std::array<VRControllerState, kVRControllerMaxCount> controllerState;
 };
-static_assert(std::is_pod<VRDisplayState>::value);
-static_assert(std::is_pod<VRHMDSensorState>::value);
-static_assert(std::is_pod<VRControllerState>::value);
-
-static_assert(std::is_pod<VRSystemState>::value);
+static_assert(std::is_trivial_v<VRDisplayState>);
+static_assert(std::is_trivial_v<VRHMDSensorState>);
+static_assert(std::is_trivial_v<VRControllerState>);
+static_assert(std::is_trivial_v<VRSystemState>);
 
 enum class VRFxEventType : uint8_t {
   NONE = 0,
@@ -842,13 +841,12 @@ struct VRExternalShmem {
 
 // As we are memcpy'ing VRExternalShmem and its members around, it must be a POD
 // type
-static_assert(std::is_pod<VRSystemState>::value);
-static_assert(std::is_pod<VRBrowserState>::value);
-static_assert(std::is_pod<VRWindowState>::value);
-static_assert(std::is_pod<VRTelemetryState>::value);
-
-static_assert(std::is_pod<VRExternalShmem>::value,
-              "VRExternalShmem must be a POD type.");
+static_assert(std::is_trivial_v<VRSystemState>);
+static_assert(std::is_trivial_v<VRBrowserState>);
+static_assert(std::is_trivial_v<VRWindowState>);
+static_assert(std::is_trivial_v<VRTelemetryState>);
+static_assert(std::is_trivial_v<VRExternalShmem>,
+              "VRExternalShmem must be a trivial type.");
 
 }  // namespace gfx
 }  // namespace mozilla
diff --git a/gfx/vr/gfxVR.h b/gfx/vr/gfxVR.h
@@ -95,8 +95,8 @@ struct VRDisplayInfo {
   }
 };
 
-static_assert(std::is_pod<VRDisplayInfo>::value,
-              "VRDisplayInfo must be a POD type.");
+static_assert(std::is_trivial_v<VRDisplayInfo>,
+              "VRDisplayInfo must be a trivial type.");
 
 struct VRSubmitFrameResultInfo {
   VRSubmitFrameResultInfo()