commit 48b521fe0abe7919b3379a387dc95da409518580 parent 53e70b0166c5563c6fbf15b0208b3bfee9f0aff5 Author: iorgamgabriel <iorgamgabriel@yahoo.com> Date: Thu, 16 Oct 2025 14:36:09 +0000 Bug 1993168 - Checkboxes in the "Delete browsing data" screens should have good contrast. r=android-reviewers,tthibaud Differential Revision: https://phabricator.services.mozilla.com/D268113 Diffstat:
4 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/mobile/android/fenix/app/src/main/res/color/checkbox_tint.xml b/mobile/android/fenix/app/src/main/res/color/checkbox_tint.xml @@ -0,0 +1,8 @@ +<?xml version="1.0" encoding="utf-8"?><!-- This Source Code Form is subject to the terms of the Mozilla Public + - License, v. 2.0. If a copy of the MPL was not distributed with this + - file, You can obtain one at http://mozilla.org/MPL/2.0/. --> +<selector xmlns:android="http://schemas.android.com/apk/res/android"> + <item android:color="?attr/textSecondary" android:state_checked="false" android:state_enabled="true" /> + <item android:color="?accent" android:state_checked="true" android:state_enabled="true" /> + <item android:color="?attr/textDisabled" android:state_enabled="false" /> +</selector> diff --git a/mobile/android/fenix/app/src/main/res/color/tab_checkbox_tint.xml b/mobile/android/fenix/app/src/main/res/color/tab_checkbox_tint.xml @@ -1,7 +0,0 @@ -<?xml version="1.0" encoding="utf-8"?><!-- This Source Code Form is subject to the terms of the Mozilla Public - - License, v. 2.0. If a copy of the MPL was not distributed with this - - file, You can obtain one at http://mozilla.org/MPL/2.0/. --> -<selector xmlns:android="http://schemas.android.com/apk/res/android"> - <item android:color="?attr/textSecondary" android:state_checked="false" /> - <item android:color="?accent" android:state_checked="true" /> -</selector> diff --git a/mobile/android/fenix/app/src/main/res/layout/collection_tab_list_row.xml b/mobile/android/fenix/app/src/main/res/layout/collection_tab_list_row.xml @@ -74,7 +74,6 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_margin="8dp" - android:buttonTint="@color/tab_checkbox_tint" android:clickable="false" android:elevation="1dp" app:layout_constraintBottom_toBottomOf="parent" diff --git a/mobile/android/fenix/app/src/main/res/values/styles.xml b/mobile/android/fenix/app/src/main/res/values/styles.xml @@ -311,6 +311,7 @@ <item name="searchViewStyle">@style/SearchViewStyle</item> <item name="android:textColorLink">@color/fx_mobile_private_text_color_accent</item> <item name="preferenceTheme">@style/PreferenceTheme</item> + <item name="checkboxStyle">@style/App.Widget.CompoundButton.CheckBox</item> <item name="autoCompleteTextViewStyle">@style/AutoCompleteTextViewStyle</item> <item name="android:textAlignment">viewStart</item> <item name="android:datePickerDialogTheme">@style/PrivateDatePickerDialogStyle</item> @@ -488,6 +489,10 @@ <item name="tabCounterTintColor">?attr/textPrimary</item> </style> + <style name="App.Widget.CompoundButton.CheckBox" parent="Widget.Material3.CompoundButton.CheckBox"> + <item name="buttonTint">@color/checkbox_tint</item> + </style> + <style name="Mozac.Browser.Menu" parent="" tools:ignore="UnusedResources"> <item name="cardBackgroundColor">?attr/layer2</item> </style>