commit 4852c962c4a137755524851aad30c772acd025bd
parent d7d1a672f573a9a484c429fda9b2ab7a2e00faf5
Author: Mike Conley <mconley@mozilla.com>
Date: Wed, 3 Dec 2025 22:23:02 +0000
Bug 1996299 - Remove pocket.dismiss shims now that Firefox 145 has hit release. r=home-newtab-reviewers,maxx
Differential Revision: https://phabricator.services.mozilla.com/D274852
Diffstat:
1 file changed, 2 insertions(+), 29 deletions(-)
diff --git a/browser/extensions/newtab/lib/TelemetryFeed.sys.mjs b/browser/extensions/newtab/lib/TelemetryFeed.sys.mjs
@@ -1006,17 +1006,9 @@ export class TelemetryFeed {
topic,
} = action.data.value ?? {};
- /**
- * @backward-compat { version 145 }
- *
- * Bug 1990626 - Train-hop Compat Fix (Missing metrics.yaml key)
- */
- const is145AndUp =
- Services.vc.compare(AppConstants.MOZ_APP_VERSION, "145.0a1") >= 0;
-
const gleanData = {
tile_id,
- ...(is145AndUp ? { position: action_position } : {}),
+ position: action_position,
// We conditionally add in a few props.
...(corpus_item_id ? { corpus_item_id } : {}),
...(scheduled_corpus_item_id ? { scheduled_corpus_item_id } : {}),
@@ -1863,27 +1855,8 @@ export class TelemetryFeed {
}),
};
- /**
- * @backward-compat { version 145 }
- *
- * Bug 1991132 - Train-hop Compat Fix (Missing metrics.yaml key)
- * Optimization: This logic should be moved back to its previous position inside the Glean.pocket.dismiss.record() function
- */
- const possiblyRedactedNewTabPing = this.redactNewTabPing(
- gleanData,
- gleanData.is_sponsored
- );
-
- const is143_144 =
- Services.vc.compare(AppConstants.MOZ_APP_VERSION, "143.0a1") >= 0 &&
- Services.vc.compare(AppConstants.MOZ_APP_VERSION, "145.0a1") < 0;
-
- if (is143_144) {
- delete possiblyRedactedNewTabPing.content_redacted;
- }
-
Glean.pocket.dismiss.record({
- ...possiblyRedactedNewTabPing,
+ ...this.redactNewTabPing(gleanData, gleanData.is_sponsored),
newtab_visit_id: session.session_id,
});