tor-browser

commit 42620de69c1c68282f9dd5cdb7c08fe11e41a7f9
parent c2c9f016858e83042eb9fde68b584edb332b6a78
Author: Tom Schuster <tschuster@mozilla.com>
Date:   Thu,  2 Oct 2025 19:23:49 +0000

Bug 1991863 - Optimize sniffing in FaviconLoad. r=mossop

Differential Revision: https://phabricator.services.mozilla.com/D266973

Diffstat:
M
browser/modules/FaviconLoader.sys.mjs
 | 
13
+------------

1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/browser/modules/FaviconLoader.sys.mjs b/browser/modules/FaviconLoader.sys.mjs
@@ -56,17 +56,6 @@ function promiseBlobAsDataURL(blob) {
   });
 }
 
-function promiseBlobAsOctets(blob) {
-  return new Promise((resolve, reject) => {
-    let reader = new FileReader();
-    reader.addEventListener("load", () => {
-      resolve(Array.from(reader.result).map(c => c.charCodeAt(0)));
-    });
-    reader.addEventListener("error", reject);
-    reader.readAsBinaryString(blob);
-  });
-}
-
 function promiseImage(stream, type) {
   return new Promise((resolve, reject) => {
     let imgTools = Cc["@mozilla.org/image/tools;1"].getService(Ci.imgITools);
@@ -293,7 +282,7 @@ class FaviconLoad {
       let blob = new Blob([buffer], { type });
 
       if (type != "image/svg+xml") {
-        let octets = await promiseBlobAsOctets(blob);
+        let octets = new Uint8Array(buffer);
         let sniffer = Cc["@mozilla.org/image/loader;1"].createInstance(
           Ci.nsIContentSniffer
         );