commit 421856fd8c0a9b8b1f52c213b44e1739cdd43adb
parent 42036e3bf70db5c64b259bdac63925e0354dc88e
Author: Michael Kaply <345868+mkaply@users.noreply.github.com>
Date: Fri, 21 Nov 2025 14:55:06 +0000
Bug 2001191 - Hide private window menutems when private browsing is disabled. r=kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D273332
Diffstat:
3 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/browser/base/content/nsContextMenu.sys.mjs b/browser/base/content/nsContextMenu.sys.mjs
@@ -2825,6 +2825,11 @@ export class nsContextMenu {
return;
}
+ if (isPrivateSearchMenuitem && !lazy.PrivateBrowsingUtils.enabled) {
+ menuitem.hidden = true;
+ return;
+ }
+
let isBrowserPrivate = lazy.PrivateBrowsingUtils.isBrowserPrivate(
this.browser
);
diff --git a/browser/components/sidebar/sidebar-history.mjs b/browser/components/sidebar/sidebar-history.mjs
@@ -21,6 +21,7 @@ ChromeUtils.defineESModuleGetters(lazy, {
SidebarTreeView:
"moz-src:///browser/components/sidebar/SidebarTreeView.sys.mjs",
PlacesUtils: "resource://gre/modules/PlacesUtils.sys.mjs",
+ PrivateBrowsingUtils: "resource://gre/modules/PrivateBrowsingUtils.sys.mjs",
});
const NEVER_REMEMBER_HISTORY_PREF = "browser.privatebrowsing.autostart";
@@ -101,6 +102,10 @@ export class SidebarHistory extends SidebarPage {
child.hidden = isMultiSelectCommand;
}
}
+ let privateWindowMenuItem = this._contextMenu.querySelector(
+ "#sidebar-history-context-open-in-private-window"
+ );
+ privateWindowMenuItem.hidden = !lazy.PrivateBrowsingUtils.enabled;
}
handleContextMenuEvent(e) {
diff --git a/browser/components/sidebar/sidebar-syncedtabs.mjs b/browser/components/sidebar/sidebar-syncedtabs.mjs
@@ -4,6 +4,7 @@
const lazy = {};
ChromeUtils.defineESModuleGetters(lazy, {
+ PrivateBrowsingUtils: "resource://gre/modules/PrivateBrowsingUtils.sys.mjs",
SyncedTabsController: "resource:///modules/SyncedTabsController.sys.mjs",
SidebarTreeView:
"moz-src:///browser/components/sidebar/SidebarTreeView.sys.mjs",
@@ -81,6 +82,11 @@ class SyncedTabsInSidebar extends SidebarPage {
);
// Enable the feature only if the device supports it
closeTabMenuItem.disabled = !this.triggerNode.canClose;
+
+ let privateWindowMenuItem = contextMenu.querySelector(
+ "#sidebar-synced-tabs-context-open-in-private-window"
+ );
+ privateWindowMenuItem.hidden = !lazy.PrivateBrowsingUtils.enabled;
}
handleCommandEvent(e) {