tor-browser

commit 3e31c02da708dd6a37641e3bf5cc54705987e2fd
parent 66f995ee957d644ff39a28036d5fb56ab752df7e
Author: Beth Rennie <beth@brennie.ca>
Date:   Fri,  3 Oct 2025 18:53:25 +0000

Bug 1987174 - Skip migrateEnrollmentsToSql when there are no experiments in the store r=nimbus-reviewers,relud

Differential Revision: https://phabricator.services.mozilla.com/D266441

Diffstat:
M
toolkit/components/nimbus/lib/Migrations.sys.mjs
 | 
6
+++++-
M
toolkit/components/nimbus/test/unit/test_RemoteSettingsExperimentLoader.js
 | 
8
--------

2 files changed, 5 insertions(+), 9 deletions(-)
diff --git a/toolkit/components/nimbus/lib/Migrations.sys.mjs b/toolkit/components/nimbus/lib/Migrations.sys.mjs
@@ -124,7 +124,11 @@ async function migrateEnrollmentsToSql() {
     lazy.ExperimentAPI.manager.store._jsonFile.data
   );
 
-  // Likewise, the set of all recipes is
+  // If there are no enrollments we can skip the rest of the migration.
+  if (enrollments.length === 0) {
+    return;
+  }
+
   const { recipes } =
     await lazy.ExperimentAPI._rsLoader.getRecipesFromAllCollections({
       trigger: "migration",
diff --git a/toolkit/components/nimbus/test/unit/test_RemoteSettingsExperimentLoader.js b/toolkit/components/nimbus/test/unit/test_RemoteSettingsExperimentLoader.js
@@ -141,14 +141,6 @@ add_task(async function test_loadingErrorOnEmptyRecipesWithNullLastModified() {
         secure_experiments_success: "true",
         experiments_empty: "true",
         secure_experiments_empty: "true",
-        trigger: "migration",
-      },
-      {
-        force_sync: "false",
-        experiments_success: "true",
-        secure_experiments_success: "true",
-        experiments_empty: "true",
-        secure_experiments_empty: "true",
         trigger: "enabled",
       },
     ],