commit 3be3c8e367ce1c67701130214c3320f6ec5ded85 parent af26e0d427cdfe0d2c80434252df03bf86ffeb42 Author: Valentin Gosu <valentin.gosu@gmail.com> Date: Fri, 24 Oct 2025 13:01:55 +0000 Bug 1984105 - Make sure AllowedToConnectToIpAddressSpace checks pending permissions correctly r=sunil,necko-reviewers This check was looking at whether both permissions were pending. This means that if either one was granted, we would never show the prompt for the other kind. Differential Revision: https://phabricator.services.mozilla.com/D268865 Diffstat:
| M | netwerk/protocol/http/nsHttpTransaction.cpp | | | 9 | ++++++--- |
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/netwerk/protocol/http/nsHttpTransaction.cpp b/netwerk/protocol/http/nsHttpTransaction.cpp @@ -3793,9 +3793,12 @@ bool nsHttpTransaction::AllowedToConnectToIpAddressSpace( if ((StaticPrefs::network_lna_blocking() || StaticPrefs::network_lna_block_trackers()) && - (mLnaPermissionStatus.mLocalHostPermission == LNAPermission::Pending) && - (mLnaPermissionStatus.mLocalNetworkPermission == - LNAPermission::Pending)) { + ((aTargetIpAddressSpace == nsILoadInfo::IPAddressSpace::Local && + mLnaPermissionStatus.mLocalHostPermission == + LNAPermission::Pending) || + (aTargetIpAddressSpace == nsILoadInfo::IPAddressSpace::Private && + mLnaPermissionStatus.mLocalNetworkPermission == + LNAPermission::Pending))) { // If LNA prompts are enabled or tracker blocking is enabled we disallow // requests return false;