tor-browser

commit 3b803d1d38882383db5aa3c5c823d0fd6964f5c3
parent 6847e4953fdb63788f173c0e300ce2f96dfe8d77
Author: Duncan McIntosh <dmcintosh@mozilla.com>
Date:   Wed,  5 Nov 2025 14:50:47 +0000

Bug 1911904 - Restore syncPane spy after completing test_preferences_visibility test. r=fchasen

I'd like to overhaul test_preferences_visiblity at some point (stubbing out
archiveEnabledStatus instead of twiddling prefs), but I think that bug
1996070 might need to be fixed first.

This assumes that the original reported issue in browser_settings is no
longer present, since this only appears to be a problem if the tests are
repeated, like in a verify run.

Differential Revision: https://phabricator.services.mozilla.com/D271254

Diffstat:
M
browser/components/backup/tests/browser/browser.toml
 | 
6
------
M
browser/components/backup/tests/browser/browser_settings.js
 | 
3
++-

2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/browser/components/backup/tests/browser/browser.toml b/browser/components/backup/tests/browser/browser.toml
@@ -14,12 +14,6 @@ support-files = [
 ["browser_password_validation_inputs.js"]
 
 ["browser_settings.js"]
-skip-if = [
-  "os == 'linux' && os_version == '18.04' && processor == 'x86_64' && debug", # Bug 1911904
-  "os == 'linux' && os_version == '18.04' && processor == 'x86_64' && tsan", # Bug 1911904
-  "os == 'mac' && os_version == '15.30' && arch == 'aarch64'", # Bug 1911904
-  "os == 'win' && os_version == '11.26100' && processor == 'x86_64' && opt", # Bug 1911904
-]
 
 ["browser_settings_create_backup.js"]
 
diff --git a/browser/components/backup/tests/browser/browser_settings.js b/browser/components/backup/tests/browser/browser_settings.js
@@ -109,9 +109,10 @@ add_task(async function test_preferences_visibility() {
     await SpecialPowers.popPrefEnv();
 
     Services.obs.removeObserver(
-      gBrowser.contentWindow.gSyncPane.updateBackupUIVisibility,
+      syncPane.updateBackupUIVisibility,
       "backup-service-status-updated"
     );
+    sandbox.restore();
   });
 });