commit 3a7422627b2a8daf3767ffe0f0577f349f785101
parent aeed79d6a8d52af7077c4b3d53df523aa0dfee8d
Author: elkal98 <khalid.alhaddad98@gmail.com>
Date: Fri, 3 Oct 2025 13:41:57 +0000
Bug 1882718 - Rename add_cookie to add_document_cookie, r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D267322
Diffstat:
7 files changed, 87 insertions(+), 83 deletions(-)
diff --git a/testing/web-platform/mozilla/tests/webdriver/bidi/storage/delete_cookies/partition.py b/testing/web-platform/mozilla/tests/webdriver/bidi/storage/delete_cookies/partition.py
@@ -20,7 +20,7 @@ async def test_partition_context(
new_tab,
test_page,
domain_value,
- add_cookie,
+ add_document_cookie,
set_cookie,
with_document_cookie,
):
@@ -33,7 +33,7 @@ async def test_partition_context(
source_origin = get_origin_from_url(test_page)
partition = BrowsingContextPartitionDescriptor(new_tab["context"])
if with_document_cookie:
- await add_cookie(new_tab["context"], cookie_name, cookie_value)
+ await add_document_cookie(new_tab["context"], cookie_name, cookie_value)
else:
await set_cookie(
cookie=PartialCookie(
@@ -92,7 +92,7 @@ async def test_partition_context_same_origin_iframe_with_document_cookie(
bidi_session,
new_tab,
inline,
- add_cookie,
+ add_document_cookie,
):
iframe_url = inline("<div id='in-iframe'>foo</div>")
page_url = inline(f"<iframe src='{iframe_url}'></iframe>")
@@ -107,7 +107,7 @@ async def test_partition_context_same_origin_iframe_with_document_cookie(
cookie_name = "foo"
cookie_value = "bar"
frame_partition = BrowsingContextPartitionDescriptor(iframe_context["context"])
- await add_cookie(iframe_context["context"], cookie_name, cookie_value)
+ await add_document_cookie(iframe_context["context"], cookie_name, cookie_value)
result = await bidi_session.storage.delete_cookies(partition=frame_partition)
recursive_compare({"partitionKey": {"sourceOrigin": source_origin}}, result)
diff --git a/testing/web-platform/mozilla/tests/webdriver/bidi/storage/get_cookies/partition.py b/testing/web-platform/mozilla/tests/webdriver/bidi/storage/get_cookies/partition.py
@@ -11,7 +11,7 @@ async def test_partition_context(
new_tab,
test_page,
domain_value,
- add_cookie,
+ add_document_cookie,
top_context,
test_page_cross_origin,
):
@@ -27,7 +27,9 @@ async def test_partition_context(
cookie_name = "foo"
cookie_value = "bar"
- await add_cookie(new_tab["context"], cookie_name, cookie_value, secure=True)
+ await add_document_cookie(
+ new_tab["context"], cookie_name, cookie_value, secure=True
+ )
# Check that added cookies are present on the right context.
cookies = await bidi_session.storage.get_cookies(
@@ -70,7 +72,7 @@ async def test_partition_context(
# Because of Dynamic First-Party Isolation, adding the cookie with `document.cookie`
# works only with same-origin iframes.
async def test_partition_context_same_origin_iframe(
- bidi_session, new_tab, inline, domain_value, add_cookie
+ bidi_session, new_tab, inline, domain_value, add_document_cookie
):
iframe_url = inline("<div id='in-iframe'>foo</div>")
source_origin = get_origin_from_url(iframe_url)
@@ -84,7 +86,9 @@ async def test_partition_context_same_origin_iframe(
cookie_name = "foo"
cookie_value = "bar"
- await add_cookie(iframe_context["context"], cookie_name, cookie_value, secure=True)
+ await add_document_cookie(
+ iframe_context["context"], cookie_name, cookie_value, secure=True
+ )
# Check that added cookies are present on the right context
cookies = await bidi_session.storage.get_cookies(
diff --git a/testing/web-platform/tests/webdriver/tests/bidi/storage/delete_cookies/filter.py b/testing/web-platform/tests/webdriver/tests/bidi/storage/delete_cookies/filter.py
@@ -27,7 +27,7 @@ async def test_filter(
new_tab,
test_page,
domain_value,
- add_cookie,
+ add_document_cookie,
filter,
):
await bidi_session.browsing_context.navigate(
@@ -40,14 +40,14 @@ async def test_filter(
cookie_value_matching_filter = "bar"
cookie1_name = "baz"
- await add_cookie(new_tab["context"], cookie1_name, cookie_value_matching_filter, secure=True)
+ await add_document_cookie(new_tab["context"], cookie1_name, cookie_value_matching_filter, secure=True)
cookie2_name = "foo"
- await add_cookie(new_tab["context"], cookie2_name, cookie_value_matching_filter, secure=True)
+ await add_document_cookie(new_tab["context"], cookie2_name, cookie_value_matching_filter, secure=True)
cookie3_name = "foo_3"
cookie3_value = "not_bar"
- await add_cookie(new_tab["context"], cookie3_name, cookie3_value, secure=True)
+ await add_document_cookie(new_tab["context"], cookie3_name, cookie3_value, secure=True)
result = await bidi_session.storage.delete_cookies(
filter=filter,
@@ -75,7 +75,7 @@ async def test_filter_domain(
test_page,
test_page_cross_origin,
domain_value,
- add_cookie,
+ add_document_cookie,
):
await bidi_session.browsing_context.navigate(
context=top_context["context"], url=test_page, wait="complete"
@@ -86,16 +86,16 @@ async def test_filter_domain(
cookie1_name = "bar"
cookie1_value = "foo"
- await add_cookie(top_context["context"], cookie1_name, cookie1_value, secure=True)
+ await add_document_cookie(top_context["context"], cookie1_name, cookie1_value, secure=True)
cookie2_name = "foo"
cookie2_value = "bar"
- await add_cookie(top_context["context"], cookie2_name, cookie2_value, secure=True)
+ await add_document_cookie(top_context["context"], cookie2_name, cookie2_value, secure=True)
cookie3_name = "foo_2"
cookie3_value = "bar_2"
cookie3_domain = domain_value(domain="alt")
- await add_cookie(new_tab["context"], cookie3_name, cookie3_value, secure=True)
+ await add_document_cookie(new_tab["context"], cookie3_name, cookie3_value, secure=True)
filter = CookieFilter(domain=domain_value())
result = await bidi_session.storage.delete_cookies(
@@ -129,7 +129,7 @@ async def test_filter_expiry(
new_tab,
test_page,
domain_value,
- add_cookie,
+ add_document_cookie,
expiry_diff_to_delete,
expiry_diff_to_remain,
):
@@ -143,7 +143,7 @@ async def test_filter_expiry(
cookie1_name = "bar"
cookie1_value = "foo"
- await add_cookie(
+ await add_document_cookie(
context=new_tab["context"],
name=cookie1_name,
value=cookie1_value,
@@ -153,7 +153,7 @@ async def test_filter_expiry(
cookie2_name = "foo"
cookie2_value = "bar"
- await add_cookie(
+ await add_document_cookie(
context=new_tab["context"],
name=cookie2_name,
value=cookie2_value,
@@ -169,7 +169,7 @@ async def test_filter_expiry(
expiry_date_to_remain = generate_expiry_date(expiry_diff_to_remain)
date_string_to_remain = format_expiry_string(expiry_date_to_remain)
- await add_cookie(
+ await add_document_cookie(
new_tab["context"],
cookie3_name,
cookie3_value,
@@ -197,7 +197,7 @@ async def test_filter_expiry(
)
-async def test_filter_name(bidi_session, new_tab, test_page, add_cookie, domain_value):
+async def test_filter_name(bidi_session, new_tab, test_page, add_document_cookie, domain_value):
await bidi_session.browsing_context.navigate(
context=new_tab["context"], url=test_page, wait="complete"
)
@@ -206,20 +206,20 @@ async def test_filter_name(bidi_session, new_tab, test_page, add_cookie, domain_
cookie1_value = "bar"
cookie1_path = "/"
- await add_cookie(
+ await add_document_cookie(
new_tab["context"], name_to_delete, cookie1_value, path=cookie1_path, secure=True
)
cookie2_value = "baz"
cookie2_path = "/webdriver/"
- await add_cookie(
+ await add_document_cookie(
new_tab["context"], name_to_delete, cookie2_value, path=cookie2_path, secure=True
)
name_to_remain = "foo_2"
cookie3_value = "bar_2"
cookie3_path = "/"
- await add_cookie(new_tab["context"], name_to_remain, cookie3_value, path=cookie3_path, secure=True)
+ await add_document_cookie(new_tab["context"], name_to_remain, cookie3_value, path=cookie3_path, secure=True)
filter = CookieFilter(name=name_to_delete)
result = await bidi_session.storage.delete_cookies(
@@ -258,7 +258,7 @@ async def test_filter_same_site(
domain_value,
same_site_to_delete,
same_site_to_remain,
- add_cookie,
+ add_document_cookie,
):
await bidi_session.browsing_context.navigate(
context=new_tab["context"], url=test_page, wait="complete"
@@ -266,7 +266,7 @@ async def test_filter_same_site(
cookie1_name = "bar"
cookie1_value = "foo"
- await add_cookie(
+ await add_document_cookie(
new_tab["context"],
cookie1_name,
cookie1_value,
@@ -276,7 +276,7 @@ async def test_filter_same_site(
cookie2_name = "foo"
cookie2_value = "bar"
- await add_cookie(
+ await add_document_cookie(
new_tab["context"],
cookie2_name,
cookie2_value,
@@ -286,7 +286,7 @@ async def test_filter_same_site(
cookie3_name = "foo_3"
cookie3_value = "bar_3"
- await add_cookie(
+ await add_document_cookie(
new_tab["context"], cookie3_name, cookie3_value, same_site=same_site_to_remain, secure=True
)
@@ -320,7 +320,7 @@ async def test_filter_secure(
new_tab,
test_page,
domain_value,
- add_cookie,
+ add_document_cookie,
secure_to_delete,
secure_to_remain,
):
@@ -330,7 +330,7 @@ async def test_filter_secure(
cookie1_name = "bar"
cookie1_value = "foo"
- await add_cookie(
+ await add_document_cookie(
new_tab["context"],
cookie1_name,
cookie1_value,
@@ -340,7 +340,7 @@ async def test_filter_secure(
cookie2_name = "foo"
cookie2_value = "bar"
- await add_cookie(
+ await add_document_cookie(
new_tab["context"],
cookie2_name,
cookie2_value,
@@ -350,7 +350,7 @@ async def test_filter_secure(
cookie3_name = "foo_3"
cookie3_value = "bar_3"
- await add_cookie(
+ await add_document_cookie(
new_tab["context"], cookie3_name, cookie3_value, same_site="strict", secure=secure_to_remain
)
@@ -388,7 +388,7 @@ async def test_filter_path(
new_tab,
test_page,
domain_value,
- add_cookie,
+ add_document_cookie,
path_to_delete,
path_to_remain,
):
@@ -398,7 +398,7 @@ async def test_filter_path(
cookie1_name = "bar"
cookie1_value = "foo"
- await add_cookie(
+ await add_document_cookie(
new_tab["context"],
cookie1_name,
cookie1_value,
@@ -408,7 +408,7 @@ async def test_filter_path(
cookie2_name = "foo"
cookie2_value = "bar"
- await add_cookie(
+ await add_document_cookie(
new_tab["context"],
cookie2_name,
cookie2_value,
@@ -418,7 +418,7 @@ async def test_filter_path(
cookie3_name = "foo_3"
cookie3_value = "bar_3"
- await add_cookie(
+ await add_document_cookie(
new_tab["context"], cookie3_name, cookie3_value, path=path_to_remain, secure=True
)
diff --git a/testing/web-platform/tests/webdriver/tests/bidi/storage/delete_cookies/partition.py b/testing/web-platform/tests/webdriver/tests/bidi/storage/delete_cookies/partition.py
@@ -25,7 +25,7 @@ async def test_default_partition(
test_page,
test_page_cross_origin,
domain_value,
- add_cookie,
+ add_document_cookie,
set_cookie,
with_document_cookie,
):
@@ -43,8 +43,8 @@ async def test_default_partition(
cookie2_value = "bar_2"
if with_document_cookie:
- await add_cookie(new_tab["context"], cookie1_name, cookie1_value, secure=True)
- await add_cookie(top_context["context"], cookie2_name, cookie2_value, secure=True)
+ await add_document_cookie(new_tab["context"], cookie1_name, cookie1_value, secure=True)
+ await add_document_cookie(top_context["context"], cookie2_name, cookie2_value, secure=True)
else:
await set_cookie(
cookie=create_cookie(
@@ -77,7 +77,7 @@ async def test_partition_context(
new_tab,
test_page,
domain_value,
- add_cookie,
+ add_document_cookie,
set_cookie,
with_document_cookie,
):
@@ -89,7 +89,7 @@ async def test_partition_context(
cookie_value = "bar"
partition = BrowsingContextPartitionDescriptor(new_tab["context"])
if with_document_cookie:
- await add_cookie(new_tab["context"], cookie_name, cookie_value, secure=True)
+ await add_document_cookie(new_tab["context"], cookie_name, cookie_value, secure=True)
else:
await set_cookie(
cookie=create_cookie(
@@ -224,7 +224,7 @@ async def test_partition_user_context(
create_user_context,
test_page_cross_origin,
domain_value,
- add_cookie,
+ add_document_cookie,
set_cookie,
with_document_cookie,
):
@@ -255,10 +255,10 @@ async def test_partition_user_context(
cookie2_partition = StorageKeyPartitionDescriptor(user_context=user_context_2)
if with_document_cookie:
- await add_cookie(
+ await add_document_cookie(
new_context_1["context"], cookie1_name, cookie1_value, path="/", secure=True
)
- await add_cookie(
+ await add_document_cookie(
new_context_2["context"], cookie2_name, cookie2_value, path="/", secure=True
)
else:
diff --git a/testing/web-platform/tests/webdriver/tests/bidi/storage/get_cookies/filter.py b/testing/web-platform/tests/webdriver/tests/bidi/storage/get_cookies/filter.py
@@ -17,7 +17,7 @@ pytestmark = pytest.mark.asyncio
],
)
async def test_filter(
- bidi_session, new_tab, test_page, domain_value, add_cookie, filter
+ bidi_session, new_tab, test_page, domain_value, add_document_cookie, filter
):
await bidi_session.browsing_context.navigate(
context=new_tab["context"], url=test_page, wait="complete"
@@ -25,13 +25,13 @@ async def test_filter(
value_1 = "bar"
cookie1_name = "baz"
- await add_cookie(new_tab["context"], cookie1_name, value_1, secure=True)
+ await add_document_cookie(new_tab["context"], cookie1_name, value_1, secure=True)
cookie2_name = "foo"
- await add_cookie(new_tab["context"], cookie2_name, value_1, secure=True)
+ await add_document_cookie(new_tab["context"], cookie2_name, value_1, secure=True)
cookie3_name = "foo_3"
- await add_cookie(new_tab["context"], cookie3_name, "bar_3", secure=True)
+ await add_document_cookie(new_tab["context"], cookie3_name, "bar_3", secure=True)
cookies = await bidi_session.storage.get_cookies(
filter=filter,
@@ -76,7 +76,7 @@ async def test_filter_domain(
test_page,
test_page_cross_origin,
domain_value,
- add_cookie,
+ add_document_cookie,
):
await bidi_session.browsing_context.navigate(
context=top_context["context"], url=test_page, wait="complete"
@@ -87,15 +87,15 @@ async def test_filter_domain(
cookie1_name = "bar"
cookie1_value = "foo"
- await add_cookie(top_context["context"], cookie1_name, cookie1_value, secure=True)
+ await add_document_cookie(top_context["context"], cookie1_name, cookie1_value, secure=True)
cookie2_name = "foo"
cookie2_value = "bar"
- await add_cookie(top_context["context"], cookie2_name, cookie2_value, secure=True)
+ await add_document_cookie(top_context["context"], cookie2_name, cookie2_value, secure=True)
cookie3_name = "foo_2"
cookie3_value = "bar_2"
- await add_cookie(new_tab["context"], cookie3_name, cookie3_value, secure=True)
+ await add_document_cookie(new_tab["context"], cookie3_name, cookie3_value, secure=True)
domain = domain_value()
cookies = await bidi_session.storage.get_cookies(
@@ -146,7 +146,7 @@ async def test_filter_expiry(
new_tab,
test_page,
domain_value,
- add_cookie,
+ add_document_cookie,
expiry_diff_1,
expiry_diff_2,
):
@@ -160,7 +160,7 @@ async def test_filter_expiry(
cookie1_name = "bar"
cookie1_value = "foo"
- await add_cookie(
+ await add_document_cookie(
context=new_tab["context"],
name=cookie1_name,
value=cookie1_value,
@@ -170,7 +170,7 @@ async def test_filter_expiry(
cookie2_name = "foo"
cookie2_value = "bar"
- await add_cookie(
+ await add_document_cookie(
context=new_tab["context"],
name=cookie2_name,
value=cookie2_value,
@@ -185,7 +185,7 @@ async def test_filter_expiry(
cookie2_expiry_date = generate_expiry_date(expiry_diff_2)
cookie2_date_string = format_expiry_string(cookie2_expiry_date)
- await add_cookie(
+ await add_document_cookie(
new_tab["context"], cookie3_name, "bar_3", expiry=cookie2_date_string, secure=True
)
@@ -227,17 +227,17 @@ async def test_filter_expiry(
)
-async def test_filter_name(bidi_session, new_tab, test_page, domain_value, add_cookie):
+async def test_filter_name(bidi_session, new_tab, test_page, domain_value, add_document_cookie):
await bidi_session.browsing_context.navigate(
context=new_tab["context"], url=test_page, wait="complete"
)
cookie1_name = "foo"
cookie1_value = "bar"
- await add_cookie(new_tab["context"], cookie1_name, cookie1_value, secure=True)
+ await add_document_cookie(new_tab["context"], cookie1_name, cookie1_value, secure=True)
cookie2_name = "foo_2"
- await add_cookie(new_tab["context"], cookie2_name, "bar_2", secure=True)
+ await add_document_cookie(new_tab["context"], cookie2_name, "bar_2", secure=True)
cookies = await bidi_session.storage.get_cookies(
filter={"name": "foo"},
@@ -277,7 +277,7 @@ async def test_filter_name(bidi_session, new_tab, test_page, domain_value, add_c
],
)
async def test_filter_same_site(
- bidi_session, new_tab, test_page, domain_value, same_site_1, same_site_2, add_cookie
+ bidi_session, new_tab, test_page, domain_value, same_site_1, same_site_2, add_document_cookie
):
await bidi_session.browsing_context.navigate(
context=new_tab["context"], url=test_page, wait="complete"
@@ -285,7 +285,7 @@ async def test_filter_same_site(
cookie1_name = "bar"
cookie1_value = "foo"
- await add_cookie(
+ await add_document_cookie(
new_tab["context"],
cookie1_name,
cookie1_value,
@@ -295,7 +295,7 @@ async def test_filter_same_site(
cookie2_name = "foo"
cookie2_value = "bar"
- await add_cookie(
+ await add_document_cookie(
new_tab["context"],
cookie2_name,
cookie2_value,
@@ -304,7 +304,7 @@ async def test_filter_same_site(
)
cookie3_name = "foo_3"
- await add_cookie(new_tab["context"], cookie3_name, "bar_3", same_site=same_site_2, secure=True)
+ await add_document_cookie(new_tab["context"], cookie3_name, "bar_3", same_site=same_site_2, secure=True)
cookies = await bidi_session.storage.get_cookies(
filter=CookieFilter(same_site=same_site_1),
@@ -347,7 +347,7 @@ async def test_filter_same_site(
[(True, False), (False, True)],
)
async def test_filter_secure(
- bidi_session, new_tab, test_page, domain_value, add_cookie, secure_1, secure_2
+ bidi_session, new_tab, test_page, domain_value, add_document_cookie, secure_1, secure_2
):
await bidi_session.browsing_context.navigate(
context=new_tab["context"], url=test_page, wait="complete"
@@ -355,7 +355,7 @@ async def test_filter_secure(
cookie1_name = "bar"
cookie1_value = "foo"
- await add_cookie(
+ await add_document_cookie(
new_tab["context"],
cookie1_name,
cookie1_value,
@@ -365,7 +365,7 @@ async def test_filter_secure(
cookie2_name = "foo"
cookie2_value = "bar"
- await add_cookie(
+ await add_document_cookie(
new_tab["context"],
cookie2_name,
cookie2_value,
@@ -374,7 +374,7 @@ async def test_filter_secure(
)
cookie3_name = "foo_3"
- await add_cookie(new_tab["context"], cookie3_name, "bar_3", same_site="strict", secure=secure_2)
+ await add_document_cookie(new_tab["context"], cookie3_name, "bar_3", same_site="strict", secure=secure_2)
cookies = await bidi_session.storage.get_cookies(
filter=CookieFilter(secure=secure_1),
@@ -425,7 +425,7 @@ async def test_filter_path(
new_tab,
test_page,
domain_value,
- add_cookie,
+ add_document_cookie,
path_1,
path_2,
):
@@ -435,7 +435,7 @@ async def test_filter_path(
cookie1_name = "bar"
cookie1_value = "foo"
- await add_cookie(
+ await add_document_cookie(
new_tab["context"],
cookie1_name,
cookie1_value,
@@ -445,7 +445,7 @@ async def test_filter_path(
cookie2_name = "foo"
cookie2_value = "bar"
- await add_cookie(
+ await add_document_cookie(
new_tab["context"],
cookie2_name,
cookie2_value,
@@ -454,7 +454,7 @@ async def test_filter_path(
)
cookie3_name = "foo_3"
- await add_cookie(new_tab["context"], cookie3_name, "bar_3", path=path_2, secure=True)
+ await add_document_cookie(new_tab["context"], cookie3_name, "bar_3", path=path_2, secure=True)
cookies = await bidi_session.storage.get_cookies(
filter=CookieFilter(path=path_1),
diff --git a/testing/web-platform/tests/webdriver/tests/bidi/storage/get_cookies/partition.py b/testing/web-platform/tests/webdriver/tests/bidi/storage/get_cookies/partition.py
@@ -19,7 +19,7 @@ async def test_default_partition(
test_page,
test_page_cross_origin,
domain_value,
- add_cookie,
+ add_document_cookie,
):
await bidi_session.browsing_context.navigate(
context=top_context["context"], url=test_page_cross_origin, wait="complete"
@@ -30,11 +30,11 @@ async def test_default_partition(
cookie1_name = "foo"
cookie1_value = "bar"
- await add_cookie(new_tab["context"], cookie1_name, cookie1_value, secure=True)
+ await add_document_cookie(new_tab["context"], cookie1_name, cookie1_value, secure=True)
cookie2_name = "foo_2"
cookie2_value = "bar_2"
- await add_cookie(top_context["context"], cookie2_name, cookie2_value, secure=True)
+ await add_document_cookie(top_context["context"], cookie2_name, cookie2_value, secure=True)
cookies = await bidi_session.storage.get_cookies()
@@ -75,7 +75,7 @@ async def test_partition_context(
new_tab,
test_page,
domain_value,
- add_cookie,
+ add_document_cookie,
create_user_context,
test_page_cross_origin,
):
@@ -94,7 +94,7 @@ async def test_partition_context(
cookie_name = "foo"
cookie_value = "bar"
- await add_cookie(new_tab["context"], cookie_name, cookie_value, secure=True)
+ await add_document_cookie(new_tab["context"], cookie_name, cookie_value, secure=True)
# Check that added cookies are present on the right context.
cookies = await bidi_session.storage.get_cookies(
@@ -300,7 +300,7 @@ async def test_partition_default_user_context(
bidi_session,
test_page,
domain_value,
- add_cookie,
+ add_document_cookie,
):
new_context = await bidi_session.browsing_context.create(type_hint="tab")
await bidi_session.browsing_context.navigate(
@@ -309,7 +309,7 @@ async def test_partition_default_user_context(
cookie_name = "foo"
cookie_value = "bar"
- await add_cookie(new_context["context"], cookie_name, cookie_value, secure=True)
+ await add_document_cookie(new_context["context"], cookie_name, cookie_value, secure=True)
# Check that added cookies are present on the right user context.
result = await bidi_session.storage.get_cookies(
@@ -342,7 +342,7 @@ async def test_partition_user_context(
domain_value,
create_user_context,
test_page_cross_origin,
- add_cookie,
+ add_document_cookie,
):
user_context_1 = await create_user_context()
new_context_1 = await bidi_session.browsing_context.create(
@@ -362,7 +362,7 @@ async def test_partition_user_context(
cookie_name = "foo_1"
cookie_value = "bar_1"
- await add_cookie(new_context_1["context"], cookie_name, cookie_value, secure=True)
+ await add_document_cookie(new_context_1["context"], cookie_name, cookie_value, secure=True)
# Check that added cookies are present on the right user context.
result = await bidi_session.storage.get_cookies(
diff --git a/testing/web-platform/tests/webdriver/tests/support/fixtures_bidi.py b/testing/web-platform/tests/webdriver/tests/support/fixtures_bidi.py
@@ -531,13 +531,13 @@ async def create_user_context(bidi_session):
@pytest_asyncio.fixture
-async def add_cookie(bidi_session):
+async def add_document_cookie(bidi_session):
"""
Add a cookie with `document.cookie` and remove them after the test is finished.
"""
cookies = []
- async def add_cookie(
+ async def add_document_cookie(
context,
name,
value,
@@ -574,7 +574,7 @@ async def add_cookie(bidi_session):
cookies.append(cookie)
- yield add_cookie
+ yield add_document_cookie
for cookie in reversed(cookies):
cookie_string = f"""{cookie["name"]}="""
