tor-browser

commit 379c4b1dd7914b2a852bb99797738d4410d77adf
parent fbca7ab31dfe4dc857390f5d82ea20cf823efca2
Author: Jared Hirsch <ohai@6a68.net>
Date:   Fri,  3 Oct 2025 18:23:00 +0000

Bug 1990550 - Suppress the NEW_PROFILE_APP_MENU_TOUR callout in the tests. r=profiles-reviewers,omc-reviewers,niklas,jprickett

* Also hide the callout for users with CFR enabled.

* Also limit the callout to English-speaking locales for 144 uplift.

Differential Revision: https://phabricator.services.mozilla.com/D267446

Diffstat:
M
browser/components/asrouter/modules/FeatureCalloutMessages.sys.mjs
 | 
3
++-
M
browser/components/profiles/tests/browser/browser_appmenu_menuitem_updates.js
 | 
12
------------

2 files changed, 2 insertions(+), 13 deletions(-)
diff --git a/browser/components/asrouter/modules/FeatureCalloutMessages.sys.mjs b/browser/components/asrouter/modules/FeatureCalloutMessages.sys.mjs
@@ -1892,7 +1892,7 @@ const MESSAGES = () => {
       groups: [],
       profileScope: "single",
       targeting:
-        "'browser.profiles.profile-name.updated' | preferenceValue == true",
+        "'browser.profiles.profile-name.updated' | preferenceValue == true && userPrefs.cfrFeatures && localeLanguageCode == 'en'",
       trigger: {
         id: "preferenceObserver",
         params: ["browser.profiles.profile-name.updated"],
@@ -1900,6 +1900,7 @@ const MESSAGES = () => {
       frequency: {
         lifetime: 1,
       },
+      skip_in_tests: "it's not tested in automation",
       template: "feature_callout",
       content: {
         id: "NEW_PROFILE_APP_MENU_TOUR",
diff --git a/browser/components/profiles/tests/browser/browser_appmenu_menuitem_updates.js b/browser/components/profiles/tests/browser/browser_appmenu_menuitem_updates.js
@@ -36,18 +36,6 @@ add_task(async function test_appmenu_updates_on_edit() {
   SelectableProfileService.currentProfile.name = INITIAL_NAME;
   await promiseAppMenuOpened();
 
-  // Close the instructional callout, then resume the test.
-  await TestUtils.waitForCondition(() =>
-    document.querySelector("button.dismiss-button")
-  );
-  document.querySelector("button.dismiss-button").click();
-  await TestUtils.waitForCondition(
-    () => !document.querySelector("button.dismiss-button")
-  );
-  // The callout leaves some residue on the window which breaks the test. TODO fix.
-  delete window.React;
-  delete window.ReactDOM;
-
   let view = PanelMultiView.getViewNode(document, "appMenu-profiles-button");
   Assert.equal(view.label, INITIAL_NAME, "expected the initial name");