commit 35865c3f99266872c9525064da1451aa2c69498c parent 5530250cfc2f8d817ae47b4735d807ddb56d727f Author: Drew Willcoxon <adw@mozilla.com> Date: Mon, 27 Oct 2025 22:28:21 +0000 Bug 1995574 - Part 5: Update pref telemetry and "disable" telemetry: Replace the `browser.urlbar.suggest.quicksuggest.nonsponsored` pref with `browser.urlbar.suggest.quicksuggest.all`. r=daisuke,Standard8,urlbar-reviewers This updates pref telemetry and "disable" telemetry for the new `all` pref and the removal of the `nonsponsored` pref. Depends on D269896 Differential Revision: https://phabricator.services.mozilla.com/D269897 Diffstat:
6 files changed, 15 insertions(+), 12 deletions(-)
diff --git a/browser/components/urlbar/UrlbarController.sys.mjs b/browser/components/urlbar/UrlbarController.sys.mjs @@ -1625,7 +1625,7 @@ class TelemetryEvent { maxRichResults: Glean.urlbar.prefMaxResults, "quicksuggest.online.available": Glean.urlbar.prefSuggestOnlineAvailable, "quicksuggest.online.enabled": Glean.urlbar.prefSuggestOnlineEnabled, - "suggest.quicksuggest.nonsponsored": Glean.urlbar.prefSuggestNonsponsored, + "suggest.quicksuggest.all": Glean.urlbar.prefSuggestAll, "suggest.quicksuggest.sponsored": Glean.urlbar.prefSuggestSponsored, "suggest.topsites": Glean.urlbar.prefSuggestTopsites, }; @@ -1651,7 +1651,7 @@ class TelemetryEvent { metric.set(prefValue); } switch (pref) { - case "suggest.quicksuggest.nonsponsored": + case "suggest.quicksuggest.all": case "suggest.quicksuggest.sponsored": case "quicksuggest.enabled": if (!prefValue) { diff --git a/browser/components/urlbar/docs/firefox-suggest-telemetry.rst b/browser/components/urlbar/docs/firefox-suggest-telemetry.rst @@ -1375,8 +1375,12 @@ Changelog all other users, it will default to true when/if they are enrolled in online. [Bug 1740965_] + Firefox 146.0 + Removed. [Bug 1995574_] + .. _1735976: https://bugzilla.mozilla.org/show_bug.cgi?id=1735976 .. _1740965: https://bugzilla.mozilla.org/show_bug.cgi?id=1740965 +.. _1995574: https://bugzilla.mozilla.org/show_bug.cgi?id=1995574 browser.urlbar.suggest.quicksuggest.sponsored ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ diff --git a/browser/components/urlbar/metrics.yaml b/browser/components/urlbar/metrics.yaml @@ -816,18 +816,17 @@ urlbar: send_in_pings: - events - pref_suggest_nonsponsored: + pref_suggest_all: lifetime: application type: boolean description: > - Whether non-sponsored quick suggest results are shown in the urlbar. + Whether Suggest results are shown in the urlbar. Corresponds to the value of the - `browser.urlbar.suggest.quicksuggest.nonsponsored` pref. + `browser.urlbar.suggest.quicksuggest.all` pref. bugs: - - https://bugzilla.mozilla.org/show_bug.cgi?id=1847855 - - https://bugzilla.mozilla.org/show_bug.cgi?id=1849726 + - https://bugzilla.mozilla.org/show_bug.cgi?id=1995574 data_reviews: - - https://bugzilla.mozilla.org/show_bug.cgi?id=1847855 + - https://bugzilla.mozilla.org/show_bug.cgi?id=1995574 data_sensitivity: - interaction notification_emails: diff --git a/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_disable.js b/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_disable.js @@ -85,7 +85,7 @@ function getSuggestPref(type) { if (type == "sponsored") { return "suggest.quicksuggest.sponsored"; } else if (type == "nonsponsored") { - return "suggest.quicksuggest.nonsponsored"; + return "suggest.quicksuggest.all"; } else if (type == "suggest") { return "quicksuggest.enabled"; } diff --git a/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_record_preferences.js b/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_record_preferences.js @@ -45,8 +45,8 @@ add_task(async function boolPref() { pref: "quicksuggest.online.enabled", }, { - green: "prefSuggestNonsponsored", - pref: "suggest.quicksuggest.nonsponsored", + green: "prefSuggestAll", + pref: "suggest.quicksuggest.all", }, { green: "prefSuggestSponsored", diff --git a/tools/@types/generated/lib.gecko.glean.d.ts b/tools/@types/generated/lib.gecko.glean.d.ts @@ -1292,7 +1292,7 @@ interface GleanImpl { heuristicResultMissing: GleanRate; keywordExposure: GleanEventWithExtras<{ keyword?: string, result?: string, terminal?: string }>; prefMaxResults: GleanQuantity; - prefSuggestNonsponsored: GleanBoolean; + prefSuggestAll: GleanBoolean; prefSuggestOnlineAvailable: GleanBoolean; prefSuggestOnlineEnabled: GleanBoolean; prefSuggestSponsored: GleanBoolean;