tor-browser

commit 3102e96a538277a8797d7029c46258738ddfecaa
parent b15cf7f3d9980c5bc3a99ed8441b7e505c0de6bd
Author: Dão Gottwald <dao@mozilla.com>
Date:   Fri, 28 Nov 2025 10:58:07 +0000

Bug 2002470 - Collect urlbar.unifiedsearchbutton Glean probes only for the address bar. r=Standard8,daleharvey,urlbar-reviewers

Differential Revision: https://phabricator.services.mozilla.com/D274315

Diffstat:
M
browser/components/urlbar/SearchModeSwitcher.sys.mjs
 | 
23
++++++++++++++++-------

1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/browser/components/urlbar/SearchModeSwitcher.sys.mjs b/browser/components/urlbar/SearchModeSwitcher.sys.mjs
@@ -67,7 +67,10 @@ export class SearchModeSwitcher {
   async #onPopupShowing() {
     await this.#buildSearchModeList();
     this.#input.view.close({ showFocusBorder: false });
-    Glean.urlbarUnifiedsearchbutton.opened.add(1);
+
+    if (this.#input.sapName == "urlbar") {
+      Glean.urlbarUnifiedsearchbutton.opened.add(1);
+    }
   }
 
   /**
@@ -93,7 +96,9 @@ export class SearchModeSwitcher {
     this.#input.window.openPreferences("paneSearch");
     this.#popup.hidePopup();
 
-    Glean.urlbarUnifiedsearchbutton.picked.settings.add(1);
+    if (this.#input.sapName == "urlbar") {
+      Glean.urlbarUnifiedsearchbutton.picked.settings.add(1);
+    }
   }
 
   /**
@@ -504,12 +509,16 @@ export class SearchModeSwitcher {
     this.#popup.hidePopup();
 
     if (engine) {
-      // TODO do we really need to distinguish here?
-      Glean.urlbarUnifiedsearchbutton.picked[
-        engine.isConfigEngine ? "builtin_search" : "addon_search"
-      ].add(1);
+      if (this.#input.sapName == "urlbar") {
+        // TODO do we really need to distinguish here?
+        Glean.urlbarUnifiedsearchbutton.picked[
+          engine.isConfigEngine ? "builtin_search" : "addon_search"
+        ].add(1);
+      }
     } else if (restrict) {
-      Glean.urlbarUnifiedsearchbutton.picked.local_search.add(1);
+      if (this.#input.sapName == "urlbar") {
+        Glean.urlbarUnifiedsearchbutton.picked.local_search.add(1);
+      }
     } else {
       console.warn(
         `Unexpected search: ${JSON.stringify({ engine, restrict, openEngineHomePage })}`