tor-browser

commit 30e0438d2ce8fdd56852a2a1c40518a95a8b3199
parent e8b4ffb19a9f88d5de17eeaaf8146eb86f1e4467
Author: Luca Greco <lgreco@mozilla.com>
Date:   Thu, 13 Nov 2025 20:33:34 +0000

Bug 1999947 - Fix frequent failures hit by test_ext_activityLog.js xpcshell test while xpcshell tests are executed in parallel. r=willdurand

Differential Revision: https://phabricator.services.mozilla.com/D272439

Diffstat:
M
toolkit/components/extensions/test/xpcshell/test_ext_activityLog.js
 | 
17
++++++++++-------

1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/toolkit/components/extensions/test/xpcshell/test_ext_activityLog.js b/toolkit/components/extensions/test/xpcshell/test_ext_activityLog.js
@@ -36,16 +36,15 @@ add_task(async function test_api_restricted() {
   await extension.unload();
 });
 
-// This test should produce a error and not startup
+// This test should produce a error and not installing nor starting
+// up the test extension.
 add_task(
   {
     // Some builds (e.g. thunderbird) have experiments enabled by default.
     pref_set: [["extensions.experiments.enabled", false]],
   },
   async function test_api_restricted_temporary_without_privilege() {
-    let extension = ExtensionTestUtils.loadExtension({
-      temporarilyInstalled: true,
-      isPrivileged: false,
+    let xpiFile = AddonTestUtils.createTempWebExtensionFile({
       manifest: {
         browser_specific_settings: {
           gecko: { id: "activityLog-permission@tests.mozilla.org" },
@@ -55,10 +54,13 @@ add_task(
     });
     ExtensionTestUtils.failOnSchemaWarnings(false);
     let { messages } = await promiseConsoleOutput(async () => {
+      const { AddonManager } = ChromeUtils.importESModule(
+        "resource://gre/modules/AddonManager.sys.mjs"
+      );
       await Assert.rejects(
-        extension.startup(),
-        /Using the privileged permission/,
-        "Startup failed with privileged permission"
+        AddonManager.installTemporaryAddon(xpiFile),
+        /Extension is invalid/,
+        "Install failed with privileged permission"
       );
     });
     ExtensionTestUtils.failOnSchemaWarnings(true);
@@ -74,5 +76,6 @@ add_task(
       },
       true
     );
+    xpiFile.remove(true);
   }
 );