commit 3060a6d00ca48713f19ec3a8900d44aad5df7f50
parent 6f626f7437a727412fb3934ea6d3ed454330f4d5
Author: Jon Oliver <jooliver@mozilla.com>
Date: Mon, 27 Oct 2025 19:01:48 +0000
Bug 1995876 - fix overrides in .stylelintrc.js r=frontend-codestyle-reviewers,Standard8
- Sets all design-token-rules-off rule values to null instead of false
- Sets all design-token-rules-on rule values to true instead of false
- Reorders the design-token overrides to come before the rollouts, so that the rollouts can correctly override the design-token rules
- Updates rollouts.config.js to include specific exclusions for files under devtools/client/aboutdebugging/src that are causing stylelint violations
Differential Revision: https://phabricator.services.mozilla.com/D269676
Diffstat:
2 files changed, 60 insertions(+), 15 deletions(-)
diff --git a/.stylelintrc.js b/.stylelintrc.js
@@ -282,7 +282,6 @@ module.exports = {
},
overrides: [
- ...rollouts,
{
files: "*.scss",
customSyntax: "postcss-scss",
@@ -419,15 +418,15 @@ module.exports = {
"browser/components/backup/content/archive.css",
],
rules: {
- "stylelint-plugin-mozilla/use-background-color-tokens": false,
- "stylelint-plugin-mozilla/use-border-color-tokens": false,
- "stylelint-plugin-mozilla/use-border-radius-tokens": false,
- "stylelint-plugin-mozilla/use-font-size-tokens": false,
- "stylelint-plugin-mozilla/use-font-weight-tokens": false,
- "stylelint-plugin-mozilla/use-space-tokens": false,
- "stylelint-plugin-mozilla/use-text-color-tokens": false,
- "stylelint-plugin-mozilla/use-box-shadow-tokens": false,
- "stylelint-plugin-mozilla/no-non-semantic-token-usage": false,
+ "stylelint-plugin-mozilla/use-background-color-tokens": null,
+ "stylelint-plugin-mozilla/use-border-color-tokens": null,
+ "stylelint-plugin-mozilla/use-border-radius-tokens": null,
+ "stylelint-plugin-mozilla/use-font-size-tokens": null,
+ "stylelint-plugin-mozilla/use-font-weight-tokens": null,
+ "stylelint-plugin-mozilla/use-space-tokens": null,
+ "stylelint-plugin-mozilla/use-text-color-tokens": null,
+ "stylelint-plugin-mozilla/use-box-shadow-tokens": null,
+ "stylelint-plugin-mozilla/no-non-semantic-token-usage": null,
},
},
{
@@ -437,12 +436,12 @@ module.exports = {
"devtools/client/aboutdebugging/src/**",
],
rules: {
- "stylelint-plugin-mozilla/use-background-color-tokens": false,
- "stylelint-plugin-mozilla/use-border-color-tokens": false,
+ "stylelint-plugin-mozilla/use-background-color-tokens": true,
+ "stylelint-plugin-mozilla/use-border-color-tokens": true,
"stylelint-plugin-mozilla/use-border-radius-tokens": true,
- "stylelint-plugin-mozilla/use-space-tokens": false,
- "stylelint-plugin-mozilla/use-text-color-tokens": false,
- "stylelint-plugin-mozilla/no-non-semantic-token-usage": false,
+ "stylelint-plugin-mozilla/use-space-tokens": true,
+ "stylelint-plugin-mozilla/use-text-color-tokens": true,
+ "stylelint-plugin-mozilla/no-non-semantic-token-usage": true,
},
},
{
@@ -451,5 +450,8 @@ module.exports = {
"stylelint-plugin-mozilla/no-browser-refs-in-toolkit": true,
},
},
+ // Rollouts should always be applied last in the overrides section
+ // to ensure that they take precedence over other overrides.
+ ...rollouts,
],
};
diff --git a/stylelint-rollouts.config.js b/stylelint-rollouts.config.js
@@ -218,6 +218,12 @@ module.exports = [
"browser/themes/windows/downloads/downloads.css",
"browser/themes/windows/places/organizer.css",
"browser/tools/mozscreenshots/mozscreenshots/extension/lib/mozscreenshots-style.css",
+ "devtools/client/aboutdebugging/src/base.css",
+ "devtools/client/aboutdebugging/src/components/connect/ConnectSection.css",
+ "devtools/client/aboutdebugging/src/components/connect/NetworkLocationsList.css",
+ "devtools/client/aboutdebugging/src/components/debugtarget/DebugTargetItem.css",
+ "devtools/client/aboutdebugging/src/components/debugtarget/FieldPair.css",
+ "devtools/client/aboutdebugging/src/components/shared/Message.css",
"docs/_static/custom_theme.css",
"dom/canvas/test/webgl-conf/iframe-passthrough.css",
"dom/crypto/test/test_WebCrypto.css",
@@ -788,6 +794,28 @@ module.exports = [
"browser/themes/windows/places/organizer.css",
"browser/themes/windows/sanitizeDialog.css",
"browser/tools/mozscreenshots/mozscreenshots/extension/lib/mozscreenshots-style.css",
+ "devtools/client/aboutdebugging/src/base.css",
+ "devtools/client/aboutdebugging/src/components/App.css",
+ "devtools/client/aboutdebugging/src/components/ProfilerDialog.css",
+ "devtools/client/aboutdebugging/src/components/RuntimeActions.css",
+ "devtools/client/aboutdebugging/src/components/RuntimeInfo.css",
+ "devtools/client/aboutdebugging/src/components/connect/ConnectPage.css",
+ "devtools/client/aboutdebugging/src/components/connect/ConnectSection.css",
+ "devtools/client/aboutdebugging/src/components/connect/ConnectSteps.css",
+ "devtools/client/aboutdebugging/src/components/connect/NetworkLocationsForm.css",
+ "devtools/client/aboutdebugging/src/components/connect/NetworkLocationsList.css",
+ "devtools/client/aboutdebugging/src/components/debugtarget/DebugTargetItem.css",
+ "devtools/client/aboutdebugging/src/components/debugtarget/DebugTargetList.css",
+ "devtools/client/aboutdebugging/src/components/debugtarget/DebugTargetPane.css",
+ "devtools/client/aboutdebugging/src/components/debugtarget/ExtensionDetail.css",
+ "devtools/client/aboutdebugging/src/components/debugtarget/FieldPair.css",
+ "devtools/client/aboutdebugging/src/components/debugtarget/ServiceWorkerAction.css",
+ "devtools/client/aboutdebugging/src/components/shared/IconLabel.css",
+ "devtools/client/aboutdebugging/src/components/shared/Message.css",
+ "devtools/client/aboutdebugging/src/components/sidebar/Sidebar.css",
+ "devtools/client/aboutdebugging/src/components/sidebar/SidebarFixedItem.css",
+ "devtools/client/aboutdebugging/src/components/sidebar/SidebarItem.css",
+ "devtools/client/aboutdebugging/src/components/sidebar/SidebarRuntimeItem.css",
"dom/crypto/test/test_WebCrypto.css",
"dom/events/test/pointerevents/wpt/pointerevent_styles.css",
"dom/tests/mochitest/webcomponents/inert_style.css",
@@ -1063,6 +1091,12 @@ module.exports = [
"browser/themes/windows/downloads/downloads.css",
"browser/themes/windows/places/organizer.css",
"browser/tools/mozscreenshots/mozscreenshots/extension/lib/mozscreenshots-style.css",
+ "devtools/client/aboutdebugging/src/base.css",
+ "devtools/client/aboutdebugging/src/components/ProfilerDialog.css",
+ "devtools/client/aboutdebugging/src/components/debugtarget/ExtensionDetail.css",
+ "devtools/client/aboutdebugging/src/components/debugtarget/ServiceWorkerAction.css",
+ "devtools/client/aboutdebugging/src/components/shared/Message.css",
+ "devtools/client/aboutdebugging/src/components/sidebar/SidebarItem.css",
"dom/base/test/file_bug498897.css",
"dom/crypto/test/test_WebCrypto.css",
"dom/events/test/pointerevents/wpt/pointerevent_styles.css",
@@ -1281,6 +1315,14 @@ module.exports = [
"browser/themes/windows/browser.css",
"browser/themes/windows/places/organizer.css",
"browser/tools/mozscreenshots/mozscreenshots/extension/lib/mozscreenshots-style.css",
+ "devtools/client/aboutdebugging/src/base.css",
+ "devtools/client/aboutdebugging/src/components/ProfilerDialog.css",
+ "devtools/client/aboutdebugging/src/components/connect/ConnectPage.css",
+ "devtools/client/aboutdebugging/src/components/debugtarget/DebugTargetItem.css",
+ "devtools/client/aboutdebugging/src/components/debugtarget/FieldPair.css",
+ "devtools/client/aboutdebugging/src/components/shared/Message.css",
+ "devtools/client/aboutdebugging/src/components/sidebar/Sidebar.css",
+ "devtools/client/aboutdebugging/src/components/sidebar/SidebarItem.css",
"dom/crypto/test/test_WebCrypto.css",
"dom/events/test/pointerevents/wpt/pointerevent_styles.css",
"dom/security/test/sri/style1.css",
@@ -1529,6 +1571,7 @@ module.exports = [
"browser/themes/shared/urlbar-searchbar.css",
"browser/themes/shared/urlbarView.css",
"browser/themes/windows/browser.css",
+ "devtools/client/aboutdebugging/src/base.css",
"toolkit/components/printing/content/toggle-group.css",
"toolkit/components/satchel/megalist/content/megalist.css",
"toolkit/content/aboutGlean.css",
