commit 2dde4490f02a911d8eb121ed443a474b41eb102c
parent d7940d930192abc51feb765e735c2fa060ff79ed
Author: Michael Froman <mfroman@mozilla.com>
Date: Thu, 9 Oct 2025 13:41:40 -0500
Bug 1993083 - Vendor libwebrtc from c2d1e495a9
Upstream commit: https://webrtc.googlesource.com/src/+/c2d1e495a9d637d693ee0315209445735a46c7d7
Remove deprecated functions from rtp_utils.h
This forces the use of ArrayView.
Bug: webrtc:42225170
Change-Id: I472a9fb48356e15f483257e8a7bc0ef16e4a89ac
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/399641
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Auto-Submit: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#45149}
Diffstat:
3 files changed, 3 insertions(+), 30 deletions(-)
diff --git a/third_party/libwebrtc/README.mozilla.last-vendor b/third_party/libwebrtc/README.mozilla.last-vendor
@@ -1,4 +1,4 @@
# ./mach python dom/media/webrtc/third_party_build/vendor-libwebrtc.py --from-local /home/mfroman/mozilla/elm/.moz-fast-forward/moz-libwebrtc --commit mozpatches libwebrtc
-libwebrtc updated from /home/mfroman/mozilla/elm/.moz-fast-forward/moz-libwebrtc commit mozpatches on 2025-10-09T18:40:23.469939+00:00.
+libwebrtc updated from /home/mfroman/mozilla/elm/.moz-fast-forward/moz-libwebrtc commit mozpatches on 2025-10-09T18:41:32.738763+00:00.
# base of lastest vendoring
-8ccd71dcb0
+c2d1e495a9
diff --git a/third_party/libwebrtc/media/base/rtp_utils.cc b/third_party/libwebrtc/media/base/rtp_utils.cc
@@ -184,13 +184,6 @@ RtpPacketType InferRtpPacketType(ArrayView<const uint8_t> packet) {
return RtpPacketType::kUnknown;
}
-bool ValidateRtpHeader(const uint8_t* rtp,
- size_t length,
- size_t* header_length) {
- return ValidateRtpHeader(ArrayView<const uint8_t>(rtp, length),
- header_length);
-}
-
bool ValidateRtpHeader(ArrayView<const uint8_t> rtp, size_t* header_length) {
size_t length = rtp.size();
if (header_length) {
@@ -358,16 +351,6 @@ bool UpdateRtpAbsSendTimeExtension(ArrayView<uint8_t> packet,
return found;
}
-bool ApplyPacketOptions(uint8_t* data,
- size_t length,
- const PacketTimeUpdateParams& packet_time_params,
- uint64_t time_us) {
- RTC_DCHECK(data);
- RTC_DCHECK(length);
- return ApplyPacketOptions(ArrayView<uint8_t>(data, length),
- packet_time_params, time_us);
-}
-
bool ApplyPacketOptions(ArrayView<uint8_t> data,
const PacketTimeUpdateParams& packet_time_params,
uint64_t time_us) {
diff --git a/third_party/libwebrtc/media/base/rtp_utils.h b/third_party/libwebrtc/media/base/rtp_utils.h
@@ -56,26 +56,16 @@ bool IsValidRtpPacketSize(RtpPacketType packet_type, size_t size);
absl::string_view RtpPacketTypeToString(RtpPacketType packet_type);
// Verifies that a packet has a valid RTP header.
-// TODO: issues.webrtc.org/42225170 - deprecate when Chrome does not use
-bool RTC_EXPORT ValidateRtpHeader(const uint8_t* rtp,
- size_t length,
- size_t* header_length);
bool RTC_EXPORT ValidateRtpHeader(ArrayView<const uint8_t> rtp,
size_t* header_length);
+// Helper method which updates the absolute send time extension if present.
bool UpdateRtpAbsSendTimeExtension(ArrayView<uint8_t> rtp,
int extension_id,
uint64_t time_us);
// Applies specified `options` to the packet. It updates the absolute send time
// extension header if it is present present then updates HMAC.
-
-// TODO: issues.webrtc.org/42225170 - deprecate when Chrome does not use
-bool RTC_EXPORT
-ApplyPacketOptions(uint8_t* data,
- size_t length,
- const PacketTimeUpdateParams& packet_time_params,
- uint64_t time_us);
bool RTC_EXPORT
ApplyPacketOptions(ArrayView<uint8_t> data,
const PacketTimeUpdateParams& packet_time_params,
