tor-browser

commit 2d5ba72330b951dcd0abe3aeddc29830b8d663cc
parent b46345848b7595fd42f7db5001be017ce9d5cdaf
Author: Mark Banner <standard8@mozilla.com>
Date:   Wed, 22 Oct 2025 13:23:01 +0000

Bug 1995587 - Remove setting urlbarDeferred on Urlbar events as the toolkit autocomplete-input is no longer used in the urlbar. r=urlbar-reviewers,dao

Differential Revision: https://phabricator.services.mozilla.com/D269426

Diffstat:
M
browser/components/urlbar/UrlbarEventBufferer.sys.mjs
 | 
9
+--------
M
toolkit/content/widgets/autocomplete-input.js
 | 
3
+--

2 files changed, 2 insertions(+), 10 deletions(-)
diff --git a/browser/components/urlbar/UrlbarEventBufferer.sys.mjs b/browser/components/urlbar/UrlbarEventBufferer.sys.mjs
@@ -160,18 +160,11 @@ export class UrlbarEventBufferer {
    *        the event.
    */
   deferEvent(event, callback) {
-    // TODO Bug 1536822: once one-off buttons are implemented, figure out if the
-    // following is true for the quantum bar as well: somehow event.defaultPrevented
-    // ends up true for deferred events.  Autocomplete ignores defaultPrevented
-    // events, which means it would ignore replayed deferred events if we didn't
-    // tell it to bypass defaultPrevented through urlbarDeferred.
     // Check we don't try to defer events more than once.
-    if (event.urlbarDeferred) {
+    if (this.#eventsQueue.find(item => item.event == event)) {
       throw new Error(`Event ${event.type}:${event.keyCode} already deferred!`);
     }
     lazy.logger.debug(`Deferring ${event.type}:${event.keyCode} event`);
-    // Mark the event as deferred.
-    event.urlbarDeferred = true;
     // Also store the current search string, as an added safety check. If the
     // string will differ later, the event is stale and should be dropped.
     event.searchString = this.#lastQuery.context.searchString;
diff --git a/toolkit/content/widgets/autocomplete-input.js b/toolkit/content/widgets/autocomplete-input.js
@@ -457,8 +457,7 @@
     }
 
     handleKeyDown(aEvent) {
-      // Re: urlbarDeferred, see the comment in urlbarBindings.xml.
-      if (aEvent.defaultPrevented && !aEvent.urlbarDeferred) {
+      if (aEvent.defaultPrevented) {
         return false;
       }