commit 2619342232a6b718fe22d3dc365cad309efa61a2 parent a7968b10d6ab9a6b6f482be44dd1c58a7a2a2f37 Author: Cristina Horotan <chorotan@mozilla.com> Date: Thu, 9 Oct 2025 03:27:06 +0300 Revert "Bug 1954427, Bug 1974686, Bug 1973976, Bug 1936429, 1898895, Bug 1873166, Bug 1993201 - add an Android-only UA override for eolno.nokas.com to get their mobile layout; r=webcompat-reviewers,ksenia" for causing bc failures on browser_parsable_css.js This reverts commit 4fe8c4e9ffe2ad25bd7278dcf4159aa3567cd6be. Revert "Bug 1974686 - add a CSS webcompat intervention for www.hermes.admin.ch; r=webcompat-reviewers,ksenia" This reverts commit 813b75b82462b89abc58dbc251c2b553fb8282d1. Revert "Bug 1973976 - add a CSS webcompat intervention for iweather.gov.vn; r=webcompat-reviewers,ksenia" This reverts commit 7d589adb41574ddc83eef54a982c53aff8c52175. Revert "Bug 1936429 - add a CSS intervention for diadora.com to hide extra scrollbars; r=webcompat-reviewers,ksenia" This reverts commit 0dd03dceb8a1fcc0f584acad0fa0348122af3c63. Revert "Bug 1898895 - add an Android-only UA override for eslatam.trygalaxy.com; r=webcompat-reviewers,ksenia" This reverts commit ea18f3782f55eb028c944684f0f0d439f4d52304. Revert "Bug 1873166 - update our webcompat intervention for nsandi.com; r=webcompat-reviewers,ksenia" This reverts commit 81a22c8a57e5df0ec64f525ccaa9775d57dc334b. Revert "Bug 1993201 - add a UA override for portal.pilot.ly; r=webcompat-reviewers,ksenia" This reverts commit 15b052cacc1b0547649881fa45b908fade8a38ed. Diffstat:
13 files changed, 5 insertions(+), 351 deletions(-)
diff --git a/browser/extensions/webcompat/data/interventions.json b/browser/extensions/webcompat/data/interventions.json @@ -2028,21 +2028,6 @@ } ] }, - "1898895": { - "label": "eslatam.trygalaxy.com", - "bugs": { - "1898895": { - "issue": "firefox-blocked-completely", - "matches": ["*://eslatam.trygalaxy.com/*"] - } - }, - "interventions": [ - { - "platforms": ["android"], - "ua_string": ["Chrome_with_FxQuantum"] - } - ] - }, "1898904": { "label": "indigo.shireburn.com", "bugs": { @@ -4085,23 +4070,6 @@ } ] }, - "1936429": { - "label": "diadora.com", - "bugs": { - "1936429": { - "issue": "extra-scrollbars", - "matches": ["*://www.diadora.com/*"] - } - }, - "interventions": [ - { - "platforms": ["all"], - "content_scripts": { - "css": ["bug1936429-diadora.com-fix-doubled-scrollbars.css"] - } - } - ] - }, "1939248": { "label": "rosasthai.com", "bugs": { @@ -4628,21 +4596,6 @@ } ] }, - "1954427": { - "label": "eolno.nokas.com", - "bugs": { - "1954427": { - "issue": "desktop-layout-not-mobile", - "matches": ["*://eolno.nokas.com/*"] - } - }, - "interventions": [ - { - "platforms": ["android"], - "ua_string": ["Chrome_with_FxQuantum"] - } - ] - }, "1955529": { "label": "kancelaria.kros.sk", "bugs": { @@ -5240,43 +5193,6 @@ } ] }, - "1973976": { - "label": "iweather.gov.vn", - "bugs": { - "1973976": { - "issue": "broken-layout", - "matches": ["*://iweather.gov.vn/*"] - } - }, - "interventions": [ - { - "platforms": ["all"], - "pref_check": { "layout.css.webkit-fill-available.enabled": false }, - "content_scripts": { - "css": ["bug1973976-iweather.gov.vn-fix-narrow-interface.css"] - } - } - ] - }, - "1974686": { - "label": "hermes.admin.ch", - "bugs": { - "1974686": { - "issue": "broken-layout", - "matches": [ - "*://www.hermes.admin.ch/de/projektmanagement/szenarien/it-entwicklung/szenariouebersicht.html*" - ] - } - }, - "interventions": [ - { - "platforms": ["all"], - "content_scripts": { - "css": ["bug1974686-hermes_admin_ch.css"] - } - } - ] - }, "1976402": { "label": "dieseldispatch.com", "bugs": { @@ -5516,20 +5432,5 @@ "ua_string": ["add_Chrome"] } ] - }, - "1993201": { - "label": "portal.pilot.ly", - "bugs": { - "1993201": { - "issue": "firefox-blocked-completely", - "matches": ["*://portal.pilot.ly/*"] - } - }, - "interventions": [ - { - "platforms": ["all"], - "ua_string": ["add_Chrome"] - } - ] } } diff --git a/browser/extensions/webcompat/injections/css/bug1873166-nsandi.com-hide-unsupported-message.css b/browser/extensions/webcompat/injections/css/bug1873166-nsandi.com-hide-unsupported-message.css @@ -13,7 +13,6 @@ * yet the message remains. This intervention hides that message. */ .browser-warning-fade, -#unsupported-browser, #unsupported_browser { display: none !important; } diff --git a/browser/extensions/webcompat/injections/css/bug1936429-diadora.com-fix-doubled-scrollbars.css b/browser/extensions/webcompat/injections/css/bug1936429-diadora.com-fix-doubled-scrollbars.css @@ -1,19 +0,0 @@ -/* This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ - -/** - * diadora.com - doubled scrollbars on the site's page selector. - * - * Bug #1936429 - https://bugzilla.mozilla.org/show_bug.cgi?id=1936429 - * - * The site uses -webkit-scrollbar to hide extra scrollbars, rather than the - * standard CSS to do that. We can do it for them to improve UX on the site. - */ -.select2-results { - scrollbar-width: none; -} -.select2-container--default .select2-results > .select2-results__options { - scrollbar-width: thin; - overflow-x: none; -} diff --git a/browser/extensions/webcompat/injections/css/bug1973976-iweather.gov.vn-fix-narrow-interface.css b/browser/extensions/webcompat/injections/css/bug1973976-iweather.gov.vn-fix-narrow-interface.css @@ -1,14 +0,0 @@ -/* This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ - -/** - * iweather.gov.vn - the bottom map interface does not stretch to fill width - * Bug #1973976 - https://bugzilla.mozilla.org/show_bug.cgi?id=1973976 - * - * The page uses the non-standard webkit-fill-available, which we can - * correct by also adding -moz-available. - */ -.w-mc { - width: -moz-available; -} diff --git a/browser/extensions/webcompat/injections/css/bug1974686-hermes_admin_ch.css b/browser/extensions/webcompat/injections/css/bug1974686-hermes_admin_ch.css @@ -1,17 +0,0 @@ -/* This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ - -/** - * hermes.admin.ch - table cells overlap - * Bug #1974686 - https://bugzilla.mozilla.org/show_bug.cgi?id=1974686 - * - * The page sets a 1px height on its table cells, which has interop issues. - * We can unset that and adjust their other CSS to improve the situation. - */ -.hermespjm-projektuebersicht-row { - height: unset; -} -.hermespjm-projektuebersicht-cell-verantwortlicher { - position: static; -} diff --git a/browser/extensions/webcompat/manifest.json b/browser/extensions/webcompat/manifest.json @@ -2,7 +2,7 @@ "manifest_version": 2, "name": "Web Compatibility Interventions", "description": "Urgent post-release fixes for web compatibility.", - "version": "145.8.0", + "version": "145.7.0", "browser_specific_settings": { "gecko": { "id": "webcompat@mozilla.org", diff --git a/testing/webcompat/interventions/tests/test_1873166_108319_www_nsandi_com.py b/testing/webcompat/interventions/tests/test_1873166_108319_www_nsandi_com.py @@ -3,20 +3,21 @@ import pytest URL = "https://www.nsandi.com/" CHAT_BUTTON_CSS = "#GCLauncherbtn" -UNSUPPORTED_TEXT = "Chrome or Safari" +UNSUPPORTED_CSS = "#unsupported-browser" async def is_warning_shown(client): await client.navigate(URL) client.await_css(CHAT_BUTTON_CSS, is_displayed=True) - return client.find_text(UNSUPPORTED_TEXT, is_displayed=True) + client.await_css(UNSUPPORTED_CSS) + return client.find_css(UNSUPPORTED_CSS, is_displayed=True) @pytest.mark.only_platforms("android") @pytest.mark.asyncio @pytest.mark.with_interventions async def test_enabled(client): - assert not await is_warning_shown(client) + assert await is_warning_shown(client) @pytest.mark.only_platforms("android") diff --git a/testing/webcompat/interventions/tests/test_1898895_eslatam_trygalaxy_com.py b/testing/webcompat/interventions/tests/test_1898895_eslatam_trygalaxy_com.py @@ -1,24 +0,0 @@ -import pytest - -URL = "https://eslatam.trygalaxy.com/" - -SUPPORTED_CSS = "video" -UNSUPPORTED_TEXT = "Samsung Internet y Chrome" - - -@pytest.mark.only_platforms("android") -@pytest.mark.asyncio -@pytest.mark.with_interventions -async def test_enabled(client): - await client.navigate(URL, wait="none") - assert client.await_css(SUPPORTED_CSS, is_displayed=True) - assert not client.find_text(UNSUPPORTED_TEXT, is_displayed=True) - - -@pytest.mark.only_platforms("android") -@pytest.mark.asyncio -@pytest.mark.without_interventions -async def test_disabled(client): - await client.navigate(URL, wait="none") - assert client.await_text(UNSUPPORTED_TEXT, is_displayed=True) - assert not client.find_css(SUPPORTED_CSS, is_displayed=True) diff --git a/testing/webcompat/interventions/tests/test_1936429_diadora_com.py b/testing/webcompat/interventions/tests/test_1936429_diadora_com.py @@ -1,38 +0,0 @@ -import pytest - -URL = "https://www.diadora.com/en/us/men/?srule=sorting-in-season&prefn1=descrizioneCategoriaMerceologica&prefv1=Shoes" - -POPUPS_CSS = "#CybotCookiebotDialog, #CybotCookiebotDialog *, #modal-geolocation-change, #modal-geolocation-change *, .modal-backdrop, .modal-backdrop *" -SELECT_CSS = ".paginationNumbers .select2.select2-container" -CONTAINER_CSS = ".select2-results" - - -async def get_container_width_difference(client): - await client.navigate(URL, wait="none") - client.hide_elements(POPUPS_CSS) - client.click(client.await_css(SELECT_CSS, is_displayed=True)) - container = client.await_css(CONTAINER_CSS) - return client.execute_script( - """ - return arguments[0].getBoundingClientRect().width - arguments[0].firstChild.getBoundingClientRect().width; - """, - container, - ) - - -@pytest.mark.skip_platforms("android") -@pytest.mark.need_visible_scrollbars -@pytest.mark.asyncio -@pytest.mark.with_interventions -async def test_enabled(client): - # the site applies 10px of padding to the scrollable area. - assert 10 == await get_container_width_difference(client) - - -@pytest.mark.skip_platforms("android") -@pytest.mark.need_visible_scrollbars -@pytest.mark.asyncio -@pytest.mark.without_interventions -async def test_disabled(client): - # the inner container will be more than 10px smaller if there is an extra scrollbar. - assert 10 < await get_container_width_difference(client) diff --git a/testing/webcompat/interventions/tests/test_1954427_eolno_nokas_com.py b/testing/webcompat/interventions/tests/test_1954427_eolno_nokas_com.py @@ -1,23 +0,0 @@ -import pytest - -URL = "https://eolno.nokas.com/EmployeeOnlineHealth/NOLIVE/Login" -DESKTOP_CSS = "html:not([ng-app='employeeonline.mobile.core'])" -MOBILE_CSS = "html[ng-app='employeeonline.mobile.core']" - - -@pytest.mark.only_platforms("android") -@pytest.mark.asyncio -@pytest.mark.with_interventions -async def test_enabled(client): - await client.navigate(URL, wait="none") - assert client.await_css(MOBILE_CSS, is_displayed=True) - assert not client.find_css(DESKTOP_CSS, is_displayed=True) - - -@pytest.mark.only_platforms("android") -@pytest.mark.asyncio -@pytest.mark.without_interventions -async def test_disabled(client): - await client.navigate(URL, wait="none") - assert client.await_css(DESKTOP_CSS, is_displayed=True) - assert not client.find_css(MOBILE_CSS, is_displayed=True) diff --git a/testing/webcompat/interventions/tests/test_1973976_iweather_gov_vn.py b/testing/webcompat/interventions/tests/test_1973976_iweather_gov_vn.py @@ -1,39 +0,0 @@ -import pytest - -URL = "https://iweather.gov.vn/dashboard/?areaRadar=COM&productRadar=CMAX" - -MAP_CSS = "#map" -ASIDE_CSS = "aside.fixed" -BOTTOM_BAR_CSS = ".w-mc.transition-all" - - -async def is_bottom_bar_full_width(client, platform): - await client.navigate(URL, wait="none") - client.add_stylesheet(f"{BOTTOM_BAR_CSS} {{ transition-duration:0s !important; }}") - map = client.await_css(MAP_CSS, is_displayed=True) - aside = client.await_css(ASIDE_CSS, is_displayed=True) - bottom_bar = client.await_css(BOTTOM_BAR_CSS, is_displayed=True) - return client.execute_script( - """ - const [ bottom_bar, map, aside, android ] = arguments; - return bottom_bar.clientWidth == map.clientWidth - (android ? 0 : aside.clientWidth); - """, - bottom_bar, - map, - aside, - platform == "android", - ) - - -@pytest.mark.enable_webkit_fill_available -@pytest.mark.asyncio -@pytest.mark.with_interventions -async def test_enabled(client, platform): - assert await is_bottom_bar_full_width(client, platform) - - -@pytest.mark.disable_webkit_fill_available -@pytest.mark.asyncio -@pytest.mark.without_interventions -async def test_disabled(client, platform): - assert not await is_bottom_bar_full_width(client, platform) diff --git a/testing/webcompat/interventions/tests/test_1974686_hermes_admin_ch.py b/testing/webcompat/interventions/tests/test_1974686_hermes_admin_ch.py @@ -1,34 +0,0 @@ -import pytest - -URL = "https://www.hermes.admin.ch/de/projektmanagement/szenarien/it-entwicklung/szenariouebersicht.html" - -CELLS_CSS = ".hermespjm-projektuebersicht-cell" - - -async def are_table_cells_collapsed(client): - await client.navigate(URL, wait="none") - client.await_css(CELLS_CSS, is_displayed=True) - return client.execute_script( - """ - const cells = document.querySelectorAll(arguments[0]); - for (const cell of cells) { - if (cell.clientHeight < cell.scrollHeight) { - return true; - } - } - return false; - """, - CELLS_CSS, - ) - - -@pytest.mark.asyncio -@pytest.mark.with_interventions -async def test_enabled(client): - assert not await are_table_cells_collapsed(client) - - -@pytest.mark.asyncio -@pytest.mark.without_interventions -async def test_disabled(client): - assert await are_table_cells_collapsed(client) diff --git a/testing/webcompat/interventions/tests/test_1993201_portal_pilot_ly.py b/testing/webcompat/interventions/tests/test_1993201_portal_pilot_ly.py @@ -1,39 +0,0 @@ -import pytest - -URL = "https://previewinsights.qualtrics.com/jfe/form/SV_a5Gnoq0OsdUzvGm?Q_DL=hq7SUdQWjweSxhT_a5Gnoq0OsdUzvGm_CGC_DNCiEfKhsuDlymq&Q_CHL=email" - -WATCH_NOW_CSS = "a[href*='portal.pilot.ly/process-target']" -AVANTI_CSS = "button.begin-registration" -SUPPORTED_CSS = "#root .pilotly-player" -UNSUPPORTED_TEXT1 = "Firefox not supported" -UNSUPPORTED_TEXT2 = "Google Chrome" - - -async def get_to_page(client): - await client.navigate(URL, wait="none") - client.soft_click(client.await_css(WATCH_NOW_CSS, is_displayed=True)) - client.soft_click(client.await_css(AVANTI_CSS, is_displayed=True)) - - -@pytest.mark.asyncio -@pytest.mark.with_interventions -async def test_enabled(client): - await get_to_page(client) - assert client.await_css(SUPPORTED_CSS, is_displayed=True) - assert not client.find_text(UNSUPPORTED_TEXT2, is_displayed=True) - assert not client.find_text(UNSUPPORTED_TEXT2, is_displayed=True) - - -@pytest.mark.asyncio -@pytest.mark.without_interventions -async def test_disabled(client): - await get_to_page(client) - no_firefox, use_chrome = client.await_first_element_of( - [ - client.text(UNSUPPORTED_TEXT1), - client.text(UNSUPPORTED_TEXT2), - ], - is_displayed=True, - ) - assert no_firefox or use_chrome - assert not client.find_css(SUPPORTED_CSS, is_displayed=True)