tor-browser

commit 227dac704c555c42de3700ca5096bf5cacb6df93
parent 9d81115cc1a202769a482c841f008e88ef8ab39d
Author: Dão Gottwald <dao@mozilla.com>
Date:   Thu,  8 Jan 2026 15:41:53 +0000

Bug 2007392 - Shift+Click on a search engine should not enter search mode. r=daleharvey

Differential Revision: https://phabricator.services.mozilla.com/D278122

Diffstat:
M
browser/components/urlbar/SearchModeSwitcher.sys.mjs
 | 
9
++-------
M
browser/components/urlbar/tests/browser/browser_searchModeSwitcher_basic.js
 | 
3
+--

2 files changed, 3 insertions(+), 9 deletions(-)
diff --git a/browser/components/urlbar/SearchModeSwitcher.sys.mjs b/browser/components/urlbar/SearchModeSwitcher.sys.mjs
@@ -504,16 +504,11 @@ export class SearchModeSwitcher {
     }
 
     if (openEngineHomePage) {
-      opts.focus = false;
-      opts.startQuery = false;
-    }
-
-    this.#input.search(search, opts);
-
-    if (openEngineHomePage) {
       this.#input.openEngineHomePage(search, {
         searchEngine: opts.searchEngine,
       });
+    } else {
+      this.#input.search(search, opts);
     }
 
     this.#popup.hidePopup();
diff --git a/browser/components/urlbar/tests/browser/browser_searchModeSwitcher_basic.js b/browser/components/urlbar/tests/browser/browser_searchModeSwitcher_basic.js
@@ -477,11 +477,10 @@ add_task(async function open_engine_page_directly() {
     }
 
     await popupHidden;
+    await UrlbarTestUtils.assertSearchMode(newWin, null);
     await pageLoaded;
     Assert.ok(true, "The popup was hidden and expected page was loaded");
 
-    await UrlbarTestUtils.assertSearchMode(newWin, null);
-
     // Cleanup.
     await PlacesUtils.history.clear();
     await searchExtension.unload();