tor-browser

commit 226801fee23910100c1603c5cc0de6d3a70bbc4e
parent 26b091836767418adf514f78e9ce2860874be2fe
Author: Karl Tomlinson <karlt+@karlt.net>
Date:   Thu, 23 Oct 2025 08:29:57 +0000

Bug 1985195 Remove OfflineClockDriver aSlice parameter r=pehrsons

Callers had no reason to provide a specific value and the parameter and
member types were misleading.

Differential Revision: https://phabricator.services.mozilla.com/D269557

Diffstat:
M
dom/media/GraphDriver.cpp
 | 
6
+++---
M
dom/media/GraphDriver.h
 | 
7
+------
M
dom/media/MediaTrackGraph.cpp
 | 
3
+--

3 files changed, 5 insertions(+), 11 deletions(-)
diff --git a/dom/media/GraphDriver.cpp b/dom/media/GraphDriver.cpp
@@ -261,8 +261,8 @@ TimeDuration SystemClockDriver::NextIterationWaitDuration() {
 }
 
 OfflineClockDriver::OfflineClockDriver(GraphInterface* aGraphInterface,
-                                       uint32_t aSampleRate, GraphTime aSlice)
-    : ThreadedDriver(aGraphInterface, nullptr, aSampleRate), mSlice(aSlice) {}
+                                       uint32_t aSampleRate)
+    : ThreadedDriver(aGraphInterface, nullptr, aSampleRate) {}
 
 OfflineClockDriver::~OfflineClockDriver() = default;
 
@@ -276,7 +276,7 @@ void OfflineClockDriver::RunThread() {
 
 MediaTime OfflineClockDriver::GetIntervalForIteration() {
   return MediaTrackGraphImpl::RoundUpToEndOfAudioBlock(
-      MillisecondsToMediaTime(mSlice));
+      MillisecondsToMediaTime(MEDIA_GRAPH_TARGET_PERIOD_MS));
 }
 
 /* Helper to proxy the GraphInterface methods used by a running
diff --git a/dom/media/GraphDriver.h b/dom/media/GraphDriver.h
@@ -511,8 +511,7 @@ class SystemClockDriver final : public ThreadedDriver {
  */
 class OfflineClockDriver final : public ThreadedDriver {
  public:
-  OfflineClockDriver(GraphInterface* aGraphInterface, uint32_t aSampleRate,
-                     GraphTime aSlice);
+  OfflineClockDriver(GraphInterface* aGraphInterface, uint32_t aSampleRate);
   virtual ~OfflineClockDriver();
   OfflineClockDriver* AsOfflineClockDriver() override { return this; }
   const OfflineClockDriver* AsOfflineClockDriver() const override {
@@ -524,10 +523,6 @@ class OfflineClockDriver final : public ThreadedDriver {
  protected:
   TimeDuration NextIterationWaitDuration() override { return TimeDuration(); }
   MediaTime GetIntervalForIteration() override;
-
- private:
-  // Time, in GraphTime, for each iteration
-  GraphTime mSlice;
 };
 
 enum class AudioInputType { Unknown, Voice };
diff --git a/dom/media/MediaTrackGraph.cpp b/dom/media/MediaTrackGraph.cpp
@@ -3508,8 +3508,7 @@ void MediaTrackGraphImpl::Init(GraphDriverType aDriverRequested,
     LOG(LogLevel::Debug, ("%p: document title: %s", this, streamName.get()));
     mDriver->SetStreamName(streamName);
   } else {
-    mDriver =
-        new OfflineClockDriver(this, mSampleRate, MEDIA_GRAPH_TARGET_PERIOD_MS);
+    mDriver = new OfflineClockDriver(this, mSampleRate);
   }
 
   mLastMainThreadUpdate = TimeStamp::Now();