commit 1cafe7d74c5b8bf4ab87138f80a3111c1f8caed7
parent be832713470b14b35ff01d189baf7d0079cdcf71
Author: agoloman <agoloman@mozilla.com>
Date: Thu, 8 Jan 2026 17:31:35 +0200
Revert "Bug 2001938 - Shortcut keys in combination with modifier should create UA r=edgar" for causing mda failures @test_autoplay_policy_key_blacklist.html.
This reverts commit f88d481b81078d7e8ce07d099579c2449f3759a7.
Diffstat:
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/dom/base/test/useractivation/browser_useractivation_key_events.js b/dom/base/test/useractivation/browser_useractivation_key_events.js
@@ -68,8 +68,8 @@ add_task(async function TestPrintableKey() {
add_task(async function TestNonPrintableKey() {
let tests = [
["KEY_Backspace", false],
- ["KEY_Control", true],
- ["KEY_Shift", true],
+ ["KEY_Control", false],
+ ["KEY_Shift", false],
["KEY_Escape", false],
// Treat as user input
["KEY_Tab", true],
diff --git a/widget/TextEvents.h b/widget/TextEvents.h
@@ -310,6 +310,10 @@ class WidgetKeyboardEvent final : public WidgetInputEvent {
}
bool CanUserGestureActivateTarget() const {
+ if (IsModifierKeyEvent()) {
+ return false;
+ }
+
if (mFlags.mIsShortcutKey) {
// Space is quite common shortcut for playing media.
return mKeyCode == NS_VK_SPACE ||