commit 1ab4eda073ef8f2a563282895c3291ada1fc756d parent 74baaef7d6d09ccca671ffb226fd0c5f8a9653c5 Author: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> Date: Thu, 6 Nov 2025 21:36:36 +0000 Bug 1997946 [wpt PR 55826] - Revert "Fix border-shape painting", a=testonly Automatic update from web-platform-tests Revert "Fix border-shape painting" This reverts commit b574b7f4b2336830564c5579cf45208a883dff56. Reason for revert: LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5407268251107328 Sample build with failed test: https://ci.chromium.org/b/8699219734605948417 Affected test(s): [ninja://third_party/blink/renderer/controller:blink_unittests/BlockLayoutAlgorithmTest.HandleTextControlPlaceholderCrash](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fthird_party%2Fblink%2Frenderer%2Fcontroller:blink_unittests%2FBlockLayoutAlgorithmTest.HandleTextControlPlaceholderCrash?q=VHash%3A9870520eab331a24) [ninja://third_party/blink/renderer/controller:blink_unittests/ElementInnerTest.FirstLineWithTextTransform](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fthird_party%2Fblink%2Frenderer%2Fcontroller:blink_unittests%2FElementInnerTest.FirstLineWithTextTransform?q=VHash%3A9870520eab331a24) [ninja://third_party/blink/renderer/controller:blink_unittests/ElementRuleCollectorTest.FirstLineUseCounted](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fthird_party%2Fblink%2Frenderer%2Fcontroller:blink_unittests%2FElementRuleCollectorTest.FirstLineUseCounted?q=VHash%3A9870520eab331a24) [ninja://third_party/blink/renderer/controller:blink_unittests/InlineLayoutAlgorithmTest.TypesForFirstLine](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fthird_party%2Fblink%2Frenderer%2Fcontroller:blink_unittests%2FInlineLayoutAlgorithmTest.TypesForFirstLine?q=VHash%3A9870520eab331a24) [ninja://third_party/blink/renderer/controller:blink_unittests/LayoutObjectSimTest.FirstLineBackgroundImageDirtyStyleCrash](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fthird_party%2Fblink%2Frenderer%2Fcontroller:blink_unittests%2FLayoutObjectSimTest.FirstLineBackgroundImageDirtyStyleCrash?q=VHash%3A9870520eab331a24) and 7 more ... If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5407268251107328&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7101318&type=BUG Original change's description: > Fix border-shape painting > > For painting we should use outer path without a stroke data applied. > > Also, this CL fixes which geometry box is used for shadow painting. > > Bug: 448653232 > Change-Id: Ic82dbd1a6f3406d19934c30369a8038a11844002 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7101318 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1539255} > Bug: 448653232 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I7703d1acd65dfd4d15c2cc6a3de510186382adc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7112220 Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Owners-Override: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#1539384} -- wpt-commits: 7a362cccd5106e5e6500178411e28495f33c8005 wpt-pr: 55826 Diffstat:
7 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/testing/web-platform/tests/css/css-borders/border-shape-absolute-coords-shape-ref.tentative.html b/testing/web-platform/tests/css/css-borders/border-shape-absolute-coords-shape-ref.tentative.html @@ -8,11 +8,11 @@ height: 200px; overflow: visible; stroke: purple; - stroke-width: 10px; - border: 5px solid transparent; + stroke-width: 20px; fill: green; + border: 20px solid transparent; } </style> <svg viewBox="0 0 200 200" xmlns="http://www.w3.org/2000/svg"> - <polygon points="0,0 200,0, 100,200" /> + <polygon points="6,0 194,0, 100,188" /> </svg> diff --git a/testing/web-platform/tests/css/css-borders/border-shape-absolute-coords-shape.tentative.html b/testing/web-platform/tests/css/css-borders/border-shape-absolute-coords-shape.tentative.html @@ -3,15 +3,16 @@ <link rel="help" href="https://www.w3.org/TR/css-borders-4/#propdef-border-shape"> <link rel="help" href="https://drafts.csswg.org/css-shapes-1/#shape-function"> <link rel="match" href="border-shape-absolute-coords-shape-ref.tentative.html"> +<meta name="fuzzy" content="maxDifference=0-70;totalPixels=0-1200"> <style> .bs-target { position: absolute; top: 200px; - left: 0px; - width: 190px; - height: 190px; + left: 0; + width: 200px; + height: 200px; border-shape: shape(from 0% 0%, line to 100% 0%, line to 50% 100%, close); - border: 10px solid purple; + border: 20px solid purple; background: green; } </style> diff --git a/testing/web-platform/tests/css/css-borders/tentative/border-shape/border-shape-clips-background-ref.html b/testing/web-platform/tests/css/css-borders/tentative/border-shape/border-shape-clips-background-ref.html @@ -15,5 +15,5 @@ circle { } </style> <svg viewBox="0 0 100 100" xmlns="http://www.w3.org/2000/svg"> - <circle cx="50" cy="50" r="55" /> + <circle cx="50" cy="50" r="50" /> </svg> diff --git a/testing/web-platform/tests/css/css-borders/tentative/border-shape/border-shape-clips-background.html b/testing/web-platform/tests/css/css-borders/tentative/border-shape/border-shape-clips-background.html @@ -1,6 +1,7 @@ <!DOCTYPE html> <link rel="help" href="https://drafts.csswg.org/css-borders-4/#border-shape"> <link rel="match" href="border-shape-clips-background-ref.html"> +<meta name="fuzzy" content="maxDifference=0-110;totalPixels=0-200"> <style> #target { width: 100px; diff --git a/testing/web-platform/tests/css/css-borders/tentative/border-shape/border-shape-shadow-ref.html b/testing/web-platform/tests/css/css-borders/tentative/border-shape/border-shape-shadow-ref.html @@ -8,19 +8,17 @@ width: 200px; height: 200px; overflow: visible; - border: 5px solid transparent; + border: 2px solid transparent; } .shadow { fill: purple; transform: translate(10px, 20px); - stroke: purple; - stroke-width: 10px; } .target { fill: green; stroke: black; - stroke-width: 10px; + stroke-width: 2px; } </style> diff --git a/testing/web-platform/tests/css/css-borders/tentative/border-shape/border-shape-shadow.html b/testing/web-platform/tests/css/css-borders/tentative/border-shape/border-shape-shadow.html @@ -1,19 +1,19 @@ <!DOCTYPE html> <link rel="help" href="https://drafts.csswg.org/css-borders-4/#border-shape"> <link rel="match" href="border-shape-shadow-ref.html"> -<meta name="fuzzy" content="maxDifference=0-80;totalPixels=0-450"> +<meta name="fuzzy" content="maxDifference=0-110;totalPixels=0-2500"> <style> body { margin: 0; } #target { - width: 190px; - height: 190px; + width: 200px; + height: 200px; border-shape: polygon(50% 0, 100% 50%, 50% 100%, 0 50%); position: relative; background: green; box-shadow: 10px 20px 0 0px purple; - border: 10px solid black; + border: 2px solid black; } </style> <div id="target"> diff --git a/testing/web-platform/tests/css/css-borders/tentative/border-shape/border-shape-stroke-from-border-ref.html b/testing/web-platform/tests/css/css-borders/tentative/border-shape/border-shape-stroke-from-border-ref.html @@ -42,16 +42,16 @@ body { </style> <div class="container"> <svg class="target case1" viewBox="0 0 120 120"> - <circle cx="59" cy="51" r="45" fill="none" stroke="rgb(220, 0, 0)" stroke-width="18"/> + <circle cx="59" cy="51" r="36" fill="none" stroke="rgb(220, 0, 0)" stroke-width="18"/> </svg> <svg class="target case2" viewBox="0 0 120 120"> - <circle cx="59" cy="51" r="45" fill="none" stroke="rgb(0, 0, 220)" stroke-width="6"/> + <circle cx="59" cy="51" r="42" fill="none" stroke="rgb(0, 0, 220)" stroke-width="6"/> </svg> <svg class="target case3" viewBox="0 0 120 120"> - <circle cx="65" cy="51" r="45" fill="none" stroke="rgb(220, 0, 0)" stroke-width="18"/> + <circle cx="65" cy="51" r="36" fill="none" stroke="rgb(220, 0, 0)" stroke-width="18"/> </svg> <svg class="target case4" viewBox="0 0 120 120"> - <circle cx="65" cy="51" r="45" fill="none" stroke="rgb(0, 140, 0)" stroke-width="10"/> + <circle cx="65" cy="51" r="40" fill="none" stroke="rgb(0, 140, 0)" stroke-width="10"/> </svg> </div> <div class="container">