commit 19558a1abfe8ab68cb02e909fa36497e3793630f
parent 79aea563439685c5d6b193685ee20ced7e15324e
Author: Alvin Ji <alvinji@chromium.org>
Date: Thu, 9 Oct 2025 20:38:43 +0000
Bug 1992497 [wpt PR 55241] - geolocation: Fix permission policy wpt test, a=testonly
Automatic update from web-platform-tests
geolocation: Fix permission policy wpt test
The two geolocation permission policy tests were timeout because there
is no default position is set. This CL fix it by using bidi to set
default position.
Change-Id: Idcd939df64b82faaffbc15832859035d16db940f
Bug: 347055177
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7006327
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Commit-Queue: Alvin Ji <alvinji@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1524990}
--
wpt-commits: 5edab91a38cc73542d3a7fe112263beb07f36c39
wpt-pr: 55241
Diffstat:
2 files changed, 55 insertions(+), 5 deletions(-)
diff --git a/testing/web-platform/tests/geolocation/enabled-by-permissions-policy.https.sub.html b/testing/web-platform/tests/geolocation/enabled-by-permissions-policy.https.sub.html
@@ -1,9 +1,9 @@
<!DOCTYPE html>
-<meta charset="utf-8" />
+<meta charset="utf-8">
<body>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
- <script src="/resources/testdriver.js"></script>
+ <script src="/resources/testdriver.js?feature=bidi"></script>
<script src="/resources/testdriver-vendor.js"></script>
<script src="/permissions-policy/resources/permissions-policy.js"></script>
<script>
@@ -13,7 +13,22 @@
"https://{{hosts[alt][]}}:{{ports[https][0]}}" + same_origin_src;
promise_setup(async () => {
- await test_driver.set_permission({ name: "geolocation" }, "granted");
+ // Grant permission for the top-level document's origin.
+ await test_driver.bidi.permissions.set_permission({
+ descriptor: {
+ name: "geolocation"
+ },
+ state: "granted"
+ });
+
+ // Set a default position.
+ await test_driver.bidi.emulation.set_geolocation_override({
+ coordinates: {
+ latitude: 0,
+ longitude: 0,
+ accuracy: 0
+ }
+ });
});
promise_test(async (test) => {
@@ -38,6 +53,15 @@
}, "Permissions-Policy header geolocation=* allows same-origin iframes.");
promise_test(async (test) => {
+ // Grant site-level permission for the cross-origin iframe's origin.
+ await test_driver.bidi.permissions.set_permission({
+ descriptor: {
+ name: "geolocation"
+ },
+ state: "granted",
+ origin: cross_origin_src
+ });
+
await test_feature_availability({
feature_description: "Geolocation API",
test,
diff --git a/testing/web-platform/tests/geolocation/enabled-on-self-origin-by-permissions-policy.https.sub.html b/testing/web-platform/tests/geolocation/enabled-on-self-origin-by-permissions-policy.https.sub.html
@@ -1,8 +1,9 @@
<!DOCTYPE html>
+<meta charset="utf-8">
<body>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
- <script src="/resources/testdriver.js"></script>
+ <script src="/resources/testdriver.js?feature=bidi"></script>
<script src="/resources/testdriver-vendor.js"></script>
<script src="/permissions-policy/resources/permissions-policy.js"></script>
@@ -16,7 +17,22 @@
promise_setup(async () => {
- await test_driver.set_permission({ name: "geolocation" }, "granted");
+ // Grant site-level permission for the top-level document's origin.
+ await test_driver.bidi.permissions.set_permission({
+ descriptor: {
+ name: "geolocation"
+ },
+ state: "granted"
+ });
+
+ // Set a default position.
+ await test_driver.bidi.emulation.set_geolocation_override({
+ coordinates: {
+ latitude: 0,
+ longitude: 0,
+ accuracy: 0
+ }
+ });
});
promise_test(async (t) => {
@@ -40,6 +56,16 @@
}, "Permissions-Policy header geolocation=(self) allows same-origin iframes.");
promise_test(async (test) => {
+ // This is to ensure that the rejection is due to permission policy
+ // instead of site-level permission.
+ await test_driver.bidi.permissions.set_permission({
+ descriptor: {
+ name: "geolocation"
+ },
+ state: "granted",
+ origin: cross_origin_src
+ });
+
await test_feature_availability({
feature_description: "Geolocation API",
test,
