tor-browser

commit 1698007baa61d4c4c742a658c95a690e87f2cc61
parent e3d6fb9d8b9e8132b3dba6747008f67e76c9e9b5
Author: Daisuke Akatsuka <daisuke@birchill.co.jp>
Date:   Tue, 28 Oct 2025 22:00:24 +0000

Bug 1994509: Change the flight status suggestion telemetry name r=adw

Differential Revision: https://phabricator.services.mozilla.com/D270284

Diffstat:
M
browser/components/urlbar/private/FlightStatusSuggestions.sys.mjs
 | 
4
++++
M
browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_realtime_flight_status_engagement.js
 | 
8
++++----
M
browser/components/urlbar/tests/quicksuggest/unit/test_quicksuggest_flight_status.js
 | 
6
+++---

3 files changed, 11 insertions(+), 7 deletions(-)
diff --git a/browser/components/urlbar/private/FlightStatusSuggestions.sys.mjs b/browser/components/urlbar/private/FlightStatusSuggestions.sys.mjs
@@ -20,6 +20,10 @@ export class FlightStatusSuggestions extends RealtimeSuggestProvider {
     return "flightaware";
   }
 
+  get baseTelemetryType() {
+    return "flights";
+  }
+
   getViewTemplateForDescriptionTop(index) {
     return [
       {
diff --git a/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_realtime_flight_status_engagement.js b/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_realtime_flight_status_engagement.js
@@ -63,10 +63,10 @@ add_task(async function click() {
     assertEngagementTelemetry([
       {
         engagement_type: "click",
-        selected_result: "merino_flightStatus",
+        selected_result: "merino_flights",
         selected_position: 2,
         provider: "UrlbarProviderQuickSuggest",
-        results: "search_engine,merino_flightStatus",
+        results: "search_engine,merino_flights",
       },
     ]);
     await PlacesUtils.history.clear();
@@ -85,10 +85,10 @@ add_task(async function enter() {
     assertEngagementTelemetry([
       {
         engagement_type: "enter",
-        selected_result: "merino_flightStatus",
+        selected_result: "merino_flights",
         selected_position: 2,
         provider: "UrlbarProviderQuickSuggest",
-        results: "search_engine,merino_flightStatus",
+        results: "search_engine,merino_flights",
       },
     ]);
     await PlacesUtils.history.clear();
diff --git a/browser/components/urlbar/tests/quicksuggest/unit/test_quicksuggest_flight_status.js b/browser/components/urlbar/tests/quicksuggest/unit/test_quicksuggest_flight_status.js
@@ -56,8 +56,8 @@ add_task(async function telemetry_type() {
     QuickSuggest.getFeature(
       "FlightStatusSuggestions"
     ).getSuggestionTelemetryType({}),
-    "flightStatus",
-    "Telemetry type should be 'flightStatus'"
+    "flights",
+    "Telemetry type should be 'flights'"
   );
 });
 
@@ -222,7 +222,7 @@ function merinoResult() {
       source: "merino",
       provider: "flightaware",
       dynamicType: "flightStatus",
-      telemetryType: "flightStatus",
+      telemetryType: "flights",
       isSponsored: false,
       flightaware: {
         values: [