commit 112b4ba840ea927d80c499d8b8a1f908de9259a3 parent 01e2d5e5c4dc7837675d351eda160494c124bd3f Author: serge-sans-paille <sguelton@mozilla.com> Date: Tue, 28 Oct 2025 12:36:13 +0000 Bug 1996697 - Remove unused mfbt inclusion in xpcom/** r=emilio,media-playback-reviewers,profiler-reviewers,profiles-reviewers,chunmin,canaltinova,mossop Differential Revision: https://phabricator.services.mozilla.com/D270267 Diffstat:
48 files changed, 19 insertions(+), 31 deletions(-)
diff --git a/dom/canvas/DrawTargetWebgl.cpp b/dom/canvas/DrawTargetWebgl.cpp @@ -21,6 +21,7 @@ #include "WebGLVertexArray.h" #include "gfxPlatform.h" #include "mozilla/ClearOnShutdown.h" +#include "mozilla/HelperMacros.h" #include "mozilla/StaticPrefs_gfx.h" #include "mozilla/gfx/AAStroke.h" #include "mozilla/gfx/Blur.h" diff --git a/dom/media/gmp/ChromiumCDMAdapter.cpp b/dom/media/gmp/ChromiumCDMAdapter.cpp @@ -14,6 +14,7 @@ #include "gmp-api/gmp-entrypoints.h" #include "gmp-api/gmp-video-codec.h" #include "mozilla/HelperMacros.h" +#include "mozilla/PodOperations.h" #include "mozilla/dom/KeySystemNames.h" #ifdef XP_WIN diff --git a/dom/onnx/Tensor.cpp b/dom/onnx/Tensor.cpp @@ -11,6 +11,7 @@ #include "js/Value.h" #include "mozilla/Assertions.h" #include "mozilla/Logging.h" +#include "mozilla/PodOperations.h" #include "mozilla/RefPtr.h" #include "mozilla/dom/BindingUtils.h" #include "mozilla/dom/ONNXBinding.h" diff --git a/dom/xml/nsXMLContentSink.cpp b/dom/xml/nsXMLContentSink.cpp @@ -11,6 +11,7 @@ #include "mozilla/CycleCollectedJSContext.h" #include "mozilla/LoadInfo.h" #include "mozilla/Logging.h" +#include "mozilla/PodOperations.h" #include "mozilla/StyleSheetInlines.h" #include "mozilla/UseCounter.h" #include "mozilla/css/Loader.h" diff --git a/extensions/pref/autoconfig/src/nsReadConfig.cpp b/extensions/pref/autoconfig/src/nsReadConfig.cpp @@ -8,6 +8,7 @@ #include "mozilla/Logging.h" #include "mozilla/Components.h" +#include "mozilla/HelperMacros.h" #include "nsAppDirectoryServiceDefs.h" #include "nsIAppStartup.h" #include "nsIChannel.h" diff --git a/gfx/2d/RecordedEvent.h b/gfx/2d/RecordedEvent.h @@ -14,6 +14,7 @@ #include <vector> #include "RecordingTypes.h" +#include "mozilla/PodOperations.h" #include "mozilla/gfx/Point.h" #include "mozilla/gfx/Types.h" #include "mozilla/ipc/ByteBuf.h" diff --git a/gfx/webrender_bindings/WebRenderAPI.cpp b/gfx/webrender_bindings/WebRenderAPI.cpp @@ -11,6 +11,7 @@ #include "mozilla/webrender/RendererOGL.h" #include "mozilla/gfx/gfxVars.h" #include "mozilla/layers/CompositorThread.h" +#include "mozilla/HelperMacros.h" #include "mozilla/StaticPrefs_gfx.h" #include "mozilla/StaticPrefs_webgl.h" #include "mozilla/ToString.h" diff --git a/js/xpconnect/src/xpcprivate.h b/js/xpconnect/src/xpcprivate.h @@ -79,6 +79,7 @@ #include "mozilla/LinkedList.h" #include "mozilla/Maybe.h" #include "mozilla/MemoryReporting.h" +#include "mozilla/PodOperations.h" #include "mozilla/mozalloc.h" #include "mozilla/Preferences.h" #include "mozilla/TimeStamp.h" diff --git a/modules/libpref/Preferences.cpp b/modules/libpref/Preferences.cpp @@ -26,6 +26,7 @@ #include "mozilla/glean/LibprefMetrics.h" #include "mozilla/HashFunctions.h" #include "mozilla/HashTable.h" +#include "mozilla/HelperMacros.h" #include "mozilla/Logging.h" #include "mozilla/Maybe.h" #include "mozilla/MemoryReporting.h" diff --git a/toolkit/components/backgroundhangmonitor/BackgroundHangMonitor.cpp b/toolkit/components/backgroundhangmonitor/BackgroundHangMonitor.cpp @@ -13,6 +13,7 @@ #include "HangDetails.h" #include "ThreadStackHelper.h" #include "mozilla/CPUUsageWatcher.h" +#include "mozilla/HelperMacros.h" #include "mozilla/LinkedList.h" #include "mozilla/Monitor.h" #include "mozilla/Preferences.h" diff --git a/toolkit/profile/nsToolkitProfileService.cpp b/toolkit/profile/nsToolkitProfileService.cpp @@ -5,6 +5,7 @@ #include "mozilla/Preferences.h" #include "mozilla/ErrorResult.h" +#include "mozilla/HelperMacros.h" #include "mozilla/ScopeExit.h" #include "mozilla/Services.h" #include "mozilla/UniquePtr.h" diff --git a/toolkit/xre/nsAppRunner.cpp b/toolkit/xre/nsAppRunner.cpp @@ -13,6 +13,7 @@ #include "mozilla/Components.h" #include "mozilla/FilePreferences.h" #include "mozilla/ChaosMode.h" +#include "mozilla/HelperMacros.h" #include "mozilla/CmdLineAndEnvUtils.h" #include "mozilla/IOInterposer.h" #include "mozilla/ipc/UtilityProcessChild.h" diff --git a/tools/performance/PageloadEvent.cpp b/tools/performance/PageloadEvent.cpp @@ -5,6 +5,7 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ #include "mozilla/Components.h" +#include "mozilla/HelperMacros.h" #include "mozilla/Maybe.h" #include "mozilla/PageloadEvent.h" #include "mozilla/RandomNum.h" diff --git a/tools/profiler/core/platform.cpp b/tools/profiler/core/platform.cpp @@ -45,6 +45,8 @@ #include "ProfilerStackWalk.h" #include "ProfilerRustBindings.h" #include "mozilla/Assertions.h" +#include "mozilla/HelperMacros.h" +#include "mozilla/PodOperations.h" #include "mozilla/Likely.h" #include "mozilla/Maybe.h" #include "mozilla/MozPromise.h" diff --git a/widget/gtk/nsShmImage.cpp b/widget/gtk/nsShmImage.cpp @@ -8,6 +8,7 @@ #ifdef MOZ_HAVE_SHMIMAGE # include "mozilla/X11Util.h" +# include "mozilla/PodOperations.h" # include "mozilla/gfx/gfxVars.h" # include "mozilla/ipc/SharedMemoryMapping.h" # include "gfxPlatform.h" diff --git a/widget/windows/GfxInfo.cpp b/widget/windows/GfxInfo.cpp @@ -18,6 +18,7 @@ #include "xpcpublic.h" #include "mozilla/Components.h" +#include "mozilla/PodOperations.h" #include "mozilla/Preferences.h" #include "mozilla/gfx/DeviceManagerDx.h" #include "mozilla/gfx/Logging.h" diff --git a/xpcom/base/AvailableMemoryTracker.cpp b/xpcom/base/AvailableMemoryTracker.cpp @@ -19,7 +19,6 @@ #include "nsXULAppAPI.h" #include "mozilla/Mutex.h" -#include "mozilla/ResultExtensions.h" #include "mozilla/Services.h" #if defined(MOZ_MEMORY) diff --git a/xpcom/base/CFTypeRefPtr.h b/xpcom/base/CFTypeRefPtr.h @@ -7,7 +7,6 @@ #ifndef CFTypeRefPtr_h #define CFTypeRefPtr_h -#include "mozilla/Assertions.h" #include "mozilla/Attributes.h" #include "mozilla/DbgMacro.h" #include "mozilla/HashFunctions.h" diff --git a/xpcom/base/nsAlgorithm.h b/xpcom/base/nsAlgorithm.h @@ -8,7 +8,6 @@ #define nsAlgorithm_h___ #include <cstdint> -#include "mozilla/Assertions.h" // We use these instead of std::min/max because we can't include the algorithm // header in all of XPCOM because the stl wrappers will error out when included diff --git a/xpcom/base/nsIClassInfoImpl.h b/xpcom/base/nsIClassInfoImpl.h @@ -8,7 +8,6 @@ #define nsIClassInfoImpl_h__ #include "mozilla/Alignment.h" -#include "mozilla/Assertions.h" #include "mozilla/MacroArgs.h" #include "mozilla/MacroForEach.h" #include "nsIClassInfo.h" diff --git a/xpcom/base/nsINIParser.cpp b/xpcom/base/nsINIParser.cpp @@ -9,7 +9,6 @@ #include "nsError.h" #include "nsIFile.h" #include "nsINIParser.h" -#include "mozilla/ResultExtensions.h" #include "mozilla/Try.h" #include "mozilla/URLPreloader.h" diff --git a/xpcom/base/nsISupportsImpl.h b/xpcom/base/nsISupportsImpl.h @@ -22,7 +22,6 @@ #include <type_traits> #include "mozilla/Attributes.h" #include "mozilla/Assertions.h" -#include "mozilla/Likely.h" #include "mozilla/MacroArgs.h" #include "mozilla/MacroForEach.h" diff --git a/xpcom/base/nsMemoryReporterManager.cpp b/xpcom/base/nsMemoryReporterManager.cpp @@ -33,7 +33,6 @@ #include "mozilla/PodOperations.h" #include "mozilla/Preferences.h" #include "mozilla/RDDProcessManager.h" -#include "mozilla/ResultExtensions.h" #include "mozilla/Services.h" #include "mozilla/glean/XpcomMetrics.h" #include "mozilla/UniquePtrExtensions.h" diff --git a/xpcom/base/nsVersionComparator.h b/xpcom/base/nsVersionComparator.h @@ -10,7 +10,6 @@ #ifndef nsVersionComparator_h__ #define nsVersionComparator_h__ -#include "mozilla/Char16.h" #include <stdlib.h> #include <string.h> #include <assert.h> diff --git a/xpcom/base/nscore.h b/xpcom/base/nscore.h @@ -18,7 +18,6 @@ #include <stddef.h> // IWYU pragma: export #include <stdint.h> // IWYU pragma: export -#include "mozilla/HelperMacros.h" // IWYU pragma: export #include "mozilla/RefCountType.h" /* Core XPCOM declarations. */ diff --git a/xpcom/build/Omnijar.cpp b/xpcom/build/Omnijar.cpp @@ -9,6 +9,7 @@ #include "nsDirectoryService.h" #include "nsDirectoryServiceDefs.h" #include "mozilla/GeckoArgs.h" +#include "mozilla/HelperMacros.h" #include "mozilla/ipc/ProcessChild.h" #include "nsIFile.h" #include "nsZipArchive.h" diff --git a/xpcom/build/XPCOMInit.cpp b/xpcom/build/XPCOMInit.cpp @@ -13,7 +13,6 @@ #include "mozilla/AppShutdown.h" #include "mozilla/Assertions.h" #include "mozilla/DebugOnly.h" -#include "mozilla/Poison.h" #include "mozilla/SharedThreadPool.h" #include "mozilla/TaskController.h" #include "mozilla/XPCOM.h" diff --git a/xpcom/ds/nsCOMArray.cpp b/xpcom/ds/nsCOMArray.cpp @@ -6,7 +6,6 @@ #include "nsCOMArray.h" -#include "mozilla/MemoryReporting.h" #include "mozilla/OperatorNewExtensions.h" #include "nsCOMPtr.h" diff --git a/xpcom/ds/nsExpirationTracker.h b/xpcom/ds/nsExpirationTracker.h @@ -22,7 +22,6 @@ #include "nsThreadUtils.h" #include "nscore.h" #include "mozilla/Assertions.h" -#include "mozilla/Likely.h" #include "mozilla/MemoryReporting.h" #include "mozilla/RefCountType.h" #include "mozilla/RefPtr.h" diff --git a/xpcom/ds/nsObserverList.cpp b/xpcom/ds/nsObserverList.cpp @@ -6,7 +6,6 @@ #include "nsObserverList.h" -#include "mozilla/ResultExtensions.h" #include "mozilla/Try.h" #include "nsCOMArray.h" #include "xpcpublic.h" diff --git a/xpcom/ds/nsObserverService.cpp b/xpcom/ds/nsObserverService.cpp @@ -21,7 +21,6 @@ #include "mozilla/net/NeckoCommon.h" #include "mozilla/ProfilerLabels.h" #include "mozilla/ProfilerMarkers.h" -#include "mozilla/ResultExtensions.h" #include "mozilla/TimeStamp.h" #include "mozilla/Try.h" #include "nsString.h" diff --git a/xpcom/ds/nsSimpleEnumerator.cpp b/xpcom/ds/nsSimpleEnumerator.cpp @@ -9,7 +9,6 @@ #include "mozilla/dom/IteratorResultBinding.h" #include "mozilla/dom/RootedDictionary.h" #include "mozilla/dom/ToJSValue.h" -#include "mozilla/ResultExtensions.h" #include "mozilla/Try.h" #include "nsContentUtils.h" diff --git a/xpcom/ds/nsStringEnumerator.cpp b/xpcom/ds/nsStringEnumerator.cpp @@ -7,7 +7,6 @@ #include "nsStringEnumerator.h" #include "nsSimpleEnumerator.h" #include "nsSupportsPrimitives.h" -#include "mozilla/ResultExtensions.h" #include "mozilla/Try.h" #include "mozilla/dom/IteratorResultBinding.h" #include "mozilla/dom/RootedDictionary.h" diff --git a/xpcom/ds/nsSupportsPrimitives.cpp b/xpcom/ds/nsSupportsPrimitives.cpp @@ -5,7 +5,6 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ #include "nsSupportsPrimitives.h" -#include "mozilla/Assertions.h" #include "mozilla/IntegerPrintfMacros.h" #include "mozilla/Sprintf.h" #include <algorithm> diff --git a/xpcom/ds/nsTArray.h b/xpcom/ds/nsTArray.h @@ -18,7 +18,6 @@ #include <type_traits> #include <utility> -#include "mozilla/Alignment.h" #include "mozilla/ArrayIterator.h" #include "mozilla/Assertions.h" #include "mozilla/Attributes.h" diff --git a/xpcom/ds/nsTHashtable.h b/xpcom/ds/nsTHashtable.h @@ -21,7 +21,6 @@ #include "mozilla/Maybe.h" #include "mozilla/MemoryReporting.h" #include "mozilla/OperatorNewExtensions.h" -#include "mozilla/PodOperations.h" #include "mozilla/fallible.h" #include "nsPointerHashKeys.h" #include "nsTArrayForwardDeclare.h" diff --git a/xpcom/io/nsAnonymousTemporaryFile.cpp b/xpcom/io/nsAnonymousTemporaryFile.cpp @@ -14,7 +14,6 @@ #ifdef XP_WIN # include "nsIObserver.h" # include "nsIObserverService.h" -# include "mozilla/ResultExtensions.h" # include "mozilla/Services.h" # include "nsIUserIdleService.h" # include "nsISimpleEnumerator.h" diff --git a/xpcom/io/nsEscape.cpp b/xpcom/io/nsEscape.cpp @@ -6,7 +6,6 @@ #include "nsEscape.h" -#include "mozilla/BinarySearch.h" #include "mozilla/CheckedInt.h" #include "mozilla/TextUtils.h" #include "nsTArray.h" diff --git a/xpcom/io/nsSegmentedBuffer.cpp b/xpcom/io/nsSegmentedBuffer.cpp @@ -8,7 +8,6 @@ #include "nsNetCID.h" #include "nsServiceManagerUtils.h" #include "nsThreadUtils.h" -#include "mozilla/ScopeExit.h" static constexpr uint32_t kSegmentedBufferFreeOMTThreshold = 128; diff --git a/xpcom/ioutils/PathUtils.cpp b/xpcom/ioutils/PathUtils.cpp @@ -13,7 +13,6 @@ #include "mozilla/Maybe.h" #include "mozilla/MozPromise.h" #include "mozilla/RefPtr.h" -#include "mozilla/ResultExtensions.h" #include "mozilla/Span.h" #include "mozilla/Try.h" #include "mozilla/dom/DOMParser.h" diff --git a/xpcom/rust/gtest/bench-collections/Bench.cpp b/xpcom/rust/gtest/bench-collections/Bench.cpp @@ -48,7 +48,6 @@ #include "gtest/gtest.h" #include "gtest/MozGTestBench.h" // For MOZ_GTEST_BENCH #include "mozilla/AllocPolicy.h" -#include "mozilla/HashFunctions.h" #include "mozilla/HashTable.h" #include "mozilla/StaticMutex.h" #include "mozilla/TimeStamp.h" diff --git a/xpcom/string/nsAString.h b/xpcom/string/nsAString.h @@ -10,7 +10,6 @@ #include "nsStringFwd.h" #include "nsStringIterator.h" -#include "mozilla/TypedEnumBits.h" #include <string.h> #include <stdarg.h> diff --git a/xpcom/string/nsLiteralString.h b/xpcom/string/nsLiteralString.h @@ -12,8 +12,6 @@ #include "nsTLiteralString.h" -#include "mozilla/Char16.h" - #define NS_CSTRING_LITERAL_AS_STRING_LITERAL(s) u"" s #define NS_LITERAL_STRING_FROM_CSTRING(s) \ diff --git a/xpcom/tests/gtest/TestMoveString.cpp b/xpcom/tests/gtest/TestMoveString.cpp @@ -10,7 +10,6 @@ #include "nsString.h" #include "nsReadableUtils.h" #include "nsCRTGlue.h" -#include "mozilla/RefPtr.h" #include "gtest/gtest.h" namespace TestMoveString { diff --git a/xpcom/tests/gtest/TestTokenizer.cpp b/xpcom/tests/gtest/TestTokenizer.cpp @@ -4,6 +4,7 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ +#include "mozilla/HelperMacros.h" #include "mozilla/Tokenizer.h" #include "mozilla/IncrementalTokenizer.h" #include "gtest/gtest.h" diff --git a/xpcom/threads/AbstractThread.cpp b/xpcom/threads/AbstractThread.cpp @@ -8,7 +8,6 @@ #include "mozilla/ClearOnShutdown.h" #include "mozilla/DelayedRunnable.h" -#include "mozilla/Maybe.h" #include "mozilla/MozPromise.h" // We initialize the MozPromise logging in this file. #include "mozilla/ProfilerRunnable.h" #include "mozilla/StateWatching.h" // We initialize the StateWatching logging in this file. diff --git a/xpcom/threads/MainThreadIdlePeriod.cpp b/xpcom/threads/MainThreadIdlePeriod.cpp @@ -6,7 +6,6 @@ #include "MainThreadIdlePeriod.h" -#include "mozilla/Maybe.h" #include "mozilla/Preferences.h" #include "mozilla/StaticPrefs_idle_period.h" #include "mozilla/dom/Document.h" diff --git a/xpcom/threads/nsThreadPool.cpp b/xpcom/threads/nsThreadPool.cpp @@ -18,7 +18,6 @@ #include "mozilla/ProfilerLabels.h" #include "mozilla/ProfilerRunnable.h" #include "mozilla/SchedulerGroup.h" -#include "mozilla/ScopeExit.h" #include "mozilla/SpinEventLoopUntil.h" #include "mozilla/StickyTimeDuration.h" #include "nsThreadSyncDispatch.h"