commit 0f05ae33567732ceda0ec74c59a978ef03252ad7
parent dbd6b3e77602c9ada5748a61de36563b6437593e
Author: Emilio Cobos Álvarez <emilio@crisal.io>
Date: Wed, 7 Jan 2026 00:54:27 +0100
Bug 2008041 - Fix DevTools TableWidget checked usage.
Diffstat:
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/devtools/client/shared/widgets/TableWidget.js b/devtools/client/shared/widgets/TableWidget.js
@@ -785,7 +785,7 @@ class TableWidget extends EventEmitter {
menuitem.setAttribute("label", column.header.getAttribute("value"));
menuitem.setAttribute("data-id", column.id);
menuitem.setAttribute("type", "checkbox");
- menuitem.setAttribute("checked", !column.hidden);
+ menuitem.toggleAttribute("checked", !column.hidden);
if (column.id == this.uniqueId) {
menuitem.setAttribute("disabled", "true");
}
@@ -802,7 +802,7 @@ class TableWidget extends EventEmitter {
*/
onPopupCommand(event) {
const item = event.originalTarget;
- let checked = !!item.getAttribute("checked");
+ let checked = item.hasAttribute("checked");
const id = item.getAttribute("data-id");
this.emit(EVENTS.HEADER_CONTEXT_MENU, id, checked);
checked = this.menupopup.querySelectorAll("menuitem[checked]");