tor-browser

commit 08736075c254aa0da21d192daaacc1a0218c5090
parent 8b8a7b5ef2b8963ed9412828f4b47ae728f9fe3b
Author: smayya <smayya@mozilla.com>
Date:   Thu, 27 Nov 2025 10:08:05 +0000

Bug 2002648 - Add cross-site telemetry labels to local network access prompt tracking r=necko-reviewers,valentin DONTBUILD

Extends the local_network_access_prompts_shown metric with new labels to
track cross-site permission prompts separately from same-site prompts.
This enables better analysis of security patterns in local network access requests.

Differential Revision: https://phabricator.services.mozilla.com/D274256

Diffstat:
M
netwerk/base/LNAPermissionRequest.cpp
 | 
24
++++++++++++++++++------
M
netwerk/metrics.yaml
 | 
5
++++-

2 files changed, 22 insertions(+), 7 deletions(-)
diff --git a/netwerk/base/LNAPermissionRequest.cpp b/netwerk/base/LNAPermissionRequest.cpp
@@ -132,13 +132,25 @@ nsresult LNAPermissionRequest::RequestPermission() {
 
   // Record telemetry for permission prompts shown to users
   if (mType.Equals(LOCAL_HOST_PERMISSION_KEY)) {
-    mozilla::glean::networking::local_network_access_prompts_shown
-        .Get("localhost"_ns)
-        .Add(1);
+    if (mIsRequestDelegatedToUnsafeThirdParty) {
+      mozilla::glean::networking::local_network_access_prompts_shown
+          .Get("localhost_cross_site"_ns)
+          .Add(1);
+    } else {
+      mozilla::glean::networking::local_network_access_prompts_shown
+          .Get("localhost"_ns)
+          .Add(1);
+    }
   } else if (mType.Equals(LOCAL_NETWORK_PERMISSION_KEY)) {
-    mozilla::glean::networking::local_network_access_prompts_shown
-        .Get("local_network"_ns)
-        .Add(1);
+    if (mIsRequestDelegatedToUnsafeThirdParty) {
+      mozilla::glean::networking::local_network_access_prompts_shown
+          .Get("local_network_cross_site"_ns)
+          .Add(1);
+    } else {
+      mozilla::glean::networking::local_network_access_prompts_shown
+          .Get("local_network"_ns)
+          .Add(1);
+    }
   }
 
   if (NS_SUCCEEDED(
diff --git a/netwerk/metrics.yaml b/netwerk/metrics.yaml
@@ -1745,7 +1745,8 @@ networking:
     type: labeled_counter
     description: >
       Count of permission prompts shown to users for local network access,
-      separated by localhost vs local network access types.
+      separated by localhost vs local network access types. Cross-site labels
+      are used when the requesting origin differs from the top-level origin.
     bugs:
       - https://bugzilla.mozilla.org/show_bug.cgi?id=1960582
     data_reviews:
@@ -1758,6 +1759,8 @@ networking:
     labels:
       - localhost
       - local_network
+      - localhost_cross_site
+      - local_network_cross_site
 
   local_network_blocked_tracker:
     type: counter